[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-09-02 Thread daniel
daniel added a comment. @bene please add a subtask for the new API module, so we can track that separately. TASK DETAIL https://phabricator.wikimedia.org/T85368 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, daniel Cc: gerritbot, Florian,

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-09-01 Thread Bene
Bene added a comment. https://gerrit.wikimedia.org/r/#/c/234560/ isn't finished yet but I want to get some review first to see if the team agrees this is the right way to go. I will create tests and fix jenkins after I got a +1. TASK DETAIL https://phabricator.wikimedia.org/T85368 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-29 Thread gerritbot
gerritbot added a comment. Change 234675 merged by jenkins-bot: Allow to use custom displayTitle in search https://gerrit.wikimedia.org/r/234675 TASK DETAIL https://phabricator.wikimedia.org/T85368 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-28 Thread Bene
Bene added a comment. Current state of this: in the short term we may replace the javascript module to make the search work basically. However, we want to use cirrus search on Wikidata anyways and that would also solve this issue. This is the long term solution which should be used for desktop

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-28 Thread Bene
Bene added a comment. @daniel I also considered that. What about specifying a parameter in wbsearchentities that enables core's search format. This way we can avoid breaking the api output and do not have another module cluttering our api. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-28 Thread daniel
daniel added a comment. @bene: a separate module would be cleaner, both from the inside and the outside. Adding an option thaqt completely changes the structure of the output is bound to cause confusion, and it leads to multi-option multi-purpose code, which tends to be hard to maintain. In

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-28 Thread daniel
daniel added a comment. @bene If replacing teh JS module proves to be problematic, we can also provide an API module that wraps sbsearchentities and emulates the output format used by core's title search. TASK DETAIL https://phabricator.wikimedia.org/T85368 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-28 Thread Bene
Bene added a comment. After looking deeper into the search api call, I see that MobileFrontend uses prefixsearch only as a generator and gets all the relevant data via action=queryprop=thumbnail. This makes the whole thing a bit harder. I'm not sure if we want to replicate such a specific

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-28 Thread gerritbot
gerritbot added a comment. Change 234560 had a related patch set uploaded (by Bene): Create MediawikiSearchEntities api module https://gerrit.wikimedia.org/r/234560 TASK DETAIL https://phabricator.wikimedia.org/T85368 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-28 Thread gerritbot
gerritbot added a comment. Change 234675 had a related patch set uploaded (by Bene): Allow to use custom displayTitle in search https://gerrit.wikimedia.org/r/234675 TASK DETAIL https://phabricator.wikimedia.org/T85368 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-26 Thread daniel
daniel added a comment. @Bene can you turn your proposal into a patch? That would make it much easier to test and to comment. TASK DETAIL https://phabricator.wikimedia.org/T85368 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, daniel Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-24 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 233405 had a related patch set uploaded (by Jonas Kress (WMDE)): Add the full page title and the article id to search results https://gerrit.wikimedia.org/r/233405 TASK DETAIL https://phabricator.wikimedia.org/T85368

[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Task] search for Wikidata should use entity selector on mobile as well

2015-08-24 Thread gerritbot
gerritbot added a comment. Change 233405 merged by jenkins-bot: Add the full page title and the article id to search results https://gerrit.wikimedia.org/r/233405 TASK DETAIL https://phabricator.wikimedia.org/T85368 EMAIL PREFERENCES