gerritbot added a comment.
Change 224041 merged by jenkins-bot:
Declare variables at begin of scope in snaklistview
https://gerrit.wikimedia.org/r/224041
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
gerritbot added a comment.
Change 224068 merged by jenkins-bot:
Add destroyReferencesListview method to statementview
https://gerrit.wikimedia.org/r/224068
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferenc
gerritbot added a comment.
Change 223548 merged by jenkins-bot:
Add missing fail-safe to counter calculation in statementview
https://gerrit.wikimedia.org/r/223548
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailp
gerritbot added a comment.
Change 223547 merged by jenkins-bot:
Allow switching to edit mode with "null" references in statementview
https://gerrit.wikimedia.org/r/223547
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
gerritbot added a comment.
Change 223544 merged by jenkins-bot:
Fix wrong assumption in statementview
https://gerrit.wikimedia.org/r/223544
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemow
gerritbot added a comment.
Change 223545 merged by jenkins-bot:
Rename wrong private method name in statementview
https://gerrit.wikimedia.org/r/223545
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
gerritbot added a comment.
Change 224076 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add combined statementview-referenceview remove toolbar
https://gerrit.wikimedia.org/r/224076
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wiki
gerritbot added a comment.
Change 224074 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add missing listview dependencies to toolbar controllers
https://gerrit.wikimedia.org/r/224074
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wik
gerritbot added a comment.
Change 224072 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Include references in statementview.isInitialValue()
https://gerrit.wikimedia.org/r/224072
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimed
gerritbot added a comment.
Change 224068 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add destroyReferencesListview method to statementview
https://gerrit.wikimedia.org/r/224068
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikime
gerritbot added a comment.
Change 224041 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Declare variables at begin of scope in snaklistview
https://gerrit.wikimedia.org/r/224041
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedi
gerritbot added a comment.
Change 223541 merged by jenkins-bot:
More flexible options handling in referenceview tests
https://gerrit.wikimedia.org/r/223541
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferenc
gerritbot added a comment.
Change 223311 merged by jenkins-bot:
Use ReferenceChanger instead of ChangersFactory in statementview
https://gerrit.wikimedia.org/r/223311
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/ema
gerritbot added a comment.
Change 223317 merged by jenkins-bot:
Drop not needed local variable in statementview
https://gerrit.wikimedia.org/r/223317
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
T
gerritbot added a comment.
Change 223548 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add missing fail-safe to counter calculation in statementview
https://gerrit.wikimedia.org/r/223548
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricato
gerritbot added a comment.
Change 223547 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Allow switching to edit mode with "null" references in statementview
https://gerrit.wikimedia.org/r/223547
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://pha
gerritbot added a comment.
Change 223545 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Rename wrong private method name in statementview
https://gerrit.wikimedia.org/r/223545
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.
gerritbot added a comment.
Change 223544 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix wrong assumption in statementview
https://gerrit.wikimedia.org/r/223544
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings
gerritbot added a comment.
Change 223542 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make referencesChanger optional in the referenceview widget
https://gerrit.wikimedia.org/r/223542
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.
gerritbot added a comment.
Change 223541 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
More flexible options handling in referenceview tests
https://gerrit.wikimedia.org/r/223541
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikime
gerritbot added a comment.
Change 223317 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Drop not needed local variable in statementview
https://gerrit.wikimedia.org/r/223317
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.or
gerritbot added a comment.
Change 223311 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Use ReferenceChanger instead of ChangersFactory in statementview
https://gerrit.wikimedia.org/r/223311
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabric
gerritbot added a comment.
Change 220141 merged by jenkins-bot:
Fix minor bug in referenceview.js
https://gerrit.wikimedia.org/r/220141
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde,
gerritbot added a comment.
Change 220432 merged by jenkins-bot:
Drop not needed private property in statementview.js
https://gerrit.wikimedia.org/r/220432
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreference
gerritbot added a comment.
Change 220432 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Drop not needed private property in statementview.js
https://gerrit.wikimedia.org/r/220432
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimed
gerritbot added a comment.
Change 220141 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix minor bug in referenceview.js
https://gerrit.wikimedia.org/r/220141
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/pan
thiemowmde added a comment.
Had a chat with @Snaterlicious. We found that @adrianheine's comments in
https://gerrit.wikimedia.org/r/#/c/190799/8/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
are relevant.
- Current situation is that the widget requires a ClaimsChanger and a
E
Tobi_WMDE_SW added a comment.
It needs to be checked what gadgets and external tools will brak due to this.
TASK DETAIL
https://phabricator.wikimedia.org/T87759
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
.
EMAIL PREFERENCES
https:/
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 190799 had a related patch set uploaded (by Adrian Lang):
Edit References along with Statement
https://gerrit.wikimedia.org/r/190799
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL
https://phabrica
29 matches
Mail list logo