Jdlrobson added a comment.
1. Add the banner via CSS, not as an img tag. This way we can easily
configure the size of the image by creating responsive css rules with
`@media` queries. We can also easily create a different stylesheet for the
MobileFrontend extension.
It's actually better
Sumit added a comment.
@Jdlrobson, descoped the editing of banner image source using UI part of the
proposal as per your suggestion.
TASK DETAIL
https://phabricator.wikimedia.org/T93106
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
Jdlrobson added a comment.
@Sumit my opinion on Phase V: I think you should de-scope this from your GSoc
proposal. {{PAGEBANNER}} should be completely optional and simply used for
overriding the value from Wikidata. For this reason I think an editor might not
make sense here as a first
Sumit added a comment.
@Bene, thanks for your suggestions. Just a small view regarding:
Concerning the edit box, as it should also be possible to edit Wikidata in
this box, please work closely with the Wikidata team for that feature.
The current pagebanner template uses a different url in
Nemo_bis added a comment.
I'm still not seeing which Wikivoyage edition(s) volunteered to test/adopt this
extension.
TASK DETAIL
https://phabricator.wikimedia.org/T93106
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL
Bene added a comment.
Hey, I have a few suggestions to your proposal:
1. Use an article keyword like `{{DISPLAYTITLE:Abc}}` instead of a parser
function, as it affects the article's header and will not be replaced by some
html but rather modify another part of the page. I'd suggest
Jdlrobson added a comment.
@Wrh2 thanks for sharing the links and @Nemo_bis thanks for the poke, super
keen to set @sumit up for success!
TASK DETAIL
https://phabricator.wikimedia.org/T93106
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
Wrh2 added a comment.
In https://phabricator.wikimedia.org/T93106#1173339, @Nemo_bis wrote:
Wikivoyage in what language? What language editions have been contacted about
this proposal?
I'm not sure of all notifications that have been done, but I've seen feedback
solicited in the English
Sumit added a comment.
I've setup the boilerplate extension on my userspace at github, now filling in
a request at https://www.mediawiki.org/wiki/Gerrit/New_repositories for
migrating this to gerrit for further development
https://github.com/codez266/WikiDataPageBannerExtension
TASK DETAIL
Jdlrobson added a comment.
If anyone takes on the microtask associated with that and completes it I have
plenty more to add and it would certainly make someone a stronger candidate in
my eyes.
TASK DETAIL
https://phabricator.wikimedia.org/T93106
REPLY HANDLER ACTIONS
Reply to comment or
Qgil added a comment.
@Sumit, thank you for this project proposal. Have you got a chance to complete
one or more microtasks? I am not the right person to evaluate your proposal,
but I can tell that you have clearly put a good amount of work here, and
complementing this with completed
11 matches
Mail list logo
