Addshore added a comment.
In T95663#3444616, @Legoktm wrote:
I think we should start this by doing it one extension/library at a time, starting with those that aren't modified as often. Libraries should go in mediawiki/vendor (though there's still a dependency listed in Wikibase's composer.json)
Legoktm added a comment.
@Addshore and I have been discussing this lately and he uploaded a giant proof of concept to add the Wikidata dependencies to mediawiki/vendor: https://gerrit.wikimedia.org/r/#/c/364712/2
I think we should start this by doing it one extension/library at a time, starting
thcipriani added a comment.
The initial step is composer dependencies, so it sounds like all wikidata extensions's composer dependencies need to be tracked somehow in mediawiki/vendor.
Next, Wikidata extensions are not submodules of Wikidata master, so we need to also figure out how to track
Reedy added a comment.
Can't see much reason that you can't just do that...TASK DETAILhttps://phabricator.wikimedia.org/T95663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: demon, ReedyCc: Reedy, greg, Krinkle, hoo, Lydia_Pintscher, bd808, JeroenDeDauw,
hoo added a comment.
Any updates here? For us it's good enough if we can manually update the vendor "build" when needed, we don't need any automatism here that reacts upon Wikibase wmf-branch changes.TASK DETAILhttps://phabricator.wikimedia.org/T95663EMAIL
hoo added a comment.
@Reedy We have our "dependency template" in the wikidata/build-resources repo. It's mostly just straight-forward pulling things in via composer, but we also do some evil-ish magic in build/tasks/updatecomposer.js.
Also we have two scripts running via composer (also in the
Reedy added a comment.
And using composer-merge-plugin would only make sense if we were building the vendor on the fly during the deployment process, as it could then crawl and include as necessary..
Expecting everyone to have the same dev setup so that a composer.local.json type file that
Reedy added a comment.
Just add the stuff you need to mediawiki-vendor? :) Presumably everything that's in Wikidata/vendor should just go into mediawiki-vendor. Not tracking dev-master though, because that will mean random people doing composer update will get random updates that they won't know
demon added a comment.
In T95663#3100585, @Legoktm wrote:
If it's a library, it should be published on packagist and added to mediawiki/vendor like all other libraries are.
Well, that's mostly the thought here, but the task summary may be a little unclear (this was born out of a conversation
Legoktm added a comment.
I don't think there's any need to use the composer-merge-plugin here...if something is a MW extension, it should be under the mw/extensions/ hierarchy in Gerrit, and brought in through the normal deployment process. If it's a library, it should be published on packagist
demon added a comment.
I just simply haven't had the time to look into it yet, I apologize.TASK DETAILhttps://phabricator.wikimedia.org/T95663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: demonCc: hoo, Lydia_Pintscher, bd808, JeroenDeDauw, Legoktm,
hoo added a comment.
Any updates here @demon? Is there anything we can/ should do to get this going?TASK DETAILhttps://phabricator.wikimedia.org/T95663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: demon, hooCc: hoo, Lydia_Pintscher, bd808, JeroenDeDauw,
12 matches
Mail list logo
