Manybubbles added a comment.
In https://phabricator.wikimedia.org/T95779#1201191, @Smalyshev wrote:
I think in this case we shouldn't mess with the data. Rather, we'd have
something like function bestLabel(item, languages) e.g. bestLabel(wd:Q123,
'en', 'de', 'ru', 'es') which would try to
Smalyshev added a comment.
I think in this case we shouldn't mess with the data. Rather, we'd have
something like function bestLabel(item, languages) e.g. bestLabel(wd:Q123,
'en', 'de', 'ru', 'es') which would try to find labels on any language but if
not just return something like 'Q123'. The
Manybubbles added a comment.
Its how I designed single label mode but I now think its stupid. The point
of single label was that you could always get a single label for a thing
and its in one of the languages you ask for.
Instead I think it shouldn't ever add a label or description if there
Smalyshev added a comment.
Reproducible with input F83: in.ttl
https://phabricator.wikimedia.org/F83 and this command line:
`java -cp target/wikidata-query-tools-0.0.1-SNAPSHOT-jar-with-dependencies.jar
org.wikidata.query.rdf.tool.Munge --from in.ttl --to out --labelLanguage en
Smalyshev added a comment.
I think it happens because singleLabelModeWorkForDescription and
singleLabelModeWorkForLabel both generate this:
return new StatementImpl(entityUriImpl, new URIImpl(RDFS.LABEL),
entityUriImpl);
Which obviously wrong for description and I suspect also wrong for
