aude created this task.
aude added a subscriber: aude.
aude added projects: Wikidata, Wikibase-DataModel.
Herald added a subscriber: Aklapper.

TASK DESCRIPTION
  Fingerprint apparently can be null, and code like:
  
          if ( !$this->getFingerprint()->hasLabel( $languageCode ) ) {          
                      
              return false;                                                     
                      
          }
  
  does not check if Finterprint is null. :(
  
  Exception encountered, of type "BadMethodCallException"
  [22b2aebf] /wiki/United_States BadMethodCallException from line 221 of 
/var/www/wiki/w/extensions/Wikidata/vendor/wikibase/data-model/src/Entity/Entity.php:
 Call to a member function hasLabel() on a non-object (NULL)
  Backtrace:
  #0 
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/LanguageLinkBadgeDisplay.php(174):
 Wikibase\DataModel\Entity\Entity->getLabel(string)
  #1 
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/LanguageLinkBadgeDisplay.php(143):
 
Wikibase\Client\Hooks\LanguageLinkBadgeDisplay->getLabel(Wikibase\DataModel\Entity\ItemId)
  #2 
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/LanguageLinkBadgeDisplay.php(68):
 Wikibase\Client\Hooks\LanguageLinkBadgeDisplay->getBadgeInfo(array)
  #3 
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/client/includes/LangLinkHandler.php(379):
 Wikibase\Client\Hooks\LanguageLinkBadgeDisplay->attachBadgesToOutput(array, 
ParserOutput)
  #4 
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandlers.php(122):
 Wikibase\LangLinkHandler->addLinksFromRepository(Title, ParserOutput)
  #5 
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandlers.php(81):
 
Wikibase\Client\Hooks\ParserOutputUpdateHookHandlers->doContentAlterParserOutput(Title,
 ParserOutput)
  #6 /var/www/wiki/w/includes/Hooks.php(204): 
Wikibase\Client\Hooks\ParserOutputUpdateHookHandlers::onContentAlterParserOutput(WikitextContent,
 Title, ParserOutput)
  #7 /var/www/wiki/w/includes/content/AbstractContent.php(501): 
Hooks::run(string, array)
  #8 /var/www/wiki/w/includes/poolcounter/PoolWorkArticleView.php(140): 
AbstractContent->getParserOutput(Title, integer, ParserOptions)
  #9 /var/www/wiki/w/includes/poolcounter/PoolCounterWork.php(123): 
PoolWorkArticleView->doWork()
  #10 /var/www/wiki/w/includes/page/Article.php(676): PoolCounterWork->execute()
  #11 /var/www/wiki/w/includes/actions/ViewAction.php(44): Article->view()
  #12 /var/www/wiki/w/includes/MediaWiki.php(456): ViewAction->show()
  #13 /var/www/wiki/w/includes/MediaWiki.php(255): 
MediaWiki->performAction(Article, Title)
  #14 /var/www/wiki/w/includes/MediaWiki.php(677): MediaWiki->performRequest()
  #15 /var/www/wiki/w/includes/MediaWiki.php(474): MediaWiki->main()
  #16 /var/www/wiki/w/index.php(41): MediaWiki->run()

TASK DETAIL
  https://phabricator.wikimedia.org/T107895

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: Aklapper, aude, Wikidata-bugs, JeroenDeDauw, Malyacko, P.Copp



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to