Anomie created this task.

TASK DESCRIPTION
  The load.php endpoint is not supposed to depend on session data, however 
Wikibase\SitesModule depends on the language of $wgUser.
  
    SessionManager.php line 190 calls 
MediaWiki\Session\SessionManager->getSessionFromInfo()
    WebRequest.php line 664 calls 
MediaWiki\Session\SessionManager->getSessionForRequest()
    User.php line 1174 calls WebRequest->getSession()
    User.php line 384 calls User->loadFromSession()
    User.php line 5087 calls User->load()
    User.php line 2705 calls User->loadOptions()
    RequestContext.php line 368 calls User->getOption()
    StubObject.php line 204 calls RequestContext->getLanguage()
    StubObject.php line 160 calls StubUserLang->_newObject()
    StubObject.php line 104 calls StubObject->_unstub()
    StubObject.php line 179 calls StubObject->_call()
    MessageCache.php line 822 calls StubUserLang->__call()
    MessageCache.php line 767 calls MessageCache->getMessageFromFallbackChain()
    Message.php line 1148 calls MessageCache->get()
    Message.php line 910 calls Message->fetchMessage()
    SitesModuleWorker.php line 141 calls Message->exists()
    SitesModuleWorker.php line 119 calls 
Wikibase\Lib\SitesModuleWorker->getSiteDetails()
    SitesModule.php line 45 calls Wikibase\Lib\SitesModuleWorker->getScript()
    ResourceLoaderModule.php line 576 calls Wikibase\SitesModule->getScript()
    ResourceLoaderModule.php line 544 calls ResourceLoaderModule->buildContent()
    ResourceLoader.php line 976 calls ResourceLoaderModule->getModuleContent()
    ResourceLoader.php line 705 calls ResourceLoader->makeModuleResponse()
    load.php line 45 calls ResourceLoader->respond()
    load.php line 3 calls include()
  
  If the special site names aren't supposed to depend on the user's language, 
you could just use ->inContentLanguage() on the Message object. Otherwise, you 
might use the 'MakeGlobalVariablesScript' hook instead.

TASK DETAIL
  https://phabricator.wikimedia.org/T127872

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Anomie
Cc: StudiesWorld, Tgr, Aklapper, Krinkle, gerritbot, ArielGlenn, Anomie, Izno, 
Wikidata-bugs, aude, Mbch331



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to