awight created this task. awight added projects: Lexicographical data, Wikibase-DataModel. Restricted Application added a project: Wikidata. |
When running unit tests on recent WikibaseLexeme, I get a fatal interpreter error. The UI also whitescreens.
Using PHP 7.1.16 PHP Fatal error: Class Wikibase\Lexeme\DataModel\Form cannot implement previously implemented interface Wikibase\DataModel\Entity\ClearableEntity in /srv/mediawiki-extensions/WikibaseLexeme/src/DataModel/Form.php on line 23
This problem can be resolved with a patch, https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/464083/
However, strange problems show up in the docker CI output, suggesting that the wikibase/data-model library is somehow out of sync. CI reports that version 8.0.0 of the library is installed, which is what I have locally, but tests fail with an param-illegal error. This can be emitted by various validations in Wikibase, but I'm suspecting EditEntity::dieIfNotClearable, which looks like it would fail if the ClearableEntity interface were not inherited correctly.
Regardless of the specific cause, I would worry that the production migration might be problematic, it seems that you'll experience a crash whether deploying the library upgrade first, or the patch first.
Cc: awight, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs