Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Shape Expressions Sprint 5. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Repeat of T218299: Check for edit conflicts in schema undo/restore/rollback(?) <https://phabricator.wikimedia.org/T218299>, because I just realized we’re not quite done checking for edit conflicts. `SchemaWriter::overwriteWholeSchema()`, which is used for both undo and rollback, has no base revision ID argument, so while it’s true that `UndoSubmitAction` and `RestoreSubmitAction` check for edit conflicts already, there’s no guarantee that the revision they’re checking against is the same revision that `MediaWikiRevisionSchemaWriter` will get from `PageUpdater::grabParentRevision()`. TASK DETAIL https://phabricator.wikimedia.org/T219531 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, pdehaye, alaa_wmde, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs