thiemowmde added subscribers: Lydia_Pintscher, daniel, thiemowmde.
thiemowmde added a project: DataValues.
thiemowmde triaged this task as "Lowest" priority.
thiemowmde added a comment.

Note that these coordinates are not "invalid" per-se. The LatLongValue class in Wikibase does have a range check that limits latitude and longitude to ]-360, +360[. This is done on purpose and not a mistake. It depends on the globe if a coordinate like "120° N, 111° E" can be considered valid or not.

Here are some ideas of what can be done:

  • Make sure external validation tools for wikidata.org know about this and suggest to fix coordinates on Earth that have weird values like this.
  • We could add an actual validation step to the Wikibase code base that limits the values, in case the globe is known to be Earth. We already have code that hard-codes http://www.wikidata.org/entity/Q2 in multiple places, so this would not even introduce a new dependency.
  • Make the code that consumes such values aware of it, and either skip or transform them. Transformation is possible, because these coordinates still describe a unique point on a globe, even if the format is "invalid". There is even existing code for said normalization in https://github.com/DataValues/Geo/blob/master/src/GlobeMath.php.

TASK DETAIL
https://phabricator.wikimedia.org/T160140

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, daniel, Lydia_Pintscher, Aklapper, MaxSem, EBernhardson, QZanden, EBjune, Avner, debt, Gehel, D3r1ck01, FloNight, Izno, Wikidata-bugs, aude, Deskana, jayvdb, Mbch331, jeremyb
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to