[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Tech Verification to Done on the Wikidata-Campsite (Team A Hearth 🏰🔥) board. Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a comment. T292203

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Lucas_Werkmeister_WMDE closed subtask T292203: Only format entity links with labels in edit summaries and on special pages as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T140879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werk

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Michael edited projects, added Wikidata-Campsite (Team A Hearth 🏰🔥); removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)). TASK DETAIL https://phabricator.wikimedia.org/T140879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Lucas_Werkmeister_WMDE added a comment. I opened a subtask for fixing this formatting: T292203: Only format entity links with labels in edit summaries TASK DETAIL https://phabricator.wikimedia.org/T140879 EMAIL PREFERENCES https://phabricator.w

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Lucas_Werkmeister_WMDE added a comment. And if you sort that first XHGui report by inclusive wall time (i.e. how much time was spent in a function, including all the other functions it called), the `HtmlPageLinkRendererEndHookHandler` methods indeed take up some 35 seconds of wall time, at 2

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Lucas_Werkmeister_WMDE added a comment. This also explains the thousands of database queries. This hook handler sees one link at a time – it has no chance to preload or batch any labels, it makes one request at a time. (Or so I assume.) TASK DETAIL https://phabricator.wikimedia.org/T140879

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Lucas_Werkmeister_WMDE added a comment. > Rendering some diffs of these pages not only takes a long time, but also makes an almost exorbitant amount of database queries. And yet – > But it doesn’t look like most of the time is spent in diffing either: I built some `&diffonly=yes` UR

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Lucas_Werkmeister_WMDE added a comment. I looked at this a bit in XHGui. I’ll explain the requests I made chronologically, hopefully that’ll make sense. First up is this XHGui run for a diff timeout (for the

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T140879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lucas_Werkmeister_WMDE, M

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Lucas_Werkmeister_WMDE added a comment. Here’s the parser output comment for the /P​570 page (current revision): Apparently this one only took 13 seconds of real time (far from the 60 seconds limit), but most of that time isn’t being spent in Lua. But it doesn’t look lik

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]

Addshore renamed this task from "WMFTimeoutException when loading some diffs on Wikidata" to "WMFTimeoutException when loading some diffs on Wikidata [Timebox 8h]". TASK DETAIL https://phabricator.wikimedia.org/T140879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/email

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T140879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Marostegui, WMDE-Fisch, Epidosis, Addshore, jcrespo, Aklapper, abian, Zppix, Invadibot, maantiet

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata

Addshore added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T140879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Marostegui, WMDE-Fisch, Epidosis, Addshore, jcrespo, Aklapper, abian, Zppix, Invadibot, ma

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata

Addshore added a comment. This could just be that this is a huge page being diffed and that we can't do much about it. There are some tickets in the backlog relating to quality constraints and the future of these reports in general that might end up rendering these pages not needed any mor

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata

Addshore added a comment. In T140879#7114261 , @Marostegui wrote: > Is this still happening? It would appear so yes! At least one the 2 links I tested: - https://www.wikidata.org/w/index.php?title=Wikidata:Database_reports/Co

[Wikidata-bugs] [Maniphest] T140879: WMFTimeoutException when loading some diffs on Wikidata

Marostegui removed a project: SRE. Marostegui added a comment. Is this still happening? TASK DETAIL https://phabricator.wikimedia.org/T140879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Marostegui Cc: Marostegui, WMDE-Fisch, Epidosis, Addshore