[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

thiemowmde added a comment. I think the problem we have are the unknown unknowns – situations we currently can't think of. I would love to ask the question the other way around: When does it make sense to cut off an arbitrary part of a button label? Or maybe like this: What's worse, a bu

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE added a comment. As part of our proposal to include a prop to allow button text wrapping in the new design system, I'm in the look-out for real examples where it would definitely make sense to let a button label wrap. I agree with the preventive approach that accommodates for loca

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel closed this task as "Resolved". Manuel added a comment. Thank you, everyone! \o/ About the missing no-wrap behavior: I still marked this task as resolved, as I would very much prefer a centralized solution over individual investments in separate style modules. So we need to make a

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Arian_Bozorg added a comment. Just tagging @Manuel for verification on this one TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Arian_Bozorg Cc: Arian_Bozorg, hoo, jon_amar-WMDE, Itama

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

noarave moved this task from Doing to Product Verification on the Wikidata Dev Team (Sprint-∞) board. noarave added a comment. Moving this back to product verification as per above comments. TASK DETAIL https://phabricator.wikimedia.org/T165870 WORKBOARD https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

hoo added a comment. In T165870#8891647 , @Sarai-WMDE wrote: > > From my side, I'll proceed to bring the topic up to the attention of the Design system team at WMF. I think this requires a centralized solution: we'll discuss if it ma

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE added a comment. It appears that, in order to bypass the no-wrap behaviour of the OOUI button in this (or any) special page, we'd have to write separate style modules each time. It is unclear if this is a fair trade-off to solve potential edge cases (we're trying to cover for all

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE added a comment. This looks good and matches the latest specifications described in https://phabricator.wikimedia.org/T165870#8854823. Thank you! There's only a last change needed: in order to prevent the button from overflowing the layout due to the length of the copy in certain

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: jon_amar-WMDE, ItamarWMDE, Lucas_Werkmeister_WMDE, karapayneWMDE, Michael, Lydia_Pi

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Maintenance_bot Cc: jon_amar-WMDE, ItamarWMDE, Lucas_Werkmeister_WMDE, karapayneWMDE, M

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30). TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, ReleaseTaggerBot Cc: jon_amar-WMDE, ItamarWMDE, Lucas_Werkmeist

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

gerritbot added a comment. Change 919850 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Change submit button copy for Special:SetLabelDescriptionAliases https://gerrit.wikimedia.org/r/919850 TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCE

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE added a comment. @noarave as discussed in an off-line conversation, I wonder if it would be possible to remove the license text from the first step and only include it in the last part, rather than dynamically changing the copy. After all, as Itamar mentioned, no changes are actua

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, gerritbot Cc: jon_amar-WMDE, ItamarWMDE, Lucas_Werkmeister_WMDE, karapayneWMDE, Michael, Lydia

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

gerritbot added a comment. Change 919850 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [mediawiki/extensions/Wikibase@master] Change submit button copy for Special:SetLabelDescriptionAliases https://gerrit.wikimedia.org/r/919850 TASK DETAIL https://phabricator

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

noarave claimed this task. noarave moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. Restricted Application added a project: User-Noarave. TASK DETAIL https://phabricator.wikimedia.org/T165870 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel added a comment. I was thinking about the general case. But if that decision was consciously made at some point, let's stick to it for this task as well. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Lydia_Pintscher added a comment. I am not sure it makes sense to make this decision in isolation for this button. We have made the decision before to follow the setting everywhere. It'd feel weird to me to change this here unless we make this a general decision to not support the setting any

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel added a subscriber: jon_amar-WMDE. Manuel added a comment. Publish would be fine for both Wikidata and Wikibase Cloud. I don't know about Wikibase Suite: @jon_amar-WMDE: Per our values of openness and accessibility, should we actively cater to non-public Wikibase instances with a

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE added a comment. Restricted Application added a project: User-ItamarWMDE. In T165870#8822927 , @ItamarWMDE wrote: > **Task Breakdown Notes;** > > - Is it actually a user requirement to have different copy depending on the

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Lucas_Werkmeister_WMDE added a comment. (My note is referring to $wgEditSubmitButtonLabelPublish , which we respect elsewhere in Wikibase, see e.g. T161367 and T228260

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

ItamarWMDE added a comment. **Task Breakdown Notes;** - Is it actually a user requirement to have different copy depending on the context of the Wikibase instance? @Sarai-WMDE @Manuel (In reference to the note by Lucas) **Potential Plan of Action**: 1. Find the translation key

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE added a comment. Thanks, @Nikki and @thiemowmde, for your input on the button label wrapping. I agree with your points and thus updated the task description accordingly. Heads-up to @Manuel. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Lucas_Werkmeister_WMDE, karapayneWMDE, Michael, Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki,

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

karapayneWMDE moved this task from Unified prioritized backlog to Sprint-∞ on the Wikidata Dev Team board. karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T165870 WORKBOARD https://phabricator.wikime

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

thiemowmde added a comment. As someone still watching this ticket: I honestly never understood why OOUI hard-codes a `nowrap` in this situation. It's never helpful, especially not in an

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Nikki added a comment. In T165870#8720589 , @Sarai-WMDE wrote: > Hey @Nikki 👋🏻 The thing is that it is generally a good practice in interface design to both use short, clear labels for actions (to improve readability) and prevent butto

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE added a comment. Hey @Nikki 👋🏻 The thing is that it is generally a good practice in interface design to both use short, clear labels for actions (to improve readability) and prevent button labels from breaking into more than one line (to improve legibility). This is why the

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Nikki added a comment. Please don't forget to fix the problem. :) Changing the text will be an improvement, but won't make the text on the button wrap on smaller screens when it needs to. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel added a subscriber: Lucas_Werkmeister_WMDE. Manuel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel Cc: Lucas_Werkmeister_WMDE, LucasWerkmeister, karapayn

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE added a subscriber: LucasWerkmeister. Sarai-WMDE added a comment. Based on a recent conversation, and thanks to @LucasWerkmeister's input, I settled on a new suggestion for the copy of the button at the last step of the form: "Publish changes". The new copy tries to: 1. Be mor

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel Cc: karapayneWMDE, Michael, Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, PokestarFan, thi

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel added a comment. I created a new task to address the copy variations of our "Publish" buttons (T332705 ). TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefer

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: karapayneWMDE, Michael, Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, Pokestar

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel Cc: karapayneWMDE, Michael, Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, PokestarFan, thi

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel Cc: karapayneWMDE, Michael, Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, PokestarFan, thi

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Lydia_Pintscher added a comment. Also https://www.wikidata.org/wiki/Special:SetLabel and maybe https://www.wikidata.org/wiki/Special:SetSitelink TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

karapayneWMDE set the point value for this task to "3". TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: karapayneWMDE, Michael, Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxin

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

karapayneWMDE added a comment. Sprint 6 Planning - Notes regarding copy on the button: - https://www.wikidata.org/wiki/Special:SetDescription - https://www.wikidata.org/wiki/Special:SetAliases - one datapoint: Wikidata Bridge is using save/publish based on the setting - https://ww

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, PokestarFan, thiemowmde, Lucie,

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel added a comment. Looks great, thank you @Sarai-WMDE! \o/ TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel Cc: Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, PokestarFa

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE added a comment. @Lydia_Pintscher @Manuel I updated the task description with my recommendation. Let me know what you think 🙏🏻 TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Sarai-WMDE removed Sarai-WMDE as the assignee of this task. Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Lydia_Pintscher, Manuel, Sarai-WM

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel assigned this task to Sarai-WMDE. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE, Manuel Cc: Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, PokestarFan, thiemowmde,

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

Manuel renamed this task from "Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens" to "MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens". TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://