[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Addshore closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete, Addshore Cc: WMDE-leszek, Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE, Rzuwig,

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. went through the list of repos again. I created a PR for those who don't have phpcs as part of `composer test` https://github.com/wmde/WikibaseDataModelServices/pull/248 https://github.com/wmde/WikibaseDataModelSerialization/pull/261

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. @thiemowmde thank you for the detailed info. I will go through the repos again TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Addshore, JeroenDeDauw,

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

thiemowmde added a comment. I'm not working with these codebases any more. But since I created this ticket once, I had a quick look at some random codebases I could find. These execute phpcs as part of `composer test`: - https://github.com/wmde/Number/blob/master/composer.json#L56

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Addshore added a comment. In T188395#7042168 , @bete wrote: > @Addshore I only found one repo that doesn't run `phpcs` as part of `composer test`. > maybe we need to update the doku

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

JeroenDeDauw added a comment.  TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete, JeroenDeDauw Cc: Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE, Rzuwig, thiemowmde,

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. PR for the one repo that is not running code sinffer in `composer test` can be found here TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. @Addshore I only found one repo that doesn't run `phpcs` as part of `composer test`. maybe we need to update the doku TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. wmde/Time has runs `phpcs` as part of `composer test ` as can be seen here TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. this repository already runs phpcs as part of `composer test` TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Addshore,

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE, Rzuwig, thiemowmde, Aklapper, Invadibot,

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Lydia_Pintscher moved this task from Prioritized Tech (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. Lydia_Pintscher edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Lydia_Pintscher set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE, Rzuwig, thiemowmde, Aklapper,

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Addshore added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE, Rzuwig, thiemowmde,

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Addshore moved this task from legacy-backlog to To Prioritize on the wdwb-tech-focus board. Addshore edited projects, added wdwb-tech-focus; removed wdwb-tech-focus (legacy-backlog). TASK DETAIL https://phabricator.wikimedia.org/T188395 WORKBOARD

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Addshore moved this task from Backlog to backlog on the wdwb-tech-focus board. Addshore edited projects, added wdwb-tech-focus (backlog); removed wdwb-tech-focus. TASK DETAIL https://phabricator.wikimedia.org/T188395 WORKBOARD https://phabricator.wikimedia.org/project/board/3532/ EMAIL

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Addshore moved this task from Cross Cutting to backlog on the wdwb-tech-focus board. Addshore edited projects, added wdwb-tech-focus (backlog); removed wdwb-tech-focus. Restricted Application edited projects, added wdwb-tech-focus; removed wdwb-tech-focus (backlog). TASK DETAIL

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

Addshore added a project: User-Addshore. Addshore added a comment. This probably falls nicely under one of the vision categories being "Consistent tooling" and "Consistent structure". Description needs updating... TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES