[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

amy_rc closed this task as "Resolved". amy_rc moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. amy_rc added a comment. tested now and it worked.  TASK DETAIL https://phabricator.wikimedia.org/T250550 WORKBOARD

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lucas_Werkmeister_WMDE added a comment. In T250550#6855811 , @amy_rc wrote: > I tested on the sandbox. but the space still exists. > F34120816: Hnet-image.gif Yes, the fix hasn’t

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

amy_rc added a comment. I tested on the sandbox. but the space still exists. TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, amy_rc Cc: amy_rc, Lydia_Pintscher, i_amy,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Lydia_Pintscher, i_amy, Jakob_WMDE, So9q,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a comment. Change 665108 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Synchronize state with LexemeHeader more consistently https://gerrit.wikimedia.org/r/665108 TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.32; 2021-02-23); removed MW-1.36-notes (1.36.0-wmf.25; 2021-01-05). TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a comment. Change 665107 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Update lemmas from wbeditentity response https://gerrit.wikimedia.org/r/665107 TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lydia_Pintscher, i_amy, Jakob_WMDE, So9q, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a comment. Change 665108 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Synchronize state with LexemeHeader more consistently https://gerrit.wikimedia.org/r/665108 TASK

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a comment. Change 665107 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Update lemmas from wbeditentity response https://gerrit.wikimedia.org/r/665107 TASK DETAIL

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lydia_Pintscher moved this task from Stalled/Waiting to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lydia_Pintscher added a comment. Moving this out of stalled because the necessary work in T271105

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lydia_Pintscher added a comment. You're right. After a reload of the page the whitespace is no longer there. So that's good. I'm inclined to keep this ticket open until we have solved T271105 and used its result. TASK DETAIL

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lucas_Werkmeister_WMDE added a comment. In T250550#6731719 , @Lydia_Pintscher wrote: > @i_amy and I tested this. It all seems to work fine except one thing: the whitespace at the end of a Lemma is not stripped when saving. This should

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lydia_Pintscher added subscribers: i_amy, Lydia_Pintscher. Lydia_Pintscher added a comment. @i_amy and I tested this. It all seems to work fine except one thing: the whitespace at the end of a Lemma is not stripped when saving. This should not happen. Based on Jakob's earlier comment I

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Jakob_WMDE, So9q, Lucas_Werkmeister_WMDE, Mahir256,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05). TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Jakob_WMDE, So9q,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a comment. Change 650475 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Update representations and glosses after save https://gerrit.wikimedia.org/r/650475 TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a comment. Change 650161 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Don’t trim strings in JS https://gerrit.wikimedia.org/r/650161 TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Jakob_WMDE added a comment. With https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/650475 the UI will correctly show trimmed whitespace for representations and glosses after saving, but not for lemmas. This isn't currently possible since wbeditentity doesn't contain

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a comment. Change 650475 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Update representations and glosses after save https://gerrit.wikimedia.org/r/650475 TASK DETAIL

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: So9q, Lucas_Werkmeister_WMDE, Mahir256, Nikki, Alter-paule,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

gerritbot added a comment. Change 650161 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Don’t trim strings in JS https://gerrit.wikimedia.org/r/650161 TASK DETAIL

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T250550 WORKBOARD

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lucas_Werkmeister_WMDE added a comment. In T250550#6674689 , @Nikki wrote: > Since the whitespace gets stripped when saving anyway, would removing the `trim()`s from

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lydia_Pintscher moved this task from Prioritized Tech (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. Lydia_Pintscher edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

noarave set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: So9q, Lucas_Werkmeister_WMDE, Mahir256, Nikki, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: So9q, Lucas_Werkmeister_WMDE, Mahir256, Nikki, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: So9q, Lucas_Werkmeister_WMDE, Mahir256, Nikki, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lydia_Pintscher added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: So9q, Lucas_Werkmeister_WMDE, Mahir256, Nikki, Akuckartz, Nandana, Lahi,

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Nikki added a comment. Since the whitespace gets stripped when saving anyway, would removing the `trim()`s from https://gerrit.wikimedia.org/g/mediawiki/extensions/WikibaseLexeme/+/0e48721161973149c18fa7539b22ed1f6b13cb7f/resources/templates/glossWidget.vue.html#38

[Wikidata-bugs] [Maniphest] T250550: Whitespace is stripped while typing when editing lexemes

Lucas_Werkmeister_WMDE added a comment. Just noticed the same thing while editing local test data to verify T267023 (Firefox 83). TASK DETAIL https://phabricator.wikimedia.org/T250550 EMAIL PREFERENCES