[Wikidata-bugs] [Maniphest] T255706: [SW] [WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock

Michael added a subscriber: hoo. Michael added a comment. Please take everything I write here with a grain of salt, I'm really not firm with databases. This is mainly me thinking aloud. Reading the section in the wiki about transaction scope was helpful for me to understand the

[Wikidata-bugs] [Maniphest] T255706: [SW] [WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock

Lucas_Werkmeister_WMDE added a comment. In T255706#9200496 , @aaron wrote: > I noticed that addUsages() uses `$this->db->replication()->wait();` which uses `LBFactory::waitForReplication()`. Doesn't that mean it's waiting for replicas

[Wikidata-bugs] [Maniphest] T255706: [SW] [WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock

aaron added a comment. I noticed that addUsages() uses $this->db->replication()->wait(); which uses LBFactory::waitForReplication(). Doesn't that mean it's waiting for replicas without committing each batch? It seems like it would just hold more and more locks while waiting for unrelated

[Wikidata-bugs] [Maniphest] T255706: [SW] [WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock

ItamarWMDE renamed this task from "[WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock" to "[SW] [WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock". TASK DETAIL https://phabricator.wikimedia.org/T255706 EMAIL PREFERENCES