[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E added a project: Codex. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: egardner, Catrope, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E added a comment. In T266688#7267420 , @AnneT wrote: > Another practical question: when does a value become a design token? This is the process I've been following: > > 1. Is it a simple keyword, like `display: flex`? If so,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: egardner, Catrope, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E closed this task as "Resolved". Volker_E claimed this task. Volker_E added a comment. Conclusion from the Vue.js taskforce convening: **Proposal on “2 levels vs 3 levels of abstraction (do we need the final level, component tokens)?” with vote results: WMDE approach 2 - WMF

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E added a comment. In T266688#7271853 , @Sarai-WMDE wrote: >> There's a lot of gray area in here, though, especially step 2. I looked through some WVUI components I've built and found some examples of values for which I did not

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Sarai-WMDE added a comment. Sorry about the late response! Here are my thoughts: > [...] but perhaps it would be more accurate to say that we will try to expand WikimediaUI base with more tokens that come from design decisions and can be used by components, but that we will keep

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

AnneT added a comment. Thank you, @Sarai-WMDE, for your thorough response! It's really helpful to learn from your experience with design tokens in WiKit so far. I have some remaining questions/thoughts about one topic, but everything else seems clear to me. > This all sounds about

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: egardner, Catrope, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Sarai-WMDE added a comment. Thank you so much for collecting all those valid thoughts here, @AnneT Adding my two cents to each one of your points, based on our experience with WiKit, and trying to keep in mind the new context: **Designer-developer hand off** Although I'd say this

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: egardner, Catrope, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: egardner, Catrope, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E added a parent task: T288383: Decide on design tokens architecture for Wikimedia Design System and its shared component library. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

AnneT added a comment. Another practical question: when does a variable become a design token? This is the process I've been following: 1. Is it a simple keyword, like `display: flex`? If so, probably don't use a token, unless it's something that gets repeated a lot like the value of

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

AnneT added subscribers: Tonina_Zhelyazkova_WMDE, Catrope, egardner. AnneT added a comment. Some thoughts post-Designer summit: Designer-developer handoff -- This could use stronger definition. Is the designer creating tokens for some values in Figma? Will

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E closed subtask T277616: Clarify technical choice with product team needs for design tokens/variables as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: Jakob_WMDE,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E added a comment. A counter-point to my conviction, from Adobe Spectrum : > Use component-specific tokens for their respective component > When building Spectrum verified components, use component-specific tokens. This ensures

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

AnneT added a comment. Quick comment that's probably obvious, but from a developer standpoint, one thing I would prioritize is ease of use/visibility during development. Two concerns: - In MediaWiki extensions, we use a pretty manual process to include and update Wikimedia UI base,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Sarai-WMDE added a comment. Considering the above recommendation: > Therefore I'd strongly recommend to go a CSS way of implementation. From general to specific: Use aliased base variables when applicable and only define component-level tokens when specifically needed. - What

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

Volker_E added a parent task: T287538: Identify Design System hurdles & blockers and resolve open questions. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: Jakob_WMDE, Michael,

[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction

AnneT renamed this task from "Evaluate (and implement) variables aka tokens abstraction" to "Evaluate variables aka tokens abstraction". TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: