[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

cscott added a comment. There's an upstream PR for PHP: https://github.com/php/php-src/pull/7782 TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, cscott Cc: Addshore, Ros

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Addshore, Rosalie_WMDE, Jakob_WMDE, cscott, Lucas_We

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

gerritbot added a comment. Change 654891 **abandoned** by Rosalie Perside (WMDE): [mediawiki/core@master] Revert \"Update formatNum implementation to match tr35 and latest CLDR\" and revert \"Use Unicode minus in output of {{formatenum}}\" Reason: https://gerrit.wikimedia

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Addshore closed this task as "Resolved". Addshore added a comment. Tested using examples in the description on beta This will be deployed this week to production (probably) TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09). TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Rosalie_WMDE, Jakob_WMDE, c

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

gerritbot added a comment. Change 656236 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Check whether MediaWiki can precisely format a number https://gerrit.wikimedia.org/r/656236 TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://ph

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Rosalie_WMDE, Jakob_WMDE, cscott, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Akla

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lydia_Pintscher added a comment. Thanks for looking into the upstream fix, Scott! As discussed with Lucas, let's get this merged now. It's better than showing wrong data. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settin

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

cscott added a comment. I'll look at the code, the idea seems reasonable. We could also file a bug upstream to see if PHP will add a bignum or string interface. Could also check libicu to see what types they are supporting (maybe the fault is just in the PHP wrapper). Worth noting tha

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lucas_Werkmeister_WMDE added a comment. I uploaded a proposed solution (see the above change): check if the formatted number can be parsed to the exact same value, otherwise fall back to the unformatted number. The result is that smaller numbers (or numbers with fewer decimal points) are sti

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

gerritbot added a comment. Change 656236 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Check whether MediaWiki can precisely format a number https://gerrit.wikimedia.org/r/656236 TASK DETAIL ht

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE Cc: Rosalie_WMDE, Jakob_WMDE, cscott, Lucas_Werkmeister_WMDE, Lydia_Pint

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Rosalie_WMDE added a comment. @cscott pinging you because you authored this commit https://gerrit.wikimedia.org/r/c/mediawiki/core/+/384006 which we believe introduced the bug. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

gerritbot added a comment. Change 654891 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/core@master] Revert "Update formatNum implementation to match tr35 and latest CLDR" https://gerrit.wikimedia.org/r/654891 TASK DETAIL http

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

gerritbot added a comment. Change 649638 **abandoned** by Rosalie Perside (WMDE): [mediawiki/core@master] Revert "Update formatNum implementation to match tr35 and latest CLDR" Reason: A new patch will be uploaded https://gerrit.wikimedia.org/r/649638 TASK DETAIL https://

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, gerritbot Cc: Jakob_WMDE, cscott, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, Moha

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

gerritbot added a comment. Change 649638 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/core@master] Revert "Update formatNum implementation to match tr35 and latest CLDR" https://gerrit.wikimedia.org/r/649638 TASK DETAIL http

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lucas_Werkmeister_WMDE added a comment. In T268456#6668873 , @Lucas_Werkmeister_WMDE wrote: > It looks like this is a limitation of the PHP `NumberFormatter` class Request #76093 seems to be th

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lucas_Werkmeister_WMDE added a comment. It looks like this is a limitation of the PHP `NumberFormatter` class, which MediaWiki uses since that commit: >>> $nf = new NumberFormatter( 'en', NumberFormatter::DECIMAL ); >>> $nf->format( '99' ) # fits in signed 64-bit int

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lucas_Werkmeister_WMDE added a comment. `git bisect` puts the blame on https://gerrit.wikimedia.org/r/384006, though it looks like the grouping of large numbers was already broken prior to that (and maybe that was one thing the commit meant to fix): F33935265: Screenshot_2020-12-04 Douglas

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lydia_Pintscher added a comment. Do we have tickets for reverting those changes? Or commits that introduced the issue? Or do we need to adapt our code to the changes that have been made? It's unclear to me what we need to do to get this resolved. TASK DETAIL https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Rosalie_WMDE added a comment. Recent changes made to `formatNumInternal( )` and `formatNum( )` in the mediawiki Language class introduced the bug. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Rosalie_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE Cc: Jakob_WMDE, cscott, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, Mohammed_Sadat_WMDE, Akuckar

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Jakob_WMDE moved this task from Prioritized Product (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. Jakob_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Jakob_WMDE added a comment. From task inspection: This seems to be reproducible locally by creating a Property with data type: quantity and then entering a number similar to the one from the example in the task description. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFE

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lucas_Werkmeister_WMDE added a subscriber: cscott. Lucas_Werkmeister_WMDE added a comment. The Wikibase number formatting code seems to use MediaWiki’s `Language` class (through `MediaWikiNumberLocalizer`), which was recently modified with several changes by @cscott. Bisecting MediaWiki core

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

WMDE-leszek set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, Mohammed_Sadat_WMDE, Akucka

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lucas_Werkmeister_WMDE added a comment. > Q67174314#P1181 I purged this page and now it also has a lot of 0s, so this seems to be a recent regression? TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phab

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

WMDE-leszek updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Lydia_Pintscher, Aklapper, Mohammed_Sadat_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilo

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lydia_Pintscher triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T268456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Aklapper, Mohammed_Sadat_WMDE, Akuckartz, Nandana, Lahi,

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different for large numbers

Lydia_Pintscher renamed this task from "Value stored and value displayed are different" to "Value stored and value displayed are different for large numbers". Lydia_Pintscher added a project: Wikidata-Campsite. Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikim

[Wikidata-bugs] [Maniphest] T268456: Value stored and value displayed are different

Mohammed_Sadat_WMDE created this task. Mohammed_Sadat_WMDE added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION As an editor I want to enter a numeric value and see that the same number is displayed. **Problem:** For some large numbers, the num