[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Charlie_WMDE added a comment. Sorry! 😬 TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Ladsgroup, Charlie_WMDE, Lydia_Pintscher, Aklapper, Michael, Akuckartz, Nandana, Lahi, G

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Michael added a comment. Now it is :) TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE, Michael Cc: Ladsgroup, Charlie_WMDE, Lydia_Pintscher, Aklapper, Michael, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Michael added a comment. Wait, we didn't actually merge the pull request yet 😆 TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE, Michael Cc: Ladsgroup, Charlie_WMDE, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Charlie_WMDE closed this task as "Resolved". Charlie_WMDE moved this task from Peer Review to Done on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Charlie_WMDE claimed this task. Charlie_WMDE added a comment. amazing! thank you! moving this to done! \o/ TASK DETAIL

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Ladsgroup added a comment. I removed that extra margin from my PR then. TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Charlie_WMDE, Lydia_Pintscher, Aklapper, Michael

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Michael added a comment. In T269470#6747876 , @Charlie_WMDE wrote: > i found another thing. the dropdown seems to be slightly misaligned in height with it's surrounding neighbors even though i can't pinpoint it using the dev tools. mayb

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Ladsgroup added a comment. This would fix three issues: https://github.com/wmde/query-builder/pull/153 - Changing the breakpoint from 36em to 38em so the trash icon doesn't get squeezed - Remove the part that removes the extra margin in smallest layout - Adding a really small margin t

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Charlie_WMDE added a comment. i found another thing. the dropdown seems to be slightly misaligned in height with it's surrounding neighbors even though i can't pinpoint it using the dev tools. maybe you could take a look to see what's going on? F34000854: image.png

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Charlie_WMDE added a comment. Hello! o/ love the progress it looks so cool! <3 Here are a few things i noticed: - only for layout 3 - i am failing to inspect the margin between the stacked components. visually it seems to me though, like the first dropdown component still has a

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Michael moved this task from To Do to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Michael added a comment. Now https://github.com/wmde/query-builder/pull/143 and https://github.com/wmde/query-builder/pull/144 are up for review and should fix most of t

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Ladsgroup added a comment. I got some of the issues fixed in https://github.com/wmde/query-builder/pull/143 but e.g. the third case, I don't what's pushing the input to stop shrinking. TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Michael removed Michael as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Charlie_WMDE, Lydia_Pintscher, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Charlie_WMDE added subscribers: Lydia_Pintscher, Charlie_WMDE. Charlie_WMDE added a comment. @Michael The main thing I noticed and that we also already talked about is - how the line break moves down one component at first, before moving a second one - in the stacked view (starting

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Michael moved this task from To Do to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Michael claimed this task. Michael added a comment. Restricted Application added a project: User-Michael. PR for the grey decorator: #134

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Michael moved this task from Backlog to Wikidata Query Builder - sprint 6 on the Wikidata Query Builder board. Michael edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 6); removed Wikidata Query Builder. TASK DETAIL https://phabricator.wikimedia.org/T269470 WORKB

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Charlie_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplor

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jense

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

Michael created this task. Michael added projects: Wikidata Query Builder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T269470 WORKBOARD https://phabricator.wikimedia.org/project/board/4990/ EMAIL PREFERENCES