[Wikidata-bugs] [Maniphest] T272042: Validate combination of `variant` and `type` on `Button`

2021-05-31 Thread Sarai-WMDE
Sarai-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T272042 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Sarai-WMDE, Aklapper, ItamarWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T272042: Validate combination of `variant` and `type` on `Button`

2021-05-31 Thread Sarai-WMDE
Sarai-WMDE added a comment. I'd say this task can be closed, since the validation map is in place (see line 84 in Button.vue ) and the warning is emitted (heads-up: this

[Wikidata-bugs] [Maniphest] T272042: Validate combination of `variant` and `type` on `Button`

2021-05-25 Thread Sarai-WMDE
Sarai-WMDE added a comment. Current implementation seems to already include a mechanism to test accepted combinations. We should validate if said approach is currently working and, if so, we could consid

[Wikidata-bugs] [Maniphest] T272042: Validate combination of `variant` and `type` on `Button`

2021-01-18 Thread ItamarWMDE
ItamarWMDE added a comment. Prio Notes: - This currently doesn't affect a hike or developer workflow - This issue affects implementers of the system but not the consumers of the interfaces created with the system. TASK DETAIL https://phabricator.wikimedia.org/T272042 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T272042: Validate combination of `variant` and `type` on `Button`

2021-01-14 Thread ItamarWMDE
ItamarWMDE created this task. ItamarWMDE added a project: Wikidata Design System. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Currently, it is possible for a `Button` component implementer to provide a combination of `v