[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Lucas_Werkmeister_WMDE added a comment. If I understand the error correctly, it was a race condition that happened if `chd_seen` was increased between these two queries: $row = $dbr->selectRow( $this->changesTable, 'max( change_id ) as maxid', [],

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

WMDE-leszek added a comment. It is likely too late so it is likely purely speculative comment: I wonder if there could be some sensible automated tests provided that could have caught this kind of regression? Maybe some kind of property-based test that would be punching in some

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Ladsgroup merged a task: T274169: Error 1690: BIGINT UNSIGNED value is out of range in (1350732636 - `wikidatawiki`.`wb_changes_dispatch`.`chd_seen`) (10.64.48.172) Function: Wikibase\Repo\Store\Sql\SqlChangeDispatchCoordinator::getCandidateClients. Ladsgroup added a subscriber: Urbanecm. TASK

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Ladsgroup added a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup,

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Ladsgroup added a comment. I agree. I think it's good enough. It's just it's not deployed yet and we need to wait for wmf.29 to get deployed. TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Lucas_Werkmeister_WMDE added a comment. I moved this to Verification but then remembered that I initially only proposed the cast as a quick fix :D @Ladsgroup do you think this needs a different, proper fix? Or is the cast actually the correct solution? (I’m leaning towards the latter but

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.29; 2021-02-02); removed MW-1.36-notes (1.36.0-wmf.30; 2021-02-09). TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup,

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

gerritbot added a comment. Change 662666 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.29] Cast chd_seen as signed integer https://gerrit.wikimedia.org/r/662666 TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

gerritbot added a comment. Change 662667 **abandoned** by Ladsgroup: [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.27] Cast chd_seen as signed integer Reason: Can't work with 27 easily. Let's just wait for wmf.29 to reach production https://gerrit.wikimedia.org/r/662667 TASK

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09). TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, ReleaseTaggerBot Cc: WMDE-leszek, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

gerritbot added a comment. Change 662667 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.27] Cast chd_seen as signed integer https://gerrit.wikimedia.org/r/662667 TASK DETAIL https://phabricator.wikimedia.org/T274091

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, gerritbot Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup,

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

gerritbot added a comment. Change 662666 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.29] Cast chd_seen as signed integer https://gerrit.wikimedia.org/r/662666 TASK DETAIL https://phabricator.wikimedia.org/T274091

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Ladsgroup added a comment. Yeah. "Fun" TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, Marostegui,

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Lucas_Werkmeister_WMDE added a comment. Probably, but how much? wmf.29 and also wmf.27 I guess? TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Maintenance_bot Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper,

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Ladsgroup added a comment. Shall we backport? TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, Marostegui,

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

gerritbot added a comment. Change 662635 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Cast chd_seen as signed integer https://gerrit.wikimedia.org/r/662635 TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T274091

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, Marostegui,

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

gerritbot added a comment. Change 662635 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Cast chd_seen as signed integer https://gerrit.wikimedia.org/r/662635 TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Marostegui added a comment. In T274091#6809810 , @Lucas_Werkmeister_WMDE wrote: > As a quick fix, we could probably change the query to use `CAST(chd_seen AS SIGNED)`; apparently that casts to a signed //64-bit// integer, so we

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Lucas_Werkmeister_WMDE added a comment. As a quick fix, we could probably change the query to use `CAST(chd_seen AS SIGNED)`; apparently that casts to a signed //64-bit// integer, so we (hopefully) wouldn’t even run into overflow problems once the value grows beyond a 31-bit integer (which

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Ladsgroup added a comment. This is interesting, I think MySQL is being a bit picky. Here's some similar error reports: https://stackoverflow.com/questions/5605085/bigint-unsigned-value-is-out-of-range and https://dba.stackexchange.com/questions/212838/bigint-unsigned-value-is-out-of-range

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Ladsgroup removed LucasWerkmeister as the assignee of this task. Ladsgroup added a subscriber: LucasWerkmeister. TASK DETAIL https://phabricator.wikimedia.org/T274091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: LucasWerkmeister,

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

Marostegui created this task. Marostegui added projects: Wikidata, Technical-Debt, wdwb-tech-focus (backlog), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DESCRIPTION Probably related to the schema change requested at T273874: Make wb_changes_dispatch.chd_seen unsigned in