[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-28 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04). TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: ArthurTaylor, Aklapper,

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T281706 WORKBOARD

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-28 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: ArthurTaylor, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-28 Thread gerritbot
gerritbot added a comment. Change #1036287 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use ObjectCacheFactory in ViewFactory service wiring https://gerrit.wikimedia.org/r/1036287 TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-28 Thread ArthurTaylor
ArthurTaylor added a comment. I think it's fine to use the private service in the contexts of tests. If the service gets changed, at least we know the tests should pick it up. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T281706 WORKBOARD

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed [DEPRECATED] wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a parent task: T361949: [SW] [REPO][CLIENT] Use ObjectCacheFactory in Wikibase. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper,

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-27 Thread gerritbot
gerritbot added a comment. Change #1036287 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Use ObjectCacheFactory in ViewFactory service wiring https://gerrit.wikimedia.org/r/1036287 TASK

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-27 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE, Isabelladantes1983,

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-05-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2024-04-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. > A solution for this almost certainly requires T243233: MediaWiki should provide a LocalClusterObjectCache service . That task was declined, but in the meantime, the local cluster instance was added to

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2021-09-21 Thread Addshore
Addshore added a project: wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2021-05-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2021-05-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T281706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T281706: Make ViewFactoryTest a proper unit test

2021-05-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Service Migration. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The `WikibaseRepo.ViewFactory` service wiring uses the `ObjectCache::getLocalClusterInstance()` function,