[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-14 Thread karapayneWMDE
karapayneWMDE added a project: Wikidata Dev Team (Sprint-∞). TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, karapayneWMDE Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Dan

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-11 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Danny_Ben

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-11 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01). TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeis

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-11 Thread gerritbot
gerritbot added a comment. Change 947858 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Require language in options in WikibaseValueFormatterBuilders https://gerrit.wikimedia.org/r/947858 TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-10 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-10 Thread gerritbot
gerritbot added a comment. Change 947858 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Require language in options in WikibaseValueFormatterBuilders https://gerrit.wikimedia.org/r/947858 TASK

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-10 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. In T281726#9062724 , @Lucas_Werkmeister_WMDE wrote: > Alright, I think we can check back on logstash in a few days (mediawiki-warnings

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-02 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15). TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeis

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-02 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Alright, I think we can check back on logstash in a few days (mediawiki-warnings , `channel:Wikibase AND FormatterOptions`). TASK DETAIL https://phabricator.wi

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-02 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-08-02T13:35:29Z] Finished scap: Backport for [[gerrit:944848|Inject LanguageNameLookupFactory into WikibaseValueFormatterBuilders (T281726 )]] (duration: 08m 39s) TASK DETAI

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-02 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Danny_Ben

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-02 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-08-02T13:28:26Z] lucaswerkmeister-wmde: Backport for [[gerrit:944848|Inject LanguageNameLookupFactory into WikibaseValueFormatterBuilders (T281726 )]] synced to the testserve

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-02 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-08-02T13:26:50Z] Started scap: Backport for [[gerrit:944848|Inject LanguageNameLookupFactory into WikibaseValueFormatterBuilders (T281726 )]] TASK DETAIL https://phabricat

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-02 Thread gerritbot
gerritbot added a comment. Change 944848 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.41.0-wmf.20] Inject LanguageNameLookupFactory into WikibaseValueFormatterBuilders https://gerrit.wikimedia.org/r/944848 TASK DETAIL https://phabricator.wikimedia.org/T281726 E

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-02 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-02 Thread gerritbot
gerritbot added a comment. Change 944848 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@wmf/1.41.0-wmf.20] Inject LanguageNameLookupFactory into WikibaseValueFormatterBuilders https://gerrit.wikimedia.

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-01 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Danny_Ben

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-01 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15). TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Michael, Aklapper, Lucas_We

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Task remains open; next week (or perhaps this week, if we backport), we can check if there are any “FormatterOptions without OPT_LANG or OPT_LANGUAGE_FALLBACK_CHAIN” Wikibase warnings in Logstash. If there aren’t, we can clean up the code a bit further

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-08-01 Thread gerritbot

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-07-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Th

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-07-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I decided against the `wfDeprecated()` – I’m fairly sure all the paths that reach this code will have the `$options` populated with a default language already (because some other code called there, notably `FormatterLabelDescriptionLookupFactory::getLa

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-07-31 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T281726 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2023-07-31 Thread gerritbot
gerritbot added a comment. Change 943573 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Inject LanguageNameLookupFactory into WikibaseValueFormatterBuilders https://gerrit.wikimedia.org/r/94357

[Wikidata-bugs] [Maniphest] T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders

2021-05-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikibase Service Migration, wdwb-tech, Wikidata. TASK DESCRIPTION Currently, we inject the `LanguageNameLookup` service into the `WikibaseValueFormatterBuilders` class (`WikibaseRepo.DefaultValueFormatterBuilders