[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Lydia_Pintscher, Manuel, amy_rc, Lectrician1,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

gerritbot added a comment. Change 700236 **abandoned** by Lucas Werkmeister (WMDE): [data-values/value-view@master] $.ui.suggester: Fix tracking of “is searching” flag Reason: Per parent change. https://gerrit.wikimedia.org/r/700236 TASK DETAIL

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

gerritbot added a comment. Change 700235 **abandoned** by Lucas Werkmeister (WMDE): [data-values/value-view@master] $.ui.suggester: Show menu on focus, not click Reason: The attached task was closed, so I can only guess that the discussion in T284219#7161318 ended with a

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

amy_rc closed this task as "Resolved". amy_rc moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. amy_rc added a comment. Works on test platform. ✨ TASK DETAIL https://phabricator.wikimedia.org/T284219 WORKBOARD

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21). TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Lydia_Pintscher, Manuel,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

gerritbot added a comment. Change 700478 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD https://gerrit.wikimedia.org/r/700478 TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

gerritbot added a comment. Change 700478 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD https://gerrit.wikimedia.org/r/700478 TASK DETAIL

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

gerritbot added a comment. Change 700234 **merged** by jenkins-bot: [data-values/value-view@master] $.ui.suggester: Don’t open menu if element lost focus https://gerrit.wikimedia.org/r/700234 TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lucas_Werkmeister_WMDE added a comment. Question discussed with Manuel, opened T285102 . This is good to review, I

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

gerritbot added a comment. Change 700236 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [data-values/value-view@master] $.ui.suggester: Fix tracking of “is searching” flag https://gerrit.wikimedia.org/r/700236 TASK DETAIL

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

gerritbot added a comment. Change 700235 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [data-values/value-view@master] $.ui.suggester: Show menu on focus, not click https://gerrit.wikimedia.org/r/700235 TASK DETAIL

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lydia_Pintscher, Manuel, amy_rc, Lectrician1, Aklapper, Moebeus,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

gerritbot added a comment. Change 700234 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [data-values/value-view@master] $.ui.suggester: Don’t open menu if element lost focus https://gerrit.wikimedia.org/r/700234 TASK DETAIL

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lucas_Werkmeister_WMDE added a comment. Manuel/Amy/you, I think :) TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, Manuel, amy_rc, Lectrician1,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lydia_Pintscher added a comment. Who do you need to discuss it with? Manuel/Amy/me or Moebeus or one of the other devs? TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lucas_Werkmeister_WMDE added a comment. Alright, I have three commits that fix several issues in the suggester. However, I’m worried that they might go “too far”, and show the suggester more often that we want. Can I discuss this with one of you in a call? (I think it will be easier to show

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lucas_Werkmeister_WMDE added a comment. I think for now I’ll try to put the fix in the generic suggester component, since it already has some logic to close itself when losing focus. TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lucas_Werkmeister_WMDE added a comment. I wonder if the fix for this belongs in `jquery.ui.suggester` or `jquery.wikibase.entityselector`? The suggester is used by three components, as far as I can tell: - site selector - page suggester - entity selector I assume the site

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T284219 WORKBOARD

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Addshore moved this task from Prioritized Product (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lydia_Pintscher set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Manuel, amy_rc, Lectrician1, Aklapper, Moebeus,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Manuel, amy_rc, Lectrician1, Aklapper, Moebeus, Invadibot,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

amy_rc updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: amy_rc Cc: Lydia_Pintscher, Manuel, amy_rc, Lectrician1, Aklapper, Moebeus, Invadibot, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

amy_rc updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: amy_rc Cc: Lydia_Pintscher, Manuel, amy_rc, Lectrician1, Aklapper, Moebeus, Invadibot, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

amy_rc updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: amy_rc Cc: Lydia_Pintscher, Manuel, amy_rc, Lectrician1, Aklapper, Moebeus, Invadibot, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

amy_rc updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: amy_rc Cc: Lydia_Pintscher, Manuel, amy_rc, Lectrician1, Aklapper, Moebeus, Invadibot, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Manuel added a comment. I can also reproduce this when I am quick: If I move out of input box A to input box B, while the lookup in input box A is still in progress, I might end up with multiple input suggestions at once. TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

amy_rc added a comment. @Moebeus Thank you for pointing this issue. @Lydia_Pintscher This is most noticeable when we use tabs quickly. I was able to capture two such occurrences. F34486770: 1.webm F34486771: 2.webm

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

amy_rc added a comment. In T284219#7133964 , @Lydia_Pintscher wrote: > @Manuel @amy_rc: Could you try reproducing this? I tested the scenario but haven't been able to replicate it yet. TASK DETAIL

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Lydia_Pintscher added subscribers: amy_rc, Manuel, Lydia_Pintscher. Lydia_Pintscher added a project: Wikidata-Campsite. Lydia_Pintscher added a comment. @Manuel @amy_rc: Could you try reproducing this? TASK DETAIL https://phabricator.wikimedia.org/T284219 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T284219: Property- and item suggesters pop back up after a selection is made

Moebeus created this task. Moebeus added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION I apologize if I already reported this, it's a long running issue. When the back end is slow (I don't know how else to explain it), this issue appears. When the