[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

Michael created this task. Michael added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, DataValues, wdwb-tech, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION While we should never have invalid data in our da

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

Lucas_Werkmeister_WMDE added a comment. Hm, and what if a malformed datavalue appears in a qualifier or reference? Probably the same thing: make the `pqv:`/`prv:` values error bnodes, leave out `pq:`/`pr:`. TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES http

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T285131 WORKBOARD https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

Lucas_Werkmeister_WMDE added a comment. On second thought, I’m not sure there’s anything to do here…? I thought earlier that T144248 was about a crash, but it’s just a logged warning – we already “provide something syntactically valid to the user”:

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Invadibot, maantietaja, A

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

Michael added a comment. In T285131#7162615 , @Lucas_Werkmeister_WMDE wrote: > On second thought, I’m not sure there’s anything to do here…? I thought earlier that T144248 was about a crash, b

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

Lucas_Werkmeister_WMDE added a comment. >> So maybe the only thing left to do is to make the warning more quiet so it doesn’t pollute production logstash? (I think “notice” log level would be appropriate: “normal, but significant, condition”, above “info” but below “warning”.) > > Either

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

gerritbot added a comment. Change 700373 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Inject logger into DispatchingValueSnakRdfBuilder https://gerrit.wikimedia.org/r/700373 TASK DETAIL ht

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Biggs657, Invadibot, L

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

gerritbot added a comment. Change 700374 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Inject logger into ValueSnakRdfBuilderFactory https://gerrit.wikimedia.org/r/700374 TASK DETAIL

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

gerritbot added a comment. Change 700375 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@master] Inject logger into ValueSnakRdfBuilderFactory https://gerrit.wikimedia.org/r/700375 TASK DETAIL

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

gerritbot added a comment. Change 700373 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Inject logger into DispatchingValueSnakRdfBuilder https://gerrit.wikimedia.org/r/700373 TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES https://pha

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

gerritbot added a comment. Change 700374 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Inject logger into ValueSnakRdfBuilderFactory https://gerrit.wikimedia.org/r/700374 TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES https://p

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

gerritbot added a comment. Change 700375 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Inject logger into ValueSnakRdfBuilderFactory https://gerrit.wikimedia.org/r/700375 TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES https:

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Invadibot

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21). TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Lucas_Werkmeister_WMDE, Akl

[Wikidata-bugs] [Maniphest] T285131: Provide valid rdf error response for invalid data in the database

Addshore closed this task as "Resolved". Addshore added a comment. The logging change looks good to me TASK DETAIL https://phabricator.wikimedia.org/T285131 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Addshore Cc: Addsh