[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-20 Thread karapayneWMDE
karapayneWMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T285838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE, karapayneWMDE Cc: guergana.tzatchkova, Silvan_WMDE, Aklapper, ItamarWMDE, karapayneWMDE, I

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-13 Thread ItamarWMDE
ItamarWMDE added a comment. So, after reviewing the docs (and the code we wrote so far) a bit more, it seems like the general recommendation is to focus more on "Feature" tests rather than on unit tests. As we didn't really create any library style classes that don't directly rely on the req

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-12 Thread ItamarWMDE
ItamarWMDE added a comment. In T285838#7205062 , @guergana.tzatchkova wrote: > @ItamarWMDE and I have decided to try the SQLite approach and close the Container Duo approach for now. See closed PR

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-12 Thread ItamarWMDE
ItamarWMDE added a comment. I actually think it's possible for us to write method tests without talking to the Database, I mean, this is actually one of the reasons to use an ORM like eloquent, since we can easily mock the injected model dependencies without touching the DB to begin with. I'

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-12 Thread guergana.tzatchkova
guergana.tzatchkova added a comment. @ItamarWMDE and I have decided to try the SQLite approach and close the Container Duo approach for now. See closed PR . TASK DETAIL https://phabricator.wikimedia.org/T285838 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-09 Thread Silvan_WMDE
Silvan_WMDE reassigned this task from Silvan_WMDE to ItamarWMDE. Silvan_WMDE added a comment. assigning this to @ItamarWMDE for check/confirmation TASK DETAIL https://phabricator.wikimedia.org/T285838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-09 Thread Silvan_WMDE
Silvan_WMDE added a comment. So far, we don't seem to have any separate "units" that can be tested without spinning up the web application and database. Thus we'll concentrate on Laravel's Feature Testing for testing database functions and routes. See T286053

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-06 Thread Silvan_WMDE
Silvan_WMDE claimed this task. Silvan_WMDE moved this task from To Do to Doing on the Mismatch Finder (Mismatch Finder - sprint 2) board. TASK DETAIL https://phabricator.wikimedia.org/T285838 WORKBOARD https://phabricator.wikimedia.org/project/board/5422/ EMAIL PREFERENCES https://phabric

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher moved this task from Backlog to Mismatch Finder - sprint 2 on the Mismatch Finder board. Lydia_Pintscher edited projects, added Mismatch Finder (Mismatch Finder - sprint 2); removed Mismatch Finder. TASK DETAIL https://phabricator.wikimedia.org/T285838 WORKBOARD https://phab

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T285838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, L

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-06-30 Thread ItamarWMDE
ItamarWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-06-30 Thread ItamarWMDE
ItamarWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-06-30 Thread ItamarWMDE
ItamarWMDE created this task. ItamarWMDE added projects: Mismatch Finder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION While scaffolding our app, we focused on covering the bare basics, and we deferred (unintentionally) setting up our testing infrastructure. H