[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-08-02 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02). TASK DETAIL https://phabricator.wikimedia.org/T287797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj, ReleaseTaggerBot Cc: Michaelcochez, Aklapper, Invadibot, maa

[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-08-02 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T287797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj, Maintenance_bot Cc: Michaelcochez, Aklapper, Invadibot, maantietaja, Akuckartz, Nand

[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-08-02 Thread gerritbot
gerritbot added a comment. Change 709209 **merged** by jenkins-bot: [mediawiki/extensions/PropertySuggester@master] Fix setting the request duration correctly for the PropertySuggester https://gerrit.wikimedia.org/r/709209 TASK DETAIL https://phabricator.wikimedia.org/T287797 EMA

[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-07-31 Thread Michaelcochez
Michaelcochez closed this task as "Resolved". Michaelcochez added a comment. The example I was looking at fits the case you describe. Server {"meta":{"domain":"wikidata.beta.wmflabs.org","stream":"wd_propertysuggester.server_side_property_request","id":"8c5be2b3-b817-4505-9980-a891

[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-07-31 Thread Martaannaj
Martaannaj added a comment. @Michaelcochez Should be fixed now, in the case where there are no properties already attributed to the entity the PropertySuggester would simply return a pre-set list, so the request duration would be 0 ms. This in turn would cause the line $this->requestDuratio

[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-07-31 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T287797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj, gerritbot Cc: Michaelcochez, Aklapper, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan9

[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-07-31 Thread gerritbot
gerritbot added a comment. Change 709209 had a related patch set uploaded (by Martaannaj; author: Martaannaj): [mediawiki/extensions/PropertySuggester@master] Fix setting the request duration correctly for the PropertySuggester https://gerrit.wikimedia.org/r/709209 TASK DETAIL ht

[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-07-31 Thread Martaannaj
Martaannaj added a comment. @Michaelcochez can you give me an example of an entity where this happens? Because looking at https://wikidata.beta.wmflabs.org/wiki/Q86 (served by the PropertySuggester) the request duration gets logged nicely. In the implementation, in the case where the call t

[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-07-31 Thread Martaannaj
Martaannaj added a comment. @Michaelcochez can you give me an example of an entity where this happens? Because looking at https://wikidata.beta.wmflabs.org/wiki/Q86 (served by the PropertySuggester) the request duration gets logged nicely. In the implementation, in the case where the call

[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester

2021-07-30 Thread Maintenance_bot
Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T287797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj, Maintenance_bot Cc: Michaelcochez, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi,