[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, Arian_Bozorg, Aklapper, Sara

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Arian_Bozorg closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Arian_Bozorg Cc: Lucas_Werkmeister_WMDE, Arian_Bozorg, Aklapper, Sarai-WMDE, Ada

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Arian_Bozorg added a comment. Sorry about that Sarai This looks good to me now :) Thanks so much! TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Arian_Bozorg

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a comment. Change 869822 **merged** by Lucas Werkmeister (WMDE): [wikidata/query-builder/deploy@production] Merging from a4f569f1211cd7bf51ced93bc84d56cc18adea89 https://gerrit.wikimedia.org/r/869822 TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREF

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a comment. Change 869822 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder): [wikidata/query-builder/deploy@production] Merging from a4f569f1211cd7bf51ced93bc84d56cc18adea89 https://gerrit.wikimedia.org/r/869822 TASK DETAIL https://phabri

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a comment. Change 869733 **merged** by jenkins-bot: [wikidata/query-builder@master] Change description text style to body https://gerrit.wikimedia.org/r/869733 TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Arian_Bozorg, Aklapper, Sarai-WMDE, Adamm7

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a comment. Change 869733 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikidata/query-builder@master] Change description text style to body https://gerrit.wikimedia.org/r/869733 TASK DETAIL https://phabricator.wi

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T288931 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES ht

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Lucas_Werkmeister_WMDE moved this task from Product Verification to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T288931 WORKBOARD https://phabricator

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Sarai-WMDE reopened this task as "Open". Sarai-WMDE added a comment. @LucasWerkmeister and @Arian_Bozorg ⚠ The font properties of the introductory paragraph weren't updated (the font size needs to be increased), so the second AC wasn't met. Reopening the task. TASK DETAIL https://phabric

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Sarai-WMDE Cc: LucasWerkmeister, Arian_Bozorg, Aklapper, Sarai-WMDE, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Sarai-WMDE added a subscriber: LucasWerkmeister. Sarai-WMDE added a comment. @LucasWerkmeister and @Arian_Bozorg ⚠ The font properties of the introductory paragraph weren't updated (the font size needs to be increased), so the second AC wasn't met. Should this task be reopend, or should I

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Sarai-WMDE Cc: Arian_Bozorg, Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, In

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Arian_Bozorg closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Arian_Bozorg Cc: Arian_Bozorg, Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMD

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Arian_Bozorg added a comment. Looks good to me, thank you so much \o/ TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Arian_Bozorg Cc: Arian_Bozorg, Aklapper, Sarai-WMDE

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a comment. Change 867164 **abandoned** by Lucas Werkmeister (WMDE): [wikidata/query-builder/deploy@production] Merging from dcaa2c8c46769858034968dd00eed9ed4fc9367b Reason: superseded by I4b193b9f6c https://gerrit.wikimedia.org/r/867164 TASK DETAIL https:

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a comment. Change 867164 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder): [wikidata/query-builder/deploy@production] Merging from dcaa2c8c46769858034968dd00eed9ed4fc9367b https://gerrit.wikimedia.org/r/867164 TASK DETAIL https://phabri

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a comment. Change 866603 **merged** by jenkins-bot: [wikidata/query-builder@master] Add heading for description / intro https://gerrit.wikimedia.org/r/866603 TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Lucas_Werkmeister_WMDE added a comment. Ok, thanks :) then the patch should be ready for review. TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: LucasWerkmeister, Akl

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Sarai-WMDE added a subscriber: LucasWerkmeister. Sarai-WMDE added a comment. In T288931#8456973 , @Lucas_Werkmeister_WMDE wrote: > I might be missing something, but I don’t see a variable like `$font.weight.style.heading-bold` in Wikit –

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Aklapper, Sarai-WMDE, Adamm71, Jersione, Hellket777, LisafBia6531,

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

gerritbot added a comment. Change 866603 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikidata/query-builder@master] Add heading for description / intro https://gerrit.wikimedia.org/r/866603 TASK DETAIL https://phabricator.wiki

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Lucas_Werkmeister_WMDE added a comment. I might be missing something, but I don’t see a variable like `$font.weight.style.heading-bold` in Wikit – is `$font-weight-style-h4` (= `$font-weight-bold-value` = `$wmf-font-weight-bold.value` = 700) okay? (That’s what’s used by the `heading-4` mixin

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T288931 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Sarai-WM

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1

Sarai-WMDE renamed this task from "Query Builder: Replace visible h1 by title" to "Query Builder: Replace visible h1". TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sara

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1 by title

Lydia_Pintscher added a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T288931: Query Builder: Replace visible h1 by title

Sarai-WMDE renamed this task from "Query Builder: Edit main title and description" to "Query Builder: Replace visible h1 by title". TASK DETAIL https://phabricator.wikimedia.org/T288931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: A