[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-22 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved". Lydia_Pintscher moved this task from Peer Review to Done on the Mismatch Finder (Mismatch Finder - sprint 14) board. Lydia_Pintscher added a comment. Makes sense. Thanks. TASK DETAIL https://phabricator.wikimedia.org/T300649 WORKBOARD

[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-22 Thread ItamarWMDE
ItamarWMDE added a comment. I think in the case of this particular csv, I would advise @Mike_Peel to use `urllib.urlencode()` over the constructed url in this line: https://github.com/mpeel/wikicode/blob/78a5957a504a4ea5c99eabefeba3594e0bf5095d/wikidata_enwiki_mismatch.py#L86 TASK DETAIL

[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-22 Thread ItamarWMDE
ItamarWMDE added a comment. Unfortunately, it might be a bit too much overhead, since these chars are not included in the URL specification. We currently use a prebuilt validator to check the validity of URLs, to enable this we will have to create some custom regex rules to enable this or

[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-21 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. \o/ And we are ready for launch tomorrow. I have now imported everything but the P1030 mismatches. I had to fix a few more things as Itamar mentioned due to URL encoding. Here are two examples where the

[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-01 Thread Mike_Peel
Mike_Peel added a comment. In T300649#7668843 , @Mike_Peel wrote: > Something definitely went wrong with the extraction of the P1030 constraints - I'll look into that and provide an updated

[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-01 Thread Mike_Peel
Mike_Peel added a comment. Something definitely went wrong with the extraction of the P1030 constraints - I'll look into that and provide an updated file, but for now you could just remove those lines (any containing 'P1030

[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-01 Thread ItamarWMDE
ItamarWMDE added a comment. The unexpected errors turned out to be the result of the server's job queue timing out, which is resolved in PR#304 . Other than that, the file seems to have issues validating URLs with a long hyphen

[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-01 Thread ItamarWMDE
ItamarWMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T300649 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, guergana.tzatchkova, ItamarWMDE, Lydia_Pintscher, Mike_Peel, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-01 Thread ItamarWMDE
ItamarWMDE moved this task from Backlog to Mismatch Finder - sprint 14 on the Mismatch Finder board. ItamarWMDE edited projects, added Mismatch Finder (Mismatch Finder - sprint 14); removed Mismatch Finder. TASK DETAIL https://phabricator.wikimedia.org/T300649 WORKBOARD

[Wikidata-bugs] [Maniphest] T300649: upload issues with a mismatch file

2022-02-01 Thread Maintenance_bot
Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T300649 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Aklapper, guergana.tzatchkova, ItamarWMDE, Lydia_Pintscher, Mike_Peel,