[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a comment. In T308443#7931359 , @Lucas_Werkmeister_WMDE wrote: > leaving it up to @tstarling and @Reedy whether

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

RhinosF1 added a comment. Possibly causing T309491: mwext-php72-phan-docker fails for Wikimedia Messages TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Daimona, Ladsgroup, Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.14; 2022-05-30). TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: Daimona, Ladsgroup, Reedy, ItamarWMDE, Michael,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

gerritbot added a comment. Change 793713 **merged** by jenkins-bot: [mediawiki/extensions/UniversalLanguageSelector@master] Suppress PhanParamSignatureRealMismatchParamType on classes affected by new RL namespace https://gerrit.wikimedia.org/r/793713 TASK DETAIL

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Daimona, Ladsgroup, Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, tstarling, kostajh,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

gerritbot added a comment. Change 793713 had a related patch set uploaded (by Tim Starling; author: Tim Starling): [mediawiki/extensions/UniversalLanguageSelector@master] Suppress PhanParamSignatureRealMismatchParamType on classes affected by new RL namespace

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

tstarling added a comment. I've uploaded updates for 35 extensions, to be merged shortly after the core patch is merged. I linked them to T308718 so that there wouldn't be too much bot noise here. TASK DETAIL

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

tstarling added a parent task: T308718: ResourceLoader namespace. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: tstarling Cc: Daimona, Ladsgroup, Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

tstarling added a comment. I think my preferred solution is to combine options 1, 2: update extensions to use the new class name, but if any affected extensions need to support old versions of core, use @phan-suppress. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

kostajh removed a project: Growth-Team. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Daimona, Ladsgroup, Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, tstarling, kostajh,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

kostajh removed a project: GrowthExperiments. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Daimona, Ladsgroup, Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, tstarling, kostajh,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Daimona added a comment. In T308443#7933248 , @tstarling wrote: > - Patch phan. Wastes upstream's time with ancient PHP version issues, and probably incurs a rebase cost when reapplying the core patch, due to phan deployment delay.

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Ladsgroup added a comment. FWIW the current blocker of php7.4 migration work seems to be T295578 > For configuration of changeprop, there is https://wikitech.wikimedia.org/wiki/Changeprop#To_deployment-prep but the steps described there don't

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

tstarling added a comment. Basically it looks like at least a day of my time wasted debugging issues specific to the dinosaur version of PHP we are running in production. Potential fixes: - Patch all affected extensions to use the new class name. The core patch would be reapplied and

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

tstarling added a comment. When phan is checking for a signature match, it first checks whether the names match: if (!$overridden_parameter_union_type->isEqualTo($parameter_union_type) && That always fails in the case of an alias. Then if the target PHP version is 7.4+, it checks

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

tstarling added a comment. In T308443#7931024 , @Lucas_Werkmeister_WMDE wrote: > The patch includes a “ResourceLoaderContext72Hack” hack class, which is apparently supposed to work around T166010#5962098

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Umherirrender added a project: phan. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, tstarling, kostajh, Aklapper,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, tstarling, kostajh,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Lucas_Werkmeister_WMDE added a comment. In T308443#7931359 , @Lucas_Werkmeister_WMDE wrote: > CI should be working again (I’ll verify in WikibaseLexeme in a moment) Phan is green again

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Lucas_Werkmeister_WMDE lowered the priority of this task from "Unbreak Now!" to "Needs Triage". Lucas_Werkmeister_WMDE added a subscriber: Reedy. Lucas_Werkmeister_WMDE added a comment. CI should be working again (I’ll verify in WikibaseLexeme in a moment); leaving it up to @tstarling and

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

gerritbot added a comment. Change 792137 **merged** by jenkins-bot: [mediawiki/core@master] Revert "ResourceLoader namespace" https://gerrit.wikimedia.org/r/792137 TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Michael, RhinosF1, Krinkle, tstarling, kostajh, Aklapper, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

gerritbot added a comment. Change 792137 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] Revert "ResourceLoader namespace" https://gerrit.wikimedia.org/r/792137 TASK DETAIL

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Lucas_Werkmeister_WMDE removed a project: Wikidata Analytics. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: RhinosF1, Krinkle, tstarling, kostajh, Aklapper,

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: RhinosF1, Krinkle, tstarling, kostajh, Aklapper, Lucas_Werkmeister_WMDE,