[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Mike_Peel added a comment. In T313467#9271763 , @ItamarWMDE wrote: > We can definitely release it a day or two later. This will give us a chance to review the release before it goes out. Thanks! TASK DETAIL

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg added a comment. Thanks @ItamarWMDE TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Arian_Bozorg Cc: Mike_Peel, HasanAkgun_WMDE, ItamarWMDE, Arian_Bozorg,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. We can definitely release it a day or two later. This will give us a chance to review the release before it goes out. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Mike_Peel added a comment. In T313467#9265250 , @Arian_Bozorg wrote: > Thanks for the feedback Mike! Looks like we will keep the `type` column in the last position and it will remain optional for now. > > This will be released on 1

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg added a comment. Thanks for the feedback Mike! Looks like we will keep the `type` column in the last position and it will remain optional for now. This will be released on 1 November, so should work for your first half of the month schedule :) TASK DETAIL

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg moved this task from Doing to Done on the Wikidata Dev Team (Quality Tools "Sprint") board. TASK DETAIL https://phabricator.wikimedia.org/T313467 WORKBOARD https://phabricator.wikimedia.org/project/board/6750/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Mike_Peel added a comment. If you're going to be supporting mismatches on labels, descriptions, aliases (which would be good!), then making type required might make sense - and making changes like that while the tool is still in early stages is good (or at least, better than later!). There

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Lydia_Pintscher added a comment. Ah. Yeah the uploader will have to specify it if they are not uploading mismatches for statements. If they are not doing that then their mismatches will indeed be wrong and will need to be fixed. We're fairly sure that most mismatches will be on statements

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Sarai-WMDE added a comment. I'm talking about that, yes. Unless I'm missing something, if the missing value of `type` is set by default to "statement" and displayed like so in the results table, then that will be misleading for users trying to correct mismatches that actually are on

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Lydia_Pintscher added a comment. We're just talking about the upload data. The system would assume type to be statement for the ones where it is not specified and also show statement to the user. Or are you talking about something else? TASK DETAIL

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Sarai-WMDE added a comment. I wanted to express the following concern here again, just in case someone agrees on the need to find a mitigation factor: If `type` is optional, and its default value is "statement", then when `type` is not provided users of the Mismatch finder will be

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Arian_Bozorg Cc: Mike_Peel, HasanAkgun_WMDE, ItamarWMDE, Arian_Bozorg, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg added a comment. Hi Mike, Yes, this will be a breaking change when it is released. We will be in touch with you when it is scheduled to go live so that you can update your workflows accordingly. And thank you so much for your feedback on the `type` column, with that in

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Mike_Peel added a comment. Is this the breaking change? I'm currently using 'item_id,statement_guid,property_id,wikidata_value,meta_wikidata_value,external_value,external_url'. I'm not sure what a guid is? Will 'type' be optional - in which case it is better at the end rather than the

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg moved this task from Product Verification to Backlog on the Wikidata Dev Team (Quality Tools "Sprint") board. Arian_Bozorg added a comment. Very sorry, but after speaking with @Lydia_Pintscher, would it be possible to change the format of the csv and make `type` the first

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Arian_Bozorg Cc: Mike_Peel, HasanAkgun_WMDE, ItamarWMDE, Arian_Bozorg, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Sarai-WMDE added a comment. Design verification done on Chrome 117, Safari 17 and Firefox 11. As previously mentioned, there's a display issue related to responsiveness that needs fixing (the linearization of the table should happen at a larger breakpoint). In some browsers, even horizontal

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Mike_Peel added a comment. In T313467#9241353 , @ItamarWMDE wrote: > It might have just taken a while for the job to complete. As far as I can see the import succeeded Ah, great, I see the same now. :) TASK DETAIL

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. In T313467#9240979 , @Mike_Peel wrote: > Re-run this evening, it seems to be stuck at 'Pending'. It might have just taken a while for the job to complete. As far as I can see the import succeeded TASK

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Mike_Peel added a comment. Re-run this evening, it seems to be stuck at 'Pending'. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Mike_Peel Cc: Mike_Peel,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. In T313467#9238315 , @ItamarWMDE wrote: > In T313467#9236812 , @Mike_Peel wrote: > >> Reran today, same error according to

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Lydia_Pintscher added a comment. I discussed it more with Arian and we agree that the type makes sense to go first in the CSV. Should I update the task description accordingly? And sorry. I initially did it as you implemented it without thinking too much about it -.- TASK DETAIL

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. In T313467#9236812 , @Mike_Peel wrote: > Reran today, same error according to https://mismatch-finder.toolforge.org/store/imports Oh, apologies again, thanks for trying, we will look into this asap!

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Mike_Peel added a comment. Reran today, same error according to https://mismatch-finder.toolforge.org/store/imports TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

guergana.tzatchkova updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: Mike_Peel, HasanAkgun_WMDE, ItamarWMDE, Arian_Bozorg, Sarai-WMDE, jmkeil,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Mike_Peel added a comment. In T313467#9215948 , @ItamarWMDE wrote: > @Mike_Peel @Lydia_Pintscher The system was reverted to the stable version, apologies for the mix-up. Could you attempt the upload again, please? I can't do the

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Sarai-WMDE added a comment. In T313467#9225784 , @Sarai-WMDE wrote: > We're right now using the tablet WiKit breakpoint (720px) to trigger the change in the table component layout (from its regular display to linerarized). This value

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Sarai-WMDE added a comment. Hey there. I'm checking the latest changes applied to the table in our staging environment . The column proportions look all good with the addition of "Type"  . Nevertheless, I

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. @Mike_Peel @Lydia_Pintscher The system was reverted to the stable version, apologies for the mix-up. Could you attempt the upload again, please? TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Lydia_Pintscher added a comment. Thanks! And yeah I now see that we already have it in the task description. @Arian_Bozorg Let's look into it. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. Seems like there was a deployment to production 5 days ago, probably by mistake while working on T345857 . I will revert it straight away. As for the column order @Lydia_Pintscher, we are following what is stated to

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Lydia_Pintscher added a subscriber: Mike_Peel. Lydia_Pintscher added a comment. This seems to be live already and broke @Mike_Peel's latest upload it seems :( https://mismatch-finder.toolforge.org/store/imports And it looks like we just added the type to the end of the upload CSV judging

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

guergana.tzatchkova added a comment. Column widths can be verified in staging, @Sarai-WMDE : https://mismatch-finder-staging.toolforge.org/ TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

guergana.tzatchkova added a comment. In T313467#9203876 , @ItamarWMDE wrote: > In T313467#9203869 , @guergana.tzatchkova wrote: > >> In T313467#9203022

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. In T313467#9203869 , @guergana.tzatchkova wrote: > In T313467#9203022 , @ItamarWMDE wrote: > >> This is not done, there's still the UI part to complete

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

guergana.tzatchkova added a comment. Restricted Application added a project: User-ItamarWMDE. In T313467#9203022 , @ItamarWMDE wrote: > This is not done, there's still the UI part to complete omg! this is true!!! TASK DETAIL

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. This is not done, there's still the UI part to complete TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, ItamarWMDE Cc: HasanAkgun_WMDE,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

guergana.tzatchkova added a comment. Should be restimated as an "8" TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: HasanAkgun_WMDE, ItamarWMDE, Arian_Bozorg,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

guergana.tzatchkova added a comment. Relevant PRs: Add 'type' column migration: https://github.com/wmde/wikidata-mismatch-finder/pull/678 TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

karapayneWMDE moved this task from Sprint-∞ to Quality Tools "Sprint" on the Wikidata Dev Team board. karapayneWMDE edited projects, added Wikidata Dev Team (Quality Tools "Sprint"); removed Wikidata Dev Team (Sprint-∞). TASK DETAIL https://phabricator.wikimedia.org/T313467 WORKBOARD

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a subscriber: HasanAkgun_WMDE. ItamarWMDE added a comment. Thank you! an option that could accompany this decision and @HasanAkgun_WMDE came up with is that in addition to making the column mandatory, we keep supporting the old format for an intermediary period (a few

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg added a comment. Yes, that makes sense. Then for simplicity, a `type` column on the CSV upload will be mandatory, and we will inform current Mismatch Finder users so that they can update their workflows accordingly. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

guergana.tzatchkova added a comment. Note for Task Breakdown: Update docs. User Guide and api-spec

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

guergana.tzatchkova claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: ItamarWMDE, Arian_Bozorg, Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. @Arian_Bozorg The issue is not about the existing mismatches in the database. It's about the difference in the request format and transparency in what we support. We are now adding a new column to the CSV that will have to be validated, and we should be

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg added a comment. Thanks for all the notes Itamar :) > It seems like the type column on the CSV upload will be mandatory from this change onwards, is that correct? Would it be possible to assign uploads that have no `type` automatically as a main snak / statement? This

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE moved this task from Unified prioritized backlog to Sprint-∞ on the Wikidata Dev Team board. ItamarWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T313467 WORKBOARD

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE added a comment. **Task Breakdown Notes** - This will require us to create a database migration, an update all of the seeders and factories used in tests - Also we will need to update the Mismatch Model, and the CSV Parser to support the new type column - Potentially we

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE set the point value for this task to "13". TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Arian_Bozorg, Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

ItamarWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Arian_Bozorg, Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T313467: Ability to report mismatches on qualifiers

Arian_Bozorg renamed this task from "[SW] Ability to report mismatches on qualifiers" to "Ability to report mismatches on qualifiers". TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Arian_Bozorg added a comment. Looking at these again much much later, I think option 1 would be the best way forward. Option 2 would be a little too busy and adds an extra layer of hierarchy. In answer to your questions: 1. we can discuss validation in a meeting 2. I think

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Sarai-WMDE attached a referenced file: F35794447: T313469.png. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Sarai-WMDE attached a referenced file: F35794451: T313469.png. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Lydia_Pintscher added a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Sarai-WMDE added a comment. Qualifier mismatches: Request for feedback on designs - This task, as well as {https://phabricator.wikimedia.org/T313469}, requires the redesign of the Mismatch Finder's results page and/or table. These

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Lydia_Pintscher changed the task status from "Stalled" to "Open". Lydia_Pintscher added a subscriber: Sarai-WMDE. Lydia_Pintscher added a comment. Unstalling as @Sarai-WMDE is working on it. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Lydia_Pintscher triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Lydia_Pintscher merged a task: T312851: Enable reporting of mismatches of qualifier values. TASK DETAIL https://phabricator.wikimedia.org/T313467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: jmkeil, Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Lydia_Pintscher changed the task status from "Open" to "Stalled". Lydia_Pintscher added a comment. This is currently stalled because we need a proper design for how to display the mismatch on the results page. Waiting on new designer to join the team. TASK DETAIL

[Wikidata-bugs] [Maniphest] T313467: ability to report mismatches on qualifiers

Lydia_Pintscher created this task. Lydia_Pintscher added projects: Mismatch Finder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION As a mismatch provider I want to be able to report mismatches to data that is stored in qualifiers in order to improve data