[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg closed subtask T328149: LangSelector added to Mismatch Finder as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Arian_Bozorg, Michael, Lydia_Pintscher, g

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE reopened subtask T328149: LangSelector added to Mismatch Finder as "Open". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg, Sarai-WMDE Cc: Arian_Bozorg, Michael, Lydia_Pint

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg closed subtask T328149: LangSelector added to Mismatch Finder as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Arian_Bozorg, Michael, Lydia_Pintscher, g

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

karapayneWMDE closed subtask T329492: Query Builder: implement mobile version of LanguageSelector as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg, karapayneWMDE Cc: Ar

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board. Arian_Bozorg claimed this task. Arian_Bozorg added a comment. Thanks so much for all your work on this everyone! This is looking

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg closed subtask T328148: LangSelector added to Query Builder as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Michael, Lydia_Pintscher, guergana.tzatchko

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintscher, guergana.tzatchkova, Lucas_Werkmeister_WMDE, ItamarWMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg closed subtask T329490: Query Builder: implement RTL functionality in LanguageSelector component as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Michae

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg closed subtask T329488: Query Builder: Add keyboard navigation to Language Selector Component as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Michael,

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg closed subtask T334675: QueryBuilder: LanguageSelector height is off as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Michael, Lydia_Pintscher, guergana

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE reopened subtask T334675: QueryBuilder: LanguageSelector height is off as "Open". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintscher, guergana.tzatc

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE closed subtask T334675: QueryBuilder: LanguageSelector height is off as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintscher, guergana.tza

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE removed a subtask: T334664: QueryBuilder: Highlighted index in LanguageSelector component's keyboard navigation does not reset on reopening menu. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferen

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE added a subtask: T334664: QueryBuilder: Highlighted index in LanguageSelector component's keyboard navigation does not reset on reopening menu. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreference

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE added a subtask: T334675: QueryBuilder: LanguageSelector height is off. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintscher, guergana.tzatchkova, Luc

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Michael, Lydia_Pintscher, guergana.tzatchkova, Lucas_Werkmeister_WMDE, Itam

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

gerritbot added a comment. Change 907879 **merged** by jenkins-bot: [wikidata/query-builder@master] Make border-radius 0 only for top border https://gerrit.wikimedia.org/r/907879 TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

gerritbot added a comment. Change 907821 **merged** by jenkins-bot: [wikidata/query-builder@master] Vertically align clear button with input field https://gerrit.wikimedia.org/r/907821 TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wi

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

guergana.tzatchkova added a comment. For point 2 @Sarai-WMDE and I have decided that the box-shadow will be left as is for now because the CSS is already there but it is not being displayed as expected and we don't want to invest too much in this at this moment. The border-radius of the top

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

gerritbot added a comment. Change 907879 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova): [wikidata/query-builder@master] Make border-radius 0 only for top border https://gerrit.wikimedia.org/r/907879 TASK DETAIL https://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

guergana.tzatchkova added a comment. @Sarai-WMDE for issue nr 1 could you please check here if the aligment is better: https://907821--clicky-sparqly.netlify.app/ https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/907821 TASK DETAIL https://phabricator.wikimedia.org/T328764 EM

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Michael, Lydia_Pintscher, guergana.tzatchkova, Lucas_Werkmeister_WMDE, ItamarWMDE, Aklapp

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

gerritbot added a comment. Change 907821 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova): [wikidata/query-builder@master] Align clear button with input field https://gerrit.wikimedia.org/r/907821 TASK DETAIL https://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE added a comment. The fix looks good both above and below the tablet breakpoint: the menu preserves a fixed height even when it's filtered and the number of items is reduced. Thank you, @guergana.tzatchkova! TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

guergana.tzatchkova added a subscriber: LucasWerkmeister. guergana.tzatchkova added a comment. Can you please check again issue nr. 3? @Sarai-WMDE @LucasWerkmeister https://905236--clicky-sparqly.netlify.app/ https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/905236 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE attached a referenced file: F36939243: Screenshot 2023-04-04 at 15.31.22.png. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintscher, guergana.tzatchkov

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE attached a referenced file: F36939114: Screenshot 2023-04-04 at 12.48.49.png. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintscher, guergana.tzatchkov

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE attached a referenced file: F36939115: Screenshot 2023-04-04 at 12.49.16.png. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintscher, guergana.tzatchkov

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE reopened subtask T329492: Query Builder: implement mobile version of LanguageSelector as "Open". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE closed subtask T329492: Query Builder: implement mobile version of LanguageSelector as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintsch

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE added a comment. Hello there! Just took a look at the LanguageSelector in Query builder and, first, it looks great! 💯 I just found a couple of small fixes: 1. The clear icon is not vertically aligned within the input: F36925363: Screenshot 2023-03-24 at 10.12 1.png

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Michael added a comment. Potential //future// improvements (for Language Selector v2): - store the language in LocalStorage so that it persists across pageloads - have the entity selector (property selector, Item selectors, etc.) change the language of their contents too - have the se

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Lucas_Werkmeister_WMDE closed subtask T331309: QueryBuilder: Wire query parameter uselang to LanguageSelector button in QB as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werk

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Lydia_Pintscher added a comment. In T328764#8688456 , @Lucas_Werkmeister_WMDE wrote: > Should the current user interface language be part of the shareable link or not? Since we don't include it in the Query UI let's not do it here e

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

guergana.tzatchkova added a comment. In T328764#8688456 , @Lucas_Werkmeister_WMDE wrote: > Should the current user interface language be part of the shareable link or not? Probably not but let's ask in the big runde just to be sure.

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Lucas_Werkmeister_WMDE added a comment. Should the current user interface language be part of the shareable link or not? TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

guergana.tzatchkova updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: ItamarWMDE, Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg closed subtask T329487: QueryBuilder: Create basic one column LanguageSelector component as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: ItamarWMDE, Ak

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Lucas_Werkmeister_WMDE closed subtask T329733: QueryBuilder: Load languages from mediawiki into LanguageSelector as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WM

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

guergana.tzatchkova updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: ItamarWMDE, Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

guergana.tzatchkova closed subtask T329489: Query Builder: add filtering behavior to LanguageSelector component as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova C

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

ItamarWMDE added a comment. **Task Breakdown Notes**: - Query Builder first: will create the component in QB and copy it over to Mismatch Finder - Accept the tech debt of having two copies of the component until we decide whether to upstream it to Codex / inherit a codex - We will no

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuc

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

karapayneWMDE moved this task from Unified prioritized backlog to Sprint-∞ on the Wikidata Dev Team board. karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T328764 WORKBOARD https://phabricator.wikime

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

karapayneWMDE updated the task description. karapayneWMDE set the point value for this task to "13". TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Aklapper, Sarai-WMDE, Astuthio

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuc

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE added a subtask: T328149: LangSelector added to Mismatch Finder. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadi

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE added a subtask: T328148: LangSelector added to Query Builder. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibo

[Wikidata-bugs] [Maniphest] T328764: Implement custom LanguageSelector component

Sarai-WMDE added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckar