Arian_Bozorg closed this task as "Resolved".
Arian_Bozorg moved this task from Product Verification to Our work done on the
Wikidata Dev Team (Sprint-∞) board.
Arian_Bozorg added a comment.
Thanks Guergana!
TASK DETAIL
https://phabricator.wikimedia.org/T329487
WORKBOARD
Maintenance_bot removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T329487
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: guergana.tzatchkova, Maintenance_bot
Cc: Arian_Bozorg, karapayneWMDE, Sarai-WMDE, Aklapper,
gerritbot added a comment.
Change 889547 **merged** by jenkins-bot:
[wikidata/query-builder@master] Add markup and styles for LanguageSelector
component
https://gerrit.wikimedia.org/r/889547
TASK DETAIL
https://phabricator.wikimedia.org/T329487
EMAIL PREFERENCES
Arian_Bozorg added a comment.
Hi @guergana.tzatchkova :)
Just a couple of sizing amendments on this.
It looks like the padding on the bottom of the search is a little too high,
it should be 16px.
Here is a screenshot to illustrate:
F36864738: image.png
karapayneWMDE added a subscriber: Arian_Bozorg.
karapayneWMDE added a comment.
@Arian_Bozorg please see guergana's comment above
TASK DETAIL
https://phabricator.wikimedia.org/T329487
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
guergana.tzatchkova added a comment.
@Arian_Borzog
Please check the visual implementation of the base elements of the component
LanguageSelector. The component has been added to the screen for now just so
you can review it, but it will be not be merged into the code. The component
will
gerritbot added a comment.
Change 890396 **abandoned** by Lucas Werkmeister (WMDE):
[wikidata/query-builder@master] Proposal: Make clearBtnVisible computed
Reason:
squashed into I507187e081
https://gerrit.wikimedia.org/r/890396
TASK DETAIL
gerritbot added a comment.
Change 890395 **abandoned** by Lucas Werkmeister (WMDE):
[wikidata/query-builder@master] Proposal: Use actual for clear button
Reason:
squashed into I507187e081
https://gerrit.wikimedia.org/r/890395
TASK DETAIL
gerritbot added a comment.
Change 889966 **abandoned** by Lucas Werkmeister (WMDE):
[wikidata/query-builder@master] Proposal: Manage language filtering inside
LanguageSelector
Reason:
squashed into I507187e081
https://gerrit.wikimedia.org/r/889966
TASK DETAIL
gerritbot added a comment.
Change 890396 had a related patch set uploaded (by Lucas Werkmeister (WMDE);
author: Lucas Werkmeister (WMDE)):
[wikidata/query-builder@master] Proposal: Make clearBtnVisible computed
https://gerrit.wikimedia.org/r/890396
TASK DETAIL
gerritbot added a comment.
Change 890395 had a related patch set uploaded (by Lucas Werkmeister (WMDE);
author: Lucas Werkmeister (WMDE)):
[wikidata/query-builder@master] Proposal: Use actual for clear button
https://gerrit.wikimedia.org/r/890395
TASK DETAIL
gerritbot added a comment.
Change 889966 had a related patch set uploaded (by Lucas Werkmeister (WMDE);
author: Lucas Werkmeister (WMDE)):
[wikidata/query-builder@master] Proposal: Manage language filtering inside
LanguageSelector
https://gerrit.wikimedia.org/r/889966
TASK DETAIL
guergana.tzatchkova claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T329487
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: guergana.tzatchkova
Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Themindcoder,
Adamm71,
gerritbot added a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T329487
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot
Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Themindcoder,
Adamm71, Jersione,
gerritbot added a comment.
Change 889547 had a related patch set uploaded (by Guergana Tzatchkova;
author: Guergana Tzatchkova):
[wikidata/query-builder@master] Add markup and styles for LanguageSelector
component
https://gerrit.wikimedia.org/r/889547
TASK DETAIL
guergana.tzatchkova removed guergana.tzatchkova as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T329487
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: guergana.tzatchkova
Cc: Sarai-WMDE, Aklapper, ItamarWMDE,
guergana.tzatchkova updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T329487
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: guergana.tzatchkova
Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Astuthiodit_1,
Sarai-WMDE added a comment.
Previous exploration done as part of
{https://phabricator.wikimedia.org/T324653}:
https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/875287/
TASK DETAIL
https://phabricator.wikimedia.org/T329487
EMAIL PREFERENCES
guergana.tzatchkova renamed this task from "Create basic one column
LanguageSelector component" to "QueryBuilder: Create basic one column
LanguageSelector component".
TASK DETAIL
https://phabricator.wikimedia.org/T329487
EMAIL PREFERENCES
19 matches
Mail list logo
