[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

karapayneWMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, karapayneWMDE Cc: noarave, Lucas_Werkmeister_WMDE, Michael, HasanAkgun_WMDE, Arian

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Sarai-WMDE moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board. Sarai-WMDE added a comment. All issues seem fixed. The verification of mobile LanguageSelector was done in master with help from @noarav. TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Sarai-WMDE added a comment. > Looks like, as a result of the latest changes: > > 1. The language list is not taking all the available height of the menu on desktop nor mobile. This issue will be tackled in a separate task T334675 > 2.

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Sarai-WMDE added a comment. > But I am unable to select a language, and the menu also doesn't take all the available height of the viewport on mobile. Indeed. Looks like, as a result of the latest changes: 1. The language list is not taking all the available height of the menu on de

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Arian_Bozorg added a comment. Just tagging @Sarai-WMDE to take a look :) TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Arian_Bozorg Cc: Lucas_Werkmeister_WMDE, Michael, H

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Arian_Bozorg added a comment. Thanks so much, I am not sure if I am checking the right place: https://905236--clicky-sparqly.netlify.app/ But I am unable to select a language, and the menu also doesn't take all the available height of the viewport on mobile. TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, Michael, HasanAkgun_WMDE, Arian

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

gerritbot added a comment. Change 905236 **merged** by jenkins-bot: [wikidata/query-builder@master] Make width and height adjustments to mobile language selector https://gerrit.wikimedia.org/r/905236 TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https:

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

HasanAkgun_WMDE added a comment. In T329492#8753450 , @guergana.tzatchkova wrote: > @Sarai-WMDE and @HasanAkgun_WMDE for clarity's sake, could you add the link to that ticket here in the comments? 🙏 thanks. T334051

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Sarai-WMDE reopened this task as "Open". Sarai-WMDE added a subscriber: LucasWerkmeister. Sarai-WMDE added a comment. Opening this ticket again, since @LucasWerkmeister found an issue in the latest patch that still needs fixing: https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/905236

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

guergana.tzatchkova added a comment. @Sarai-WMDE and @HasanAkgun_WMDE for clarity's sake, could you add the link to that ticket here in the comments? 🙏 thanks. TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpr

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Sarai-WMDE closed this task as "Resolved". Sarai-WMDE added a comment. In T329492#8750894 , @guergana.tzatchkova wrote: > @Sarai-WMDE since this change is a small one, could you approve it (+2) as well on Gerrit? I have seen you have an

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

guergana.tzatchkova added a comment. @Sarai-WMDE since this change is a small one, could you approve it (+2) as well on Gerrit? I have seen you have an account :D TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emai

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Sarai-WMDE added a comment. Thanks for the fix, @guergana.tzatchkova! Looks great 👍🏻 The second issue was detected in the RTL patch, and it hasn't been fixed yet: https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/904092/. I cannot reproduce it in your latest patch (the component

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

guergana.tzatchkova added a comment. @Sarai-WMDE I have created a patch to fix the issue of the full screen, please check it here and let me know if here it is behaving like expected: https://905236--clicky-sparqly.netlify.app/ From your comment I understand that issue nr. 2 has been fixed

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

gerritbot added a comment. Change 905236 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova): [wikidata/query-builder@master] Make position of mobile language selector fixed https://gerrit.wikimedia.org/r/905236 TASK DETAIL https://phabricator.w

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, gerritbot Cc: Michael, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, Aklapper, ItamarW

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Sarai-WMDE attached a referenced file: F36931871: Screenshot 2023-03-29 at 14.30.56.png. TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Sarai-WMDE Cc: HasanAkgun_WMDE, Arian_

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Sarai-WMDE added a subscriber: HasanAkgun_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Sarai-WMDE Cc: HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, Aklapper, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Sarai-WMDE added a comment. Hello! Please note that the Language Selector should become completely full screen on mobile, and cover the top of the page (including the header and the language button). This is the reason why a header with a close button are added to the mobile version of the c

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Maintenance_bot Cc: Arian_Bozorg, Sarai-WMDE, Aklapper, ItamarWMDE, guergan

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

gerritbot added a comment. Change 892394 **merged** by jenkins-bot: [wikidata/query-builder@master] Add mobile design version of Language Selector https://gerrit.wikimedia.org/r/892394 TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wi

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

guergana.tzatchkova added a subscriber: Arian_Bozorg. guergana.tzatchkova added a comment. @Arian_Bozorg you can do the UX review here: https://892394--clicky-sparqly.netlify.app/ TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/se

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, gerritbot Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Themindcoder,

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

gerritbot added a comment. Change 892394 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova): [wikidata/query-builder@master] Add mobile design version of Language Selector https://gerrit.wikimedia.org/r/892394 TASK DETAIL https://phabricator.wik

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

guergana.tzatchkova claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T329492: Query Builder: implement mobile version of LanguageSelector

noarave renamed this task from "Implement mobile version of LanguageSelector " to "Query Builder: implement mobile version of LanguageSelector ". TASK DETAIL https://phabricator.wikimedia.org/T329492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: no