[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Doing to Our work done on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. As far as I’m aware, there were no issues related to this change during the wmf.22 train

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Lucas_Werkmeister_WMDE added a comment. I’ve played around a bit on beta dewiki and not noticed any namespace- or language-related breakage this time. TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: matmarex, Winston_Sung, Nikerabbit, Daimona, Michael

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Daimona added a comment. Just came here to say that I tried running LanguageConverterFactoryTest (which is super slow, see T50217#9030084 ) before and after the changes in this ticket. It went from 12-13 seconds to 1 second, which is AMAZING

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 945765 **merged** by jenkins-bot: [mediawiki/core@master] LocalisationCache: Load only core data if possible (v2) https://gerrit.wikimedia.org/r/945765 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 945764 **merged** by jenkins-bot: [mediawiki/core@master] LocalisationCache: Correctly merge preload data https://gerrit.wikimedia.org/r/945764 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 945763 **merged** by jenkins-bot: [mediawiki/core@master] LocalisationCache: Add tests for preload behavior https://gerrit.wikimedia.org/r/945763 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Lucas_Werkmeister_WMDE added a comment. Probably worth mentioning here that there’s no train next week, so we’ll have more time than usual to test this on Beta. TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 945765 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Load only core data if possible (v2) https://gerrit.wikimedia.org/r/945765 TASK DETAIL https://pha

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 945764 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Correctly merge preload data https://gerrit.wikimedia.org/r/945764 TASK DETAIL https://phabricator.

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: matmarex, Winston_Sung, Nikerabbit, Daimona, Michael, tstarling,

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 945763 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Add tests for preload behavior https://gerrit.wikimedia.org/r/945763 TASK DETAIL https://phabricato

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Lucas_Werkmeister_WMDE added a comment. Okay, I’m pretty sure T343343 (date formats) and T343375 (namespace names) have the same cause – these are exactly the two preloaded l10n cache keys: private

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Michael added a comment. I cannot reproduce the error in T343375 directly, but I can reproduce a very related seeming issue: In my German client-only dev-wiki the contentmodel of `Modul:Sandkasten` (note the missing "e", it is the German name) ch

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Lucas_Werkmeister_WMDE added a comment. Same goes for T343343 if it turns out to be related – try to make a test first that covers it. TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/set

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Lucas_Werkmeister_WMDE reopened this task as "Open". Lucas_Werkmeister_WMDE moved this task from Our work done to Doing on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. Reopening, we’ll have to try this again. (//First// put together a test case to cover the

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Nikerabbit, Daimona, Michael, tstarling, Lucas_Werkm

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-08-02T20:55:26Z] Finished scap: Backport for [[gerrit:944854|Revert "LocalisationCache: Load only core data if possible" (T342418 T343375

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-08-02T20:48:13Z] dancy: Backport for [[gerrit:944854|Revert "LocalisationCache: Load only core data if possible" (T342418 T343375

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-08-02T20:46:38Z] Started scap: Backport for [[gerrit:944854|Revert "LocalisationCache: Load only core data if possible" (T342418 T343375

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 944854 **merged** by jenkins-bot: [mediawiki/core@wmf/1.41.0-wmf.20] Revert "LocalisationCache: Load only core data if possible" https://gerrit.wikimedia.org/r/944854 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 944854 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy): [mediawiki/core@wmf/1.41.0-wmf.20] Revert "LocalisationCache: Load only core data if possible" https://gerrit.wikimedia.org/r/944854 TASK DETAIL https://phabricator.wi

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 944853 **merged** by jenkins-bot: [mediawiki/core@master] Revert "LocalisationCache: Load only core data if possible" https://gerrit.wikimedia.org/r/944853 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabrica

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Daimona, Michael, tstarling, Lucas_Werkmeister_WMDE, Aklapper, Da

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 944853 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy): [mediawiki/core@master] Revert "LocalisationCache: Load only core data if possible" https://gerrit.wikimedia.org/r/944853 TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Lucas_Werkmeister_WMDE added a comment. > 3.209841966629 By the way, that duration is twice as long as in the original task description because it’s rebuilding both `en` and `he`. In the task description, creating the `he` language only required rebuilding `he`. (But if you then called

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE added a comment. I think this is resolved – now the l10n cache is (still slowly ^^) rebuilt when needed instead: > $t1 = microtime( true ); $he = mws()->getLanguageFactory()->getLanguage( 'he' ); $t2 = microt

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Daimona, Michael, tstarling, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 941864 **abandoned** by Lucas Werkmeister (WMDE): [mediawiki/core@master] LocalisationCache: Extract readPluralFilesAndRegisterDeps() Reason: squashed into I7ec2d87c0f https://gerrit.wikimedia.org/r/941864 TASK DETAIL https://phabricator

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 940354 **abandoned** by Lucas Werkmeister (WMDE): [mediawiki/core@master] LocalisationCache: Extract loadCoreData() Reason: squashed into I7ec2d87c0f https://gerrit.wikimedia.org/r/940354 TASK DETAIL https://phabricator.wikimedia.org/T342

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01). TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeis

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 940355 **merged** by jenkins-bot: [mediawiki/core@master] LocalisationCache: Load only core data if possible https://gerrit.wikimedia.org/r/940355 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikime

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 940878 **merged** by jenkins-bot: [mediawiki/core@master] LocalisationCache: Reset loaded(Sub)Items when overwriting data https://gerrit.wikimedia.org/r/940878 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phab

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 942612 **abandoned** by Lucas Werkmeister (WMDE): [mediawiki/core@master] LocalisationCache: Don’t throw away data in initLanguage() Reason: squashed into Ib1c620d4f2 https://gerrit.wikimedia.org/r/942612 TASK DETAIL https://phabricator.

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 940328 **merged** by jenkins-bot: [mediawiki/core@master] LocalisationCache: Add CORE_ONLY_KEYS, ALL_EXCEPT_CORE_ONLY_KEYS https://gerrit.wikimedia.org/r/940328 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://pha

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 942670 **merged** by jenkins-bot: [mediawiki/core@master] LocalisationCache: Expand tests https://gerrit.wikimedia.org/r/942670 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01). TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Daimona, Michael, tstarling

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 942614 **merged** by jenkins-bot: [mediawiki/core@master] LocalisationCache: Make isMergeableKey() static https://gerrit.wikimedia.org/r/942614 TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 942670 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Expand tests https://gerrit.wikimedia.org/r/942670 TASK DETAIL https://phabricator.wikimedia.org/T3

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 942614 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Make isMergeableKey() static https://gerrit.wikimedia.org/r/942614 TASK DETAIL https://phabricator.

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 942612 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Don’t throw away data in initLanguage() https://gerrit.wikimedia.org/r/942612 TASK DETAIL https://

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 941864 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Extract readPluralFilesAndRegisterDeps() https://gerrit.wikimedia.org/r/941864 TASK DETAIL https:/

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Lucas_Werkmeister_WMDE added a comment. I was wondering if we can use this task to make `mw.language` objects less expensive in Lua (compare T85461#3100878 noting that they’re already fairly cheap when the l10n cache is prebuilt), but I don’

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 940158 **abandoned** by Lucas Werkmeister (WMDE): [mediawiki/core@master] POC: Create Language objects without initializing l10n cache Reason: superseded by the other changes attached to T342418, especially I7ec2d87c0f https://gerrit.wikime

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 940878 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Reset loaded(Sub)Items when overwriting data https://gerrit.wikimedia.org/r/940878 TASK DETAIL htt

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

karapayneWMDE set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, karapayneWMDE Cc: Daimona, Michael, tstarling, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 940355 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Load only core data if possible https://gerrit.wikimedia.org/r/940355 TASK DETAIL https://phabricat

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

gerritbot added a comment. Change 940354 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] LocalisationCache: Extract loadCoreData() https://gerrit.wikimedia.org/r/940354 TASK DETAIL https://phabricator.wikime

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T342418 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Michael, tstarling, Lucas_Werkmeister_WMDE, Aklapper, Isabella