[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Michael moved this task from Waiting for Deployment Window to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Michael added a comment. Meh. Phabricator edit conflict. TASK DETAIL https://phabricator.wikimedia.org/T345856 WORKBOARD

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Michael moved this task from Done to Waiting for Deployment Window on the Wikidata Dev Team (Wikidata.org Slice) board. Michael removed Michael as the assignee of this task. Michael added a comment. I think with that, this task should be done, right? Maybe we can wait for nothing

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from In Peer Review to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE added a comment. I think this is all done (including a final set of follow-ups that wasn’t

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 960020 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] MediaInfoId: Remove serialize(), unserialize() https://gerrit.wikimedia.org/r/960020 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Michael claimed this task. Michael moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. Michael set the point value for this task to "1". Michael added a comment. Restricted Application added a project: User-Michael. (Setting the

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.30; 2023-10-10); removed MW-1.41-notes (1.41.0-wmf.27; 2023-09-19). TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 960021 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] LexemeId, LexemeSubEntityId: Remove serialize(), unserialize() https://gerrit.wikimedia.org/r/960021 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955765 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] EntityId: Remove Serializable interface and methods https://gerrit.wikimedia.org/r/955765 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 960019 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Remove tests for serialization stability https://gerrit.wikimedia.org/r/960019 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team (Sprint-∞). TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 960021 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] LexemeId, LexemeSubEntityId: Remove serialize(), unserialize()

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 960020 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@master] MediaInfoId: Remove serialize(), unserialize() https://gerrit.wikimedia.org/r/960020 TASK

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 960019 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@master] Remove tests for serialization stability https://gerrit.wikimedia.org/r/960019 TASK DETAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE added a comment. No deprecations this train (which is now fully rolled out) as far as I can see; I think we can move ahead with this (but let’s only merge the next change after the branch cut). TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T345856 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Sprint-∞). TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: jnuche, Aklapper, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 957772 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Restore "EntityId: Hard-deprecate Serializable methods" https://gerrit.wikimedia.org/r/957772 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 957772 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Restore "EntityId: Hard-deprecate Serializable methods" https://gerrit.wikimedia.org/r/957772 TASK

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.26; 2023-09-12). TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 957286 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Use EntityId::getSerialization() instead of serialize() (pt. 2) https://gerrit.wikimedia.org/r/957286 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE added a comment. Codesearch for Id->serialize() also only finds that one MediaInfo place and a third-party extension (ProfessionalWiki/GND#6

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE added a comment. Logstash looks like `WikibaseMediaInfoHooks` was the only place triggering the deprecation, so I think we can try to restore the hard deprecation (for the next train) once the above change is merged: F37718020: image.png

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 957286 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@master] Use EntityId::getSerialization() instead of serialize() (pt. 2)

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Aklapper lowered the priority of this task from "Unbreak Now!" to "Needs Triage". Aklapper added a comment. After deployment of `1.41.0-wmf.26` to group1, we had a spike from T345856 (as warned about in T343728#9152385

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Aklapper removed a parent task: T343728: 1.41.0-wmf.26 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Aklapper Cc: jnuche, Aklapper, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE added a comment. In T345856#9162619 , @jnuche wrote: > @Lucas_Werkmeister_WMDE after deploying to group 1 we are seeing ~5k/s errors generated in the logs. I think we need a revert for this or need to roll back.

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

jnuche added a comment. @Lucas_Werkmeister_WMDE after deploying to group 1 we are seeing ~5k/s errors generated in the logs. I think we need a revert for this or need to roll back. TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

jnuche triaged this task as "Unbreak Now!" priority. TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jnuche Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983,

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

jnuche added a parent task: T343728: 1.41.0-wmf.26 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jnuche Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955898 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] EntityId: Hard-deprecate Serializable methods https://gerrit.wikimedia.org/r/955898 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955900 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Hard-deprecate EntityId::serialize() and unserialize() https://gerrit.wikimedia.org/r/955900 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955899 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Hard-deprecate EntityId::serialize() and unserialize() https://gerrit.wikimedia.org/r/955899 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE added a comment. Note that removing the interface will break the ability to `unserialize()` old serializations; we have some tests for this, but I hope it never happens in practice. The hard deprecations in Wikibase

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955760 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] EntityId: Soft-deprecate Serializable methods and stop using them https://gerrit.wikimedia.org/r/955760 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955900 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@master] Hard-deprecate EntityId::serialize() and unserialize() https://gerrit.wikimedia.org/r/955900

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955899 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Hard-deprecate EntityId::serialize() and unserialize() https://gerrit.wikimedia.org/r/955899 TASK

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955898 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] EntityId: Hard-deprecate Serializable methods https://gerrit.wikimedia.org/r/955898 TASK DETAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955761 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Use EntityId::getSerialization() instead of serialize() https://gerrit.wikimedia.org/r/955761 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955762 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Use EntityId::getSerialization() instead of serialize() https://gerrit.wikimedia.org/r/955762 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955763 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use EntityId::getSerialization() instead of serialize() https://gerrit.wikimedia.org/r/955763 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12). TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: Aklapper, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955764 **merged** by jenkins-bot: [mediawiki/extensions/Math@master] Use EntityId::getSerialization() instead of serialize() https://gerrit.wikimedia.org/r/955764 TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955765 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] EntityId: No longer extend Serializable https://gerrit.wikimedia.org/r/955765 TASK DETAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE added a comment. Apparently we haven’t released version 10.0.0 of the Wikibase datamodel library yet, so in the released versions there’ll just be a jump from the old methods to the new ones, without the overlapping period where it supports both. But most users should

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955764 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Math@master] Use EntityId::getSerialization() instead of serialize() https://gerrit.wikimedia.org/r/955764 TASK DETAIL

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955763 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use EntityId::getSerialization() instead of serialize()

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955762 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@master] Use EntityId::getSerialization() instead of serialize() https://gerrit.wikimedia.org/r/955762

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955761 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Use EntityId::getSerialization() instead of serialize() https://gerrit.wikimedia.org/r/955761

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T345856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983,

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

gerritbot added a comment. Change 955760 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Entity: Soft-deprecate Serializable methods and stop using them https://gerrit.wikimedia.org/r/955760

[Wikidata-bugs] [Maniphest] T345856: Remove Serializable interface from EntityId

Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-DataModel, wdwb-tech. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION In T301249: Handle deprecation of Serializable interface in Wikibase