[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

AndrewTavis_WMDE added a comment. Exciting! I'll play around a bit towards the end of next week and send along a PR with the workflow, docs and changes given the local run warnings  Will let you know if anything comes up before then. Have a nice weekend when it comes along! TASK DETAIL

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

nshahquinn-wmf added a project: Movement-Insights. TASK DETAIL https://phabricator.wikimedia.org/T348999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, nshahquinn-wmf Cc: nshahquinn-wmf, xcollazo, Aklapper, AndrewTavis_WMDE,

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

nshahquinn-wmf added a comment. @AndrewTavis_WMDE that sounds great to me! I personally have no preference about the package we choose, so I'm on board with the idea of Ruff with the Black ruleset (since that's what Data Engineering uses). Looking forward to it!  TASK DETAIL

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

AndrewTavis_WMDE added a comment. @nshahquinn-wmf, @xcollazo: checking in on this one again. I would have some time in the next two weeks or so to implement a PR workflow check of linting and code formatting. If folks are fine with Ruff that'd be easiest

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

mpopov removed a project: Product-Analytics. TASK DETAIL https://phabricator.wikimedia.org/T348999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, mpopov Cc: nshahquinn-wmf, xcollazo, Aklapper, AndrewTavis_WMDE,

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

xcollazo added a comment. > what other Wikimedia Python projects do FWIW, in Data Engineering land, we have (arbitrarily) chosen black as de facto for recent projects. Having said

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

AndrewTavis_WMDE added a comment. We could further make use of pre-commit to check code before commits, which is further something that's suggested in the WMF Airflow docs

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

AndrewTavis_WMDE added a comment. Ruff also just brought out its own formatter that's fully compatible with Black. As far as formatting adoption at WMF, product analytics states here in their styleguide

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

nshahquinn-wmf added a comment. > The Product Analytics Styleguide suggests PEP 8, but maybe we want to consider black in that it's now Python Software Foundation maintained and can integrate with Ruff. I think it's well worth considering! The only thing I'd want to check first is

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

AndrewTavis_WMDE added a comment. Updated the task and also mentioned maybe adding an auto-formatter that could help to make sure that things are running smoothly before we have workflows set up to test PRs/MRs :) TASK DETAIL https://phabricator.wikimedia.org/T348999 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)

AndrewTavis_WMDE renamed this task from "wmfdata-python formatting and link check" to "Add linter and formatter to wmfdata-python (and link check)". AndrewTavis_WMDE claimed this task. AndrewTavis_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T348999 EMAIL