[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-26 Thread Tarrow
Tarrow added a comment. @Lea_WMDE It should be on beta now :) TASK DETAIL https://phabricator.wikimedia.org/T222890 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Pablo-WMDE, Jakob_WMDE, Lucas_Werkmeister_WMDE, Hanna_Petruschat_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-26 Thread Lea_WMDE
Lea_WMDE added a comment. On beta, the loading bar is still in Wikidata colors. Could you update the code base @Tarrow ? Thanks! TASK DETAIL https://phabricator.wikimedia.org/T222890 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow,

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-26 Thread Tarrow
Tarrow added a comment. I took the following extra details from figma: - Height of the progress bar is always 20px - From the two examples it appeared to be as close as possible to horizontally and vertically centered so I did this - box-shadow is added - border colour is as

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-23 Thread Lea_WMDE
Lea_WMDE added a comment. Hey @Jakob_WMDE, thanks for the link! I checked beta and the storybook and it looks great to me! I think the storybook link works fine for me to see that you chose a blue (and if you want to have an intermediary check that is a great way to do it), but for

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-22 Thread Jakob_WMDE
Jakob_WMDE added a comment. @Lea_WMDE removing the icon from the progress bar happened. This can be seen here: https://tools-static.wmflabs.org/wikibase-termbox-storybook/?path=/story/indeterminateprogressbar--default Hidden question: What do you think about product-reviewing minor

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-19 Thread gerritbot
gerritbot added a comment. Change 524541 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Bump Termbox Pin https://gerrit.wikimedia.org/r/524541 TASK DETAIL https://phabricator.wikimedia.org/T222890 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-19 Thread gerritbot
gerritbot added a comment. Change 524188 **merged** by jenkins-bot: [wikibase/termbox@master] Show IndeterminateProgressBar when saving https://gerrit.wikimedia.org/r/524188 TASK DETAIL https://phabricator.wikimedia.org/T222890 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-19 Thread gerritbot
gerritbot added a comment. Change 524022 **merged** by jenkins-bot: [wikibase/termbox@master] Introduce IndeterminateProgressBar https://gerrit.wikimedia.org/r/524022 TASK DETAIL https://phabricator.wikimedia.org/T222890 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-19 Thread gerritbot
gerritbot added a comment. Change 524541 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Bump Termbox Pin https://gerrit.wikimedia.org/r/524541 TASK DETAIL https://phabricator.wikimedia.org/T222890 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-19 Thread Pablo-WMDE
Pablo-WMDE added a comment. Love it. IE11: F29812246: VirtualBox_IE11 - Win7_19_07_2019_13_47_56.png In integration with mw (FF): F29812275: Bildschirmfoto von 2019-07-19 14-13-49.png TASK

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-18 Thread gerritbot
gerritbot added a comment. Change 524188 had a related patch set uploaded (by Tarrow; owner: Tarrow): [wikibase/termbox@master] Show IndeterminateProgressBar when saving https://gerrit.wikimedia.org/r/524188 TASK DETAIL https://phabricator.wikimedia.org/T222890 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T222890: Show progress/activity if a save request is still being processed

2019-07-18 Thread gerritbot
gerritbot added a comment. Change 524022 had a related patch set uploaded (by Tarrow; owner: Tarrow): [wikibase/termbox@master] Introduce IndeterminateProgressBar https://gerrit.wikimedia.org/r/524022 TASK DETAIL https://phabricator.wikimedia.org/T222890 EMAIL PREFERENCES