I've made some changes promoting better coding patterns in some contexts.
These are for MediaWiki 1.18, extensions can keep their old patterns
till they drop support for pre-1.18.
I'd like to consider dropping the rewriting of $wgTitle and $wgOut
inside of SpecialPage::capturePath around
User IAlex posted a comment on MediaWiki.r85226.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85226#c15635
Comment:
I like the fact to less rely on global objects, but I would much prefer
centralising all this stuff in a context object as described in
User Dantman posted a comment on MediaWiki.r85226.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85226#c15636
Comment:
Hmmm... ok, that is a good idea. Though after a look over that I think this api
is fine enough for now.
Even after we move to something like that special
On 28/03/11 23:26, Amir E. Aharoni wrote:
In MediaWiki there are two preferences: Disable AJAX suggestions and
Enable enhanced search suggestions (Vector skin only).
They are problematic for several reasons:
1. Most average users don't know what AJAX is. It should be just
called search
On 04/02/2011 04:08 PM, Ryan Kaldari wrote:
2. Creating The Complete Idiot's Guide to Writing MediaWiki Extensions
and The Complete Idiot's Guide to Writing MediaWiki Gadgets (in jQuery)
+1 ... Beyond the guide we could win a lot by centralising some of the
scripts and libraries on
User Nikerabbit posted a comment on MediaWiki.r85224.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85224#c15637
Comment:
Why not code/[...]/u/code?
Can you mark visibility of codeguessVariant/code and perhaps also add
@since tag?
Have you done tests to measure if this
User Nikerabbit changed the status of MediaWiki.r85228.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r85228.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85228#c15638
Comment:
+$this-getOutput()addWikiMsg('intentionallyblankpage');
User Dantman changed the status of MediaWiki.r85228.
Old Status: fixme
New Status: new
User Dantman also posted a comment on MediaWiki.r85228.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85228#c15639
Comment:
Fixed.
___
User Duplicatebug posted a comment on MediaWiki.r73743.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73743#c15640
Comment:
Which revision? The last change to that line is the revert r76457.
___
MediaWiki-CodeReview mailing list
User IAlex posted a comment on MediaWiki.r81895.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81895#c15641
Comment:
After some investigation, I'm not really sure $mFullTitle is needed since
$wgTitle is set to $this-getTitle() in
User Catrope changed the status of MediaWiki.r85151.
Old Status: new
New Status: fixme
User Catrope also posted a comment on MediaWiki.r85151.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85151#c15642
Comment:
The merge of r81960 is broken:
User Catrope changed the status of MediaWiki.r85185.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85185#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r85168.
Old Status: new
New Status: resolved
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85168#c0
___
MediaWiki-CodeReview mailing list
User Catrope posted a comment on MediaWiki.r85211.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85211#c15643
Comment:
r82465 wasn't merged, retagged.
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r85211.
Old Status: new
New Status: fixme
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85211#c0
___
MediaWiki-CodeReview mailing list
User Catrope posted a comment on MediaWiki.r85211.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85211#c15644
Comment:
r82468, r82474 weren't merged, retagged.
___
MediaWiki-CodeReview mailing list
User Catrope posted a comment on MediaWiki.r85211.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85211#c15645
Comment:
r82475, r82480 weren't merged, retagged.
___
MediaWiki-CodeReview mailing list
(I just posted the following to the tech blog, http://techblog.wikimedia.org)
Last Monday, our Solaris server that contains all image thumbnails developed
problems. It ran out of memory, became too slow and eventually even started to
crash. (For the technically inclined: we think the kernel is
User Happy-melon changed the status of MediaWiki.r83789.
Old Status: fixme
New Status: new
User Happy-melon also posted a comment on MediaWiki.r83789.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83789#c15646
Comment:
That was a deliberate change in r82948.
User Nikola Smolenski posted a comment on MediaWiki.r85224.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85224#c15647
Comment:
I forgot that it exists! :D Done all in r85239 (I used @since 1.17 since I
understand it won't be released soon).
I have not, though I assume it
User Siebrand posted a comment on MediaWiki.r85216.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85216#c15648
Comment:
Please do not mix an L10n update with code changes.
___
MediaWiki-CodeReview mailing list
bawolff wrote:
The good thing about forgotten/abandoned/unloved/etc. projects is
that
they probably don't have lots of cruft accumulated in the global
CSS/JS
files (as they require quite lively tech-savvy community to
maintain them).
So those sites will not probably require any
User Siebrand changed the status of MediaWiki.r85229.
Old Status: new
New Status: fixme
User Siebrand also posted a comment on MediaWiki.r85229.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85229#c15649
Comment:
PHP Strict Standards: Only variables should be passed by
User Dantman changed the status of MediaWiki.r85229.
Old Status: fixme
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85229#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User MaxSem changed the status of MediaWiki.r85177.
Old Status: new
New Status: fixme
User MaxSem also posted a comment on MediaWiki.r85177.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85177#c15650
Comment:
Causes
blockquote
Warning: date_create() expects parameter 2 to be
User Catrope changed the status of MediaWiki.r85152.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85152#c0
___
MediaWiki-CodeReview mailing list
Daniel Friesen wrote:
I'm going to be making a change to trunk soon that removes
$skin-mTitle, any extension directly accessing this (supposed to be
private) method directly will break in 1.18. Please update code to use
the getTitle() method that was added in 1.16.
--
~Daniel Friesen
User Catrope changed the status of MediaWiki.r85194.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85194#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r80813.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/80813#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r83798.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/83798#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r84459.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84459#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r84820.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84820#c0
___
MediaWiki-CodeReview mailing list
User Nikerabbit changed the status of MediaWiki.r85232.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r85232.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85232#c15651
Comment:
New hooks should be documented.
On 3 April 2011 09:17, Daniel Friesen li...@nadir-seen-fire.com wrote:
I've made some changes promoting better coding patterns in some contexts.
These are for MediaWiki 1.18, extensions can keep their old patterns
till they drop support for pre-1.18.
I'd like to consider dropping the
User Nikerabbit posted a comment on MediaWiki.r85224.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85224#c15652
Comment:
1.17 is already branched. What is in trunk will go into 1.18.
___
MediaWiki-CodeReview mailing list
User Nikerabbit changed the status of MediaWiki.r85247.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r85247.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85247#c15653
Comment:
[03-Apr-2011 14:28:51] PHP Fatal error: Call to undefined
User Krinkle posted a comment on MediaWiki.r85257.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85257#c15654
Comment:
This is a follow-up
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Krinkle posted a comment on MediaWiki.r85257.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85257#c15655
Comment:
to r85247.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Happy-melon posted a comment on MediaWiki.r85257.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85257#c15656
Comment:
This fixes one immediate issue, but it only gets a few lines further before
choking on something else wrong in r85247.
User Krinkle posted a comment on MediaWiki.r85250.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85250#c15657
Comment:
(3 lines skipped) [03-Apr-2011 14:54:59] PHP Fatal error: Call to a member
function getUserPage() on a non-object in /www/w/includes/Skin.php on line 1366
User Krinkle posted a comment on MediaWiki.r85247.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85247#c15658
Comment:
See also r85250.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Nikerabbit changed the status of MediaWiki.r85227.
Old Status: new
New Status: ok
User Nikerabbit also posted a comment on MediaWiki.r85227.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85227#c15659
Comment:
How long do you plan to retain fallback to globals here?
User Nikerabbit posted a comment on MediaWiki.r85230.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85230#c15660
Comment:
code@since/code 1.18 would be nice in OutputPage
___
MediaWiki-CodeReview mailing list
User Nikerabbit posted a comment on MediaWiki.r85231.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85231#c15661
Comment:
Follow-up in the summary is wrong.
___
MediaWiki-CodeReview mailing list
User Nikerabbit posted a comment on MediaWiki.r85233.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85233#c15662
Comment:
Shouldn't the message be escaped?
+$pagelinktexts = $this-getPageLinkTexts( $tpl-skin-mTitle-mArticleID,
wfMsg( 'editsection' ) );
I don't understand why
User Nikerabbit changed the status of MediaWiki.r85235.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85235#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Nikerabbit changed the status of MediaWiki.r85236.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85236#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Aaron Schulz changed the status of MediaWiki.r85243.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85243#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Krinkle changed the status of MediaWiki.r85261.
Old Status: new
New Status: deferred
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85261#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Nikerabbit changed the status of MediaWiki.r85257.
Old Status: new
New Status: fixme
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85257#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On Sat, Apr 2, 2011 at 11:17 PM, Daniel Friesen
li...@nadir-seen-fire.comwrote:
I've made some changes promoting better coding patterns in some contexts.
These are for MediaWiki 1.18, extensions can keep their old patterns
till they drop support for pre-1.18.
[snip]
When working on special
Would any of those be useful project ideas for Google Summer of Code
students? If so, please add a bullet point or two:
http://www.mediawiki.org/wiki/Summer_of_Code_2011
best,
Sumana Harihareswara
On 04/01/2011 10:11 PM, Conrad Irwin wrote:
Ok — yes loading speeds are definitely something
User Krinkle changed the status of MediaWiki.r71135.
Old Status: deferred
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71135#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Jack Phoenix changed the status of MediaWiki.r85267.
Old Status: deferred
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85267#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On 04/03/2011 07:56 PM, Brion Vibber wrote:
In particular, I think there's some low-hanging fruit in the Gadgets system.
Right now it's honestly pretty awkward to create a Gadget in the first
place, and sharing code modules between wikis requires a lot of
cut-and-pasting (which leads to
On Sun, Apr 3, 2011 at 12:14 PM, Amir E. Aharoni
amir.ahar...@mail.huji.ac.il wrote:
2011/4/3 Brion Vibber br...@pobox.com:
In particular, I think there's some low-hanging fruit in the Gadgets
system.
Right now it's honestly pretty awkward to create a Gadget in the first
place, and
On 03.04.2011, 23:35 Brion wrote:
On Sun, Apr 3, 2011 at 12:14 PM, Amir E. Aharoni
amir.ahar...@mail.huji.ac.il wrote:
I'm not a real MediaWiki developer, so it may be a silly question: How
hard it is to convert a gadget into an extension? If it's not too
hard, wouldn't it be better to
User Aaron Schulz changed the status of MediaWiki.r85272.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85272#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Aaron Schulz changed the status of MediaWiki.r85253.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85253#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Jack Phoenix posted a comment on MediaWiki.r85267.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85267#c15666
Comment:
Thanks! Fixed in r85274; I thought that there was a better way of doing this
than with wfMsgExt() but I just couldn't remember it...
Brion Vibber wrote:
I'm not a real MediaWiki developer, so it may be a silly question: How
hard it is to convert a gadget into an extension? If it's not too
hard, wouldn't it be better to redo useful gadgets as extensions?
Unless i miss something very basic, this will make them easier to
User ^demon changed the status of MediaWiki.r84548.
Old Status: fixme
New Status: new
User ^demon also posted a comment on MediaWiki.r84548.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84548#c15667
Comment:
Changes for installer stuff were already merged, not an issue.
User ^demon posted a comment on MediaWiki.r85151.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85151#c15668
Comment:
I have yet to get a single Resources.php merge without annoying conflicts :(
___
MediaWiki-CodeReview mailing list
User Nikerabbit posted a comment on MediaWiki.r85240.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85240#c15669
Comment:
[03-Apr-2011 20:27:40] PHP Catchable fatal error: Argument 1 passed to
RequestContext::setTitle() must be an instance of Title, null given, called in
Brion Vibber wrote:
I'm not a real MediaWiki developer, so it may be a silly question:
How
hard it is to convert a gadget into an extension? If it's not too
hard, wouldn't it be better to redo useful gadgets as extensions?
Unless i miss something very basic, this will make them easier to
Lewis Cawte wrote:
[...]
I do agree that some of those gadgets should not be
extensions, however for example, Twinkle, would be a very nice
extension, as noted from various blips of activity from site owners
over
IRC.
-- Lewis Cawte
Maybe, but when done as an extension imho it should be
On Sun, Apr 3, 2011 at 2:23 PM, Krinkle krinklem...@gmail.com wrote:
Lewis Cawte wrote:
[...]
I do agree that some of those gadgets should not be
extensions, however for example, Twinkle, would be a very nice
extension, as noted from various blips of activity from site owners
over IRC.
On 11-04-03 07:29 AM, Niklas Laxström wrote:
On 3 April 2011 09:17, Daniel Friesenli...@nadir-seen-fire.com wrote:
I've made some changes promoting better coding patterns in some contexts.
These are for MediaWiki 1.18, extensions can keep their old patterns
till they drop support for
User Dantman posted a comment on MediaWiki.r85227.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85227#c15671
Comment:
No more globals, all that is inside RequestContext now.
___
MediaWiki-CodeReview mailing list
User Happy-melon changed the status of MediaWiki.r85240.
Old Status: fixme
New Status: new
User Happy-melon also posted a comment on MediaWiki.r85240.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85240#c15673
Comment:
And fixed in r85285.
On 11-04-03 10:28 AM, Brion Vibber wrote:
On Sat, Apr 2, 2011 at 11:17 PM, Daniel Friesen
li...@nadir-seen-fire.comwrote:
When working on special pages (ESPECIALLY includable special pages):
- Use $this-getOutput() instead of the $wgOut global.
- Use $this-getUser() instead of the $wgUser
User Happy-melon posted a comment on MediaWiki.r85296.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15675
Comment:
This probably supercedes r85257?
___
MediaWiki-CodeReview mailing list
User Dantman posted a comment on MediaWiki.r85296.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15676
Comment:
No... that's the right way to do it.. ;) I just inadvertently forced you to
fix it now instead of letting the wfDeprecated calls prod you.
On Mon, Apr 4, 2011 at 3:56 AM, Brion Vibber br...@pobox.com wrote:
* Cross-wiki gadget sharing: if we can avoid fragmenting common scripts,
they'll be easier to maintain.
Not really, It's just up to the local sysops to decide if they want to
do it that way or not.
For example, HotCat is
User Dantman posted a comment on MediaWiki.r85250.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85250#c15677
Comment:
Fixed.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Dantman posted a comment on MediaWiki.r85240.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85240#c15678
Comment:
I believe Happy-melon fixed that in r85278.
___
MediaWiki-CodeReview mailing list
On 03/29/2011 10:48 AM, Platonides wrote:
I was expecting this the week hip-hop hit. What would be required to
target hip-hop? How does that differ from working from Zend?
I've explored the issues and made some initial changes to my working
copy. I'm now waiting for it to compile, and once
On 04/03/2011 10:56 AM, Brion Vibber wrote:
Harder, but very interesting in the medium to long-term:
We would do good to survey and analyse other gadget, widget,
add-on systems and communities that exist in web platforms. Not to
say that wikipedias needs are the same, just that there are
User Aaron Schulz changed the status of MediaWiki.r85304.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85304#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Aaron Schulz posted a comment on MediaWiki.r85230.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85230#c15679
Comment:
r85305
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Nikola Smolenski posted a comment on MediaWiki.r85232.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85232#c15680
Comment:
http://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateLanguageBoxEnd
___
MediaWiki-CodeReview mailing
User Nikola Smolenski posted a comment on MediaWiki.r85233.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85233#c15682
Comment:
:Shouldn't the message be escaped?
I don't know; it is not escaped in MediaWiki itself (see
Linker::doEditSectionLink() ).
:I don't understand why
On 04/04/2011 12:11 PM, Brion Vibber wrote:
Whee! So far it sounds like most of these are things we can work around
reasonably sensibly, so mostly good news. Any remaining issues with 'scary
reference stuff' like stub objects, or do those semantics actually already
work for us?
I'm not
User Nikola Smolenski posted a comment on MediaWiki.r85232.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85232#c15684
Comment:
I guess I could do something like this:
pre
function languageBox() {
if( $this-data['language_urls'] ) {
User Dantman posted a comment on MediaWiki.r85232.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85232#c15685
Comment:
We already have a hook to edit template data like language_urls,
SkinTemplateOutputPageBeforeExec.
___
85 matches
Mail list logo
