Re: [Wikitech-l] Release schedule for the rest of 2011 (was: Status of 1.17 & 1.18)

2011-04-29 Thread Max Semenik
On Sat, Apr 30, 2011 at 5:05 AM, Chad wrote: > > As for 1.18, I say we branch it the same day we drop 1.17 final (making the > branch is easy). There's still quite a bit of code to review, but going > ahead > and giving ourselves a cutoff point will make catching up easier. Large > projects > sti

[MediaWiki-CodeReview] [MediaWiki r87157]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r87157. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87157#c0 Commit summary: Rename the "stable" option to "stablepages" to match docs and be consistent with quality pages. Also make quality opt

[MediaWiki-CodeReview] [MediaWiki r87154]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r87154. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87154#c16433 Commit summary: initial import of proof of concept Comment: FYI we have http://svn.wikimedia.org/viewvc/mediawiki/trunk/tools/code-utils/stylize.php?view=markup _

Re: [Wikitech-l] Release schedule for the rest of 2011 (was: Status of 1.17 & 1.18)

2011-04-29 Thread Jeroen De Dauw
+1; Sent from my Android phone. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Release schedule for the rest of 2011 (was: Status of 1.17 & 1.18)

2011-04-29 Thread Chad
On Wed, Apr 27, 2011 at 12:43 PM, Chad wrote: > Getting the merges reviewed [0] and making sure we have a good set of > release notes. That's what I know of, and Reedy's been working on the > latter. > I've been thinking about this over the past few days, and I've got a proposed release schedule

[MediaWiki-CodeReview] [MediaWiki r87155]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87155. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87155#c0 Commit summary: propset svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-c

[MediaWiki-CodeReview] [MediaWiki r87154]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r87154. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87154#c16432 Commit summary: initial import of proof of concept Comment: Need to fix your [[Subversion/auto-props]] Also, have a look at our [[Manual:Coding conventions]]

[MediaWiki-CodeReview] [MediaWiki r87153]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87153. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87153#c0 Commit summary: Fix undefined variable used in hook call Fix whitespace/braces/indenting Remove another unused global __

[MediaWiki-CodeReview] [MediaWiki r87129]: New comment added, and revision status changed

2011-04-29 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87129. Old Status: fixme New Status: reverted User "Brion VIBBER" also posted a comment on MediaWiki.r87129. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87129#c16431 Commit summary: * (bug 21196) Article::getContributors()

[MediaWiki-CodeReview] [MediaWiki r83808]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83808. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83808#c0 Commit summary: Cleanup parts of GNSM, especially parts relating to the SitemapFeed class and FeedSMItem. *Make it so fatal errors cannot

[MediaWiki-CodeReview] [MediaWiki r84132]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84132. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84132#c0 Commit summary: This extension does lots of queries, so try to cache the result. Will also try to check validity of cache based on the add

[MediaWiki-CodeReview] [MediaWiki r83871]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83871. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83871#c0 Commit summary: Several fixes: *Output a news:publication tag in the sitemap format. This is required by the spec. *Fix the notcategories

[MediaWiki-CodeReview] [MediaWiki r86451]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r86451. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86451#c0 Commit summary: * Move FlaggedRevs integration for GNSM to a hook that FlaggedRevs can use * Rename GNSM::doQuery() to GNSM::getCategories(

[MediaWiki-CodeReview] [MediaWiki r87140]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87140. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87140#c0 Commit summary: Set it's s-maxage to 1800 (half hour) per comments on the bug report. Was originally going to directly output the header i

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Bawolff" posted a comment on MediaWiki.r86047. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c16430 Commit summary: History: Adding JS that converts buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug 16165 Comment: This makes things

[MediaWiki-CodeReview] [MediaWiki r87129]: New comment added, and revision status changed

2011-04-29 Thread MediaWiki Mail
User "OverlordQ" changed the status of MediaWiki.r87129. Old Status: new New Status: fixme User "OverlordQ" also posted a comment on MediaWiki.r87129. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87129#c16429 Commit summary: * (bug 21196) Article::getContributors() no longer f

[MediaWiki-CodeReview] [MediaWiki r86927]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r86927. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86927#c0 Commit summary: adding language support to #time parser function, per bug 28655 ___ MediaWi

[MediaWiki-CodeReview] [MediaWiki r86927]: New comment added

2011-04-29 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r86927. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86927#c16428 Commit summary: adding language support to #time parser function, per bug 28655 Comment: Yes, thank you for clearing that up.

[MediaWiki-CodeReview] [MediaWiki r87132]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Bryan" posted a comment on MediaWiki.r87132. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87132#c16427 Commit summary: * (bug 28238) paraminfo: output both limits for multi param Comment: The most useful limit is still the old canApiHighLimits() conditional. I would use

Re: [Wikitech-l] Media embedding: oEmbed feedback?

2011-04-29 Thread Bryan Tong Minh
On Fri, Apr 29, 2011 at 10:30 PM, Brion Vibber wrote: > currently there's no exposed > license metadata (highly desired for Wikimedia's usage, obviously) > Krinkle and me have been working on that a while ago, but after discussion on this list it appeared that we were following a wrong track. We'l

Re: [Wikitech-l] Packaging mediawiki : includes/zhtable

2011-04-29 Thread Johannes Weberhofer
So I'll remove this directory from the package completely. Interesting is, that the ZhConversion.php generated during build at the build-server differs significantly from the one that is packaged in the includes directory. It's around 30kB larger. I have also notified, that I can not build the

[MediaWiki-CodeReview] [MediaWiki r86657]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Dantman" posted a comment on MediaWiki.r86657. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86657#c16426 Commit summary: Added jquery.json library to core. Comment: :/ that tool doesn't want to add Konqueror to the list of browsers: A: 336,372 ±2.94%22% slower B: 430,547

[Wikitech-l] Media embedding: oEmbed feedback?

2011-04-29 Thread Brion Vibber
Enhanced media player goodies like embedding have been slowly coming along, with a handy embedding option now available in the fancy version of the media player running on Commons. This lets you copy a bit of HTML you can paste into your blog or other web site to drop in a video and make it playabl

[MediaWiki-CodeReview] [MediaWiki r87128]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87128. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87128#c0 Commit summary: Adding myself to the author list for AFT ___ MediaWi

[MediaWiki-CodeReview] [MediaWiki r86965]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Bawolff" posted a comment on MediaWiki.r86965. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86965#c16425 Commit summary: This change adds support for the \widetilde command as mentioned in bug 26380 Comment: btw, don't forget to add to the bug report which revision you f

[MediaWiki-CodeReview] [MediaWiki r87127]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Platonides" changed the status of MediaWiki.r87127. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87127#c0 Commit summary: Followup r86800, add missing () ___ MediaWiki-CodeReview mailing list medi

[MediaWiki-CodeReview] [MediaWiki r87098]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r87098. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87098#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-04-28 19:52:00 UTC) _

[MediaWiki-CodeReview] [MediaWiki r86800]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r86800. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86800#c0 Commit summary: Tidy up some unused variables and such ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86657]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r86657. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86657#c16424 Commit summary: Added jquery.json library to core. Comment: Okay, so CR parsing is messing up as usual. Second attempt: http://jsperf.com/mediawiki-r86657-cr __

[MediaWiki-CodeReview] [MediaWiki r86657]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r86657. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86657#c16423 Commit summary: Added jquery.json library to core. Comment: For what it's worth: http://jsperf.com/mediawiki-r86657-cr The former seems to be faster. _

[MediaWiki-CodeReview] [MediaWiki r86800]: New comment added, and revision status changed

2011-04-29 Thread MediaWiki Mail
User "Platonides" changed the status of MediaWiki.r86800. Old Status: new New Status: fixme User "Platonides" also posted a comment on MediaWiki.r86800. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86800#c16422 Commit summary: Tidy up some unused variables and such Comment:

Re: [Wikitech-l] Packaging mediawiki : includes/zhtable

2011-04-29 Thread Aryeh Gregor
On Fri, Apr 29, 2011 at 9:05 AM, Philip Tzou wrote: > It is just a generator of ZhConversion.php. Run makefile.py would generate a > new ZhConversion.php. So the only people who need the file would be developers, who will not want to use packaged versions anyway, and so it would make sense to jus

[MediaWiki-CodeReview] [MediaWiki r87126]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Happy-melon" posted a comment on MediaWiki.r87126. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87126#c16421 Commit summary: The $wgLocalisationCacheConf was being overwritten by the default value. Restores the ability to run databaseless tests broken by r86775 Comment:

Re: [Wikitech-l] MediaWiki Supported Browser List

2011-04-29 Thread Platonides
jida...@jidanni.org wrote: > http://www.mediawiki.org/wiki/Compatibility#CSS >> MediaWiki is compatible with user agents which do not process CSS3 >> markup. Some additional features are available to browsers which can >> process these styles. > I.e., tough luck for browsers who can't. > https://bu

Re: [Wikitech-l] Packaging mediawiki : includes/zhtable

2011-04-29 Thread Platonides
Johannes Weberhofer wrote: > Dear all! > > I'm currently packaging mediawiki (for opensuse), and have a question related > to "includes/zhtable". > > I think, this part can be stored in a seperate package, as many systems do > not require chinese translations. Making the ZhConversion.php works

[MediaWiki-CodeReview] [MediaWiki r87125]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87125. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87125#c0 Commit summary: fix return type descriptions ___ MediaWiki-CodeRevie

[MediaWiki-CodeReview] [MediaWiki r87124]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87124. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87124#c0 Commit summary: fix typo ___ MediaWiki-CodeReview mailing list media

[MediaWiki-CodeReview] [MediaWiki r86927]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r86927. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86927#c16420 Commit summary: adding language support to #time parser function, per bug 28655 Comment: It is much clear :D ___ Media

[MediaWiki-CodeReview] [MediaWiki r86775]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Platonides" changed the status of MediaWiki.r86775. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86775#c0 Commit summary: Stop stubbing $wgLang and $wgContLang. There are no major code paths which do not call either $wgLang or $wgContLa

Re: [Wikitech-l] Packaging mediawiki : includes/zhtable

2011-04-29 Thread Philip Tzou
And the new generated ZhConv.php should always be moved to includes/ folder and overwrite the older one. 2011/4/29 Johannes Weberhofer > The other files aren't needed after generation, are they? The > ZhConversion.php should be kept/distributed in includes/zhtable? > > Am 29.04.11 15:05, schrieb

Re: [Wikitech-l] Packaging mediawiki : includes/zhtable

2011-04-29 Thread Philip Tzou
No, the whole folder isn't needed after the generation. You can exclude it and won't break any thing. 2011/4/29 Johannes Weberhofer > The other files aren't needed after generation, are they? The > ZhConversion.php should be kept/distributed in includes/zhtable? > > Am 29.04.11 15:05, schrieb Ph

Re: [Wikitech-l] Packaging mediawiki : includes/zhtable

2011-04-29 Thread Niklas Laxström
On 29 April 2011 14:48, Johannes Weberhofer wrote: > Dear all! > > I'm currently packaging mediawiki (for opensuse), and have a question related > to "includes/zhtable". > > I think, this part can be stored in a seperate package, as many systems do > not require chinese translations. Making the

[MediaWiki-CodeReview] [MediaWiki r87103]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Platonides" changed the status of MediaWiki.r87103. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87103#c0 Commit summary: Rebranching phase3 so the iwtransclusion branch can be reintegrated against a much newer trunk copy (lot less conflict

Re: [Wikitech-l] Packaging mediawiki : includes/zhtable

2011-04-29 Thread Johannes Weberhofer
The other files aren't needed after generation, are they? The ZhConversion.php should be kept/distributed in includes/zhtable? Am 29.04.11 15:05, schrieb Philip Tzou: > It is just a generator of ZhConversion.php. Run makefile.py would generate a > new ZhConversion.php. -- Johannes Weberhofer We

Re: [Wikitech-l] Packaging mediawiki : includes/zhtable

2011-04-29 Thread Philip Tzou
It is just a generator of ZhConversion.php. Run makefile.py would generate a new ZhConversion.php. 2011/4/29 Johannes Weberhofer > Dear all! > > I'm currently packaging mediawiki (for opensuse), and have a question > related to "includes/zhtable". > > I think, this part can be stored in a sepera

[MediaWiki-CodeReview] [MediaWiki r86657]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Dantman" posted a comment on MediaWiki.r86657. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86657#c16419 Commit summary: Added jquery.json library to core. Comment: Both only take 0.0003ms in FF3, no difference. Second one however looks saner code wise.

[Wikitech-l] Packaging mediawiki : includes/zhtable

2011-04-29 Thread Johannes Weberhofer
Dear all! I'm currently packaging mediawiki (for opensuse), and have a question related to "includes/zhtable". I think, this part can be stored in a seperate package, as many systems do not require chinese translations. Making the ZhConversion.php works nicely, but I do not know how to package

[MediaWiki-CodeReview] [MediaWiki r86657]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Fomafix" posted a comment on MediaWiki.r86657. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86657#c16418 Commit summary: Added jquery.json library to core. Comment: What is faster? '\\u00' + Math.floor(c / 16).toString(16) + (c % 16).toString(16) or '\\u' + ('000' + c.

[MediaWiki-CodeReview] [MediaWiki r87006]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Raymond" changed the status of MediaWiki.r87006. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87006#c0 Commit summary: Remove whitespace, unneeded globals, and swap and/or for &&/|| ___ MediaWi

[MediaWiki-CodeReview] [MediaWiki r87119]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r87119. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87119#c0 Commit summary: And now I'm yelled at not fixing typos made by others :) ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r87116]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r87116. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87116#c0 Commit summary: Omg typofix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wi

[MediaWiki-CodeReview] [MediaWiki r87006]: Revision status changed

2011-04-29 Thread MediaWiki Mail
User "Raymond" changed the status of MediaWiki.r87006. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87006#c0 Commit summary: Remove whitespace, unneeded globals, and swap and/or for &&/|| ___ MediaWi

[MediaWiki-CodeReview] [MediaWiki r87006]: New comment added

2011-04-29 Thread MediaWiki Mail
User "Peachey88" posted a comment on MediaWiki.r87006. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87006#c16417 Commit summary: Remove whitespace, unneeded globals, and swap and/or for &&/|| Comment: Bug 28745 - Breaks Cite. ___ Me