[MediaWiki-CodeReview] [MediaWiki r89014]: New comment added

2011-05-28 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89014. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89014#c17259 Commit summary: fixed bug 28993 - Make OpenID extension aware of user deletions done by extension UserMerge and Delete (and probably others). hooks on the new hooks

[MediaWiki-CodeReview] [MediaWiki r89022]: New comment added, and revision status changed

2011-05-28 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89022. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r89022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89022#c17261 Commit summary: Zhee USERINFO file Comment: Please correct your autoprops,

[MediaWiki-CodeReview] [MediaWiki r89021]: New comment added

2011-05-28 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89021. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89021#c17262 Commit summary: Comment: Please use commit summaries! ___ MediaWiki-CodeReview mailing list

[Wikitech-l] Request for comment: New hooks: DeleteAccount and MergeAccountFromTo

2011-05-28 Thread Thomas Gries
Status: http://www.mediawiki.org/wiki/Manual:Hooks/AddNewAccount is currently the only Account-adminstration related hook which changes table user - as far as I can see. Problem (solved yesterday) OpenID needs to be informed when an account is deleted or merged, which currently UserMerge

[MediaWiki-CodeReview] [MediaWiki r88924]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88924. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88924#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-26 20:19:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r80924]: New comment added, and revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r80924. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r80924. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80924#c17263 Commit summary: Integrate what was functionally left of common_rtl.css into

[MediaWiki-CodeReview] [MediaWiki r89014]: New comment added

2011-05-28 Thread MediaWiki Mail
User Wikinaut posted a comment on MediaWiki.r89014. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89014#c17264 Commit summary: fixed bug 28993 - Make OpenID extension aware of user deletions done by extension UserMerge and Delete (and probably others). hooks on the new hooks

[MediaWiki-CodeReview] [MediaWiki r86046]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r86046. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86046#c0 Commit summary: Updating jQuery UI to 1.8.11 (was 1.8.2). Also loosening button css, since j.ui.button works for non button elements as

[MediaWiki-CodeReview] [MediaWiki r86188]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r86188. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86188#c0 Commit summary: Followup to r86047: Fix empty button on pages with only one rev ___

[MediaWiki-CodeReview] [MediaWiki r86854]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r86854. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86854#c0 Commit summary: Followup to r86108: jQuery tries to be too smart and converts the string to a number, which breaks the value parser

[MediaWiki-CodeReview] [MediaWiki r86963]: New comment added

2011-05-28 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r86963. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86963#c17266 Commit summary: * Fix ancient jumpy bug when clicking the hover-triangle (normally nobody does that, but just tried it for screenreader thing, it's been around for

[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added

2011-05-28 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c17267 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName,

[MediaWiki-CodeReview] [MediaWiki r88115]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88115. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88115#c0 Commit summary: (bug 28978) jquery.autoEllipsis cache doesn't take position into account, leads to cache pollution

[MediaWiki-CodeReview] [MediaWiki r88224]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88224. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88224#c0 Commit summary: updating our jquery ui button skin to match changes in jquery.ui.button functionality, per current version in trunk

[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added

2011-05-28 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c17268 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName,

[MediaWiki-CodeReview] [MediaWiki r88660]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88660. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88660#c0 Commit summary: Don't autoreview the current rev when a null (same text) edit is attempted if the current rev is a dummy edit. Such edits

[MediaWiki-CodeReview] [MediaWiki r88625]: New comment added

2011-05-28 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r88625. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88625#c17269 Commit summary: jquery.tabIndex.js was broken, not it works (for the first time?) * Defaulting to null * Setting to initial value during first iteration (instead of

[MediaWiki-CodeReview] [MediaWiki r88755]: New comment added

2011-05-28 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r88755. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88755#c17270 Commit summary: Fixup phpunit tests so we don't drop/create tables on EVERY SINGLE TEST. Now just create them on the first test that needsDB() and skip creation on the

[MediaWiki-CodeReview] [MediaWiki r88794]: New comment added

2011-05-28 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r88794. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88794#c17271 Commit summary: Use $.extend() in mw.util and mw.util.jpegmeta so they can be loaded in either order. This means mw.util.jpegmeta doesn't depend on mw.util loading

[MediaWiki-CodeReview] [MediaWiki r89066]: New comment added

2011-05-28 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r89066. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89066#c17272 Commit summary: added i18n file Comment: Not common to use the secure server: +'url'=

[MediaWiki-CodeReview] [MediaWiki r88796]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88796. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88796#c0 Commit summary: Fix syntax error in r88794 ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Request for comment: New hooks: DeleteAccount and MergeAccountFromTo

2011-05-28 Thread Ryan Lane
As suggested some days ago by Ryan Lane - and I support his view - such hooks should -    go/come via the core, and in consequence -    via Auth. The two hooks should be implemented in core as    abstract public function () or whatever is conformity to our standards (pls. let me know).

[MediaWiki-CodeReview] [MediaWiki r89071]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89071. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89071#c0 Commit summary: ApiBlockTest now remove block it creates This follow up r88755 that make tests depends on each other. The creation of a

[MediaWiki-CodeReview] [MediaWiki r89070]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89070. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89070#c0 Commit summary: Allow test to remove data from the database This new removeDBData() is run after the tests result. It is similar to the

[MediaWiki-CodeReview] [MediaWiki r89069]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89069. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89069#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-28 20:30:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r88755]: New comment added

2011-05-28 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r88755. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88755#c17274 Commit summary: Fixup phpunit tests so we don't drop/create tables on EVERY SINGLE TEST. Now just create them on the first test that needsDB() and skip creation on the

[MediaWiki-CodeReview] [MediaWiki r88755]: New comment added

2011-05-28 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r88755. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88755#c17275 Commit summary: Fixup phpunit tests so we don't drop/create tables on EVERY SINGLE TEST. Now just create them on the first test that needsDB() and skip creation on the

[MediaWiki-CodeReview] [MediaWiki r89071]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89071. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89071#c0 Commit summary: ApiBlockTest now remove block it creates This follow up r88755 that make tests depends on each other. The creation of

[MediaWiki-CodeReview] [MediaWiki r89073]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89073. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89073#c0 Commit summary: Wondering if wfIniGetBool doesn't exist? lol ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89066]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89066. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89066#c0 Commit summary: added i18n file ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89074]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89074. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89074#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-05-28 21:01:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added

2011-05-28 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c17276 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName,

[MediaWiki-CodeReview] [MediaWiki r89013]: New comment added

2011-05-28 Thread MediaWiki Mail
User MarkAHershberger posted a comment on MediaWiki.r89013. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89013#c17277 Commit summary: follow up r88997 with a rough attempt at a parser test, though, really, we can't test signature expansion Comment: great idea patches

[MediaWiki-CodeReview] [MediaWiki r88794]: New comment added, and revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88794. Old Status: new New Status: reverted User Krinkle also posted a comment on MediaWiki.r88794. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88794#c17278 Commit summary: Use $.extend() in mw.util and mw.util.jpegmeta so they

[MediaWiki-CodeReview] [MediaWiki r88796]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88796. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88796#c0 Commit summary: Fix syntax error in r88794 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r83183]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r83183. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83183#c0 Commit summary: Convert Special:BlockIP JS to jQuery/ResourceLoader. Change the order of the checkboxes on the block form so that options

[MediaWiki-CodeReview] [MediaWiki r84384]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r84384. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84384#c0 Commit summary: In $.textSelection, treat input elements differently from other elements (such as textareas and iframes) in IE, seems to

[MediaWiki-CodeReview] [MediaWiki r85616]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r85616. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85616#c0 Commit summary: For bug 27488: move the startup script, jquery+mediawiki and the mw.config.set() call for configuration variables back to

[MediaWiki-CodeReview] [MediaWiki r86861]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r86861. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86861#c0 Commit summary: (bug 24298) Make dropdown menus in Vector more accessible by expanding and collapsing them when the hidden link behind the

[MediaWiki-CodeReview] [MediaWiki r88228]: Revision status changed

2011-05-28 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88228. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88228#c0 Commit summary: further update to skin due to module update, also some margin/padding tweaks to account for formatting differences unique

[MediaWiki-CodeReview] [MediaWiki r78941]: New comment added

2011-05-28 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r78941. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78941#c17280 Commit summary: Porting tocToggle to ResourceLoader * Path is now set to sitewide rather than current path so that it doesn't apply to just the current article but to