[MediaWiki-CodeReview] [MediaWiki r91750]: New comment added, and revision status changed

2011-07-09 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r91750. Old Status: new New Status: fixme User "Nikerabbit" also posted a comment on MediaWiki.r91750. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91750#c19400 Commit summary: r86603 : Updatin last call to mediawiki.legacy.edi

[Wikitech-l] Supporting Extension authors

2011-07-09 Thread Mark A. Hershberger
MediaWiki.org is great for extension authors, as far as it goes. Today, though, someone asked on #mediawiki how to create development branches for their extension in their SVN repo. I told him I didn't think it could be done — that he might have to use the SVN repo as a backend to push to from g

[Wikitech-l] Parser bugs and their priority

2011-07-09 Thread Mark A. Hershberger
Recently, there was a discussion on a bug (“UNIQ key exposed” https://bugzilla.wikimedia.org/14562) about the priority setting I had given the bug. It was part of the problems I found in Bugzilla last December and gathered into a tracking bug (https://bugzilla.wikimedia.org/26213). It looks like

[MediaWiki-CodeReview] [MediaWiki r91804]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r91804. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91804#c19399 Commit summary: Added Request::setLang() and RequestContext::setSkin(); the latter will clone the object and set the context on it. Comment: Bug 29524 should be t

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread Marco Schuster
On Sat, Jul 9, 2011 at 8:51 PM, Håkon Wium Lie wrote: > Opera comes in two flavors for mobile devices: Opera Mini and Opera > Mobile. Opera Mobile is, indeed, close to the desktop version in the > sense that it runs the same display, javascript engine etc. on the > device. The versions of Opera M

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread Håkon Wium Lie
Also sprach Ashar Voultoiz: > Our javascript tests are being run under TestSwarm [1] and we currently > cover up most desktop browsers (thanks brion). > > According to our squids stats [2], most of Wikimedia mobile traffic > comes from the following browsers (sorted by popularity): >-

[MediaWiki-CodeReview] [MediaWiki r91789]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r91789. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91789#c19398 Commit summary: fixed pagination, and added some stubs for form elements Comment: Daily commits are fine, but if you start making a lots of changes it is preferab

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread Ashar Voultoiz
On 09/07/11 18:10, Chad wrote: > I've got Android 2.x and 3.x devices at my house. Unfortunately > TestSwarm doesn't support the newer webkit builds found in > Android 3.1 yet--it tells me it doesn't need my help :( Just like Firefox 5, Krinkle need to update the regex :-) -- Ashar Voultoiz _

[MediaWiki-CodeReview] [MediaWiki r91793]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Devayon" posted a comment on MediaWiki.r91793. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91793#c19397 Commit summary: added form boxes Comment: a follow-up to r91789. ___ MediaWiki-CodeReview mailing list mediawiki-coderev.

[MediaWiki-CodeReview] [MediaWiki r91780]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Devayon" posted a comment on MediaWiki.r91780. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91780#c19396 Commit summary: Style cleanup Comment: a follow-up to r91780 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@l

[MediaWiki-CodeReview] [MediaWiki r91789]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Devayon" posted a comment on MediaWiki.r91789. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91789#c19395 Commit summary: fixed pagination, and added some stubs for form elements Comment: Hi, I see why this seems a mess. I was just incrementally coding this file. I guess

[MediaWiki-CodeReview] [MediaWiki r90206]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Devayon" posted a comment on MediaWiki.r90206. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90206#c19394 Commit summary: follow up to r90202 Comment: Thanks for pointing that out (about follow-ups and late url-encoding) :) The earlier encoding ma

[MediaWiki-CodeReview] [MediaWiki r91789]: New comment added, and revision status changed

2011-07-09 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r91789. Old Status: deferred New Status: fixme User "Nikerabbit" also posted a comment on MediaWiki.r91789. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91789#c19393 Commit summary: fixed pagination, and added some stubs for fo

[MediaWiki-CodeReview] [MediaWiki r91786]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r91786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91786#c19392 Commit summary: Follow-up r91770: only translate when possible Comment: Like I said elsewhere, we should limit the input to predefined ones we can translate. See

[MediaWiki-CodeReview] [MediaWiki r91757]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Jarry1250" posted a comment on MediaWiki.r91757. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91757#c19391 Commit summary: HTMLForm: Add option to output a title for a fieldset & activate it for Special:Pref. Preliminary work for Bug 29672 Comment: Might it be worth pas

[MediaWiki-CodeReview] [MediaWiki r91786]: New comment added

2011-07-09 Thread MediaWiki Mail
User "SPQRobin" posted a comment on MediaWiki.r91786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91786#c19390 Commit summary: Follow-up r91770: only translate when possible Comment: Apparently it does convert it to absolute ones when there is no translation in ipboptions. T

[MediaWiki-CodeReview] [MediaWiki r91770]: New comment added

2011-07-09 Thread MediaWiki Mail
User "SPQRobin" posted a comment on MediaWiki.r91770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91770#c19389 Commit summary: Translate the block expiry date I wonder why this hasn't been done yet... Comment: Apparently no, because there is a check in LogPage that calls $wg

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread Daniel Friesen
On 11-07-09 08:54 AM, Matias wrote: > On Sat, Jul 9, 2011 at 6:30 AM, Ashar Voultoiz wrote: > >> Hello, >> >> Our javascript tests are being run under TestSwarm [1] and we currently >> cover up most desktop browsers (thanks brion). >> >> According to our squids stats [2], most of Wikimedia mobile

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread Chad
On Sat, Jul 9, 2011 at 5:30 AM, Ashar Voultoiz wrote: > * Android : has an emulator. On my computer it is painfully slow and not > usable for anything. > I've got Android 2.x and 3.x devices at my house. Unfortunately TestSwarm doesn't support the newer webkit builds found in Android 3.1 yet--it

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread Matias
On Sat, Jul 9, 2011 at 6:30 AM, Ashar Voultoiz wrote: > Hello, > > Our javascript tests are being run under TestSwarm [1] and we currently > cover up most desktop browsers (thanks brion). > > According to our squids stats [2], most of Wikimedia mobile traffic > comes from the following browsers (

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread Ashar Voultoiz
On 09/07/11 12:36, K. Peachey wrote: > Which is apparently not needed in the tests but I would assume that is > BlackBerry 6? which under rarest mobiles has 0 runs. We probably need to resubmit MW jobs so it ask tests to the mobile browsers. -- Ashar Voultoiz _

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread Ashar Voultoiz
On 09/07/11 12:07, Bryan Tong Minh wrote: .. > Firefox 5 is missing. It is bug 29549. Krinkle need to update testswarm regexp for Gecko 5 :) See: https://bugzilla.wikimedia.org/29549 and upstream: https://github.com/jquery/testswarm/issues/67 -- Ashar Voultoiz _

[MediaWiki-CodeReview] [MediaWiki r91786]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r91786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91786#c19388 Commit summary: Follow-up r91770: only translate when possible Comment: Now it converts relative expressions to absolute ones? ___

[MediaWiki-CodeReview] [MediaWiki r91783]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r91783. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91783#c0 Commit summary: Fix for r91651: don't escape HTML ___ MediaWiki-CodeReview mailing list mediaw

[MediaWiki-CodeReview] [pywikipedia r9341]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9341. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9341#c0 Commit summary: Bugfix: if a noinclude is in the end, the bot will loop forever. Moving the template nld from below to upper part

[MediaWiki-CodeReview] [pywikipedia r9343]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9343. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9343#c0 Commit summary: Start with moving Commons messages to Translatewiki. Still have to import the existing messages.

[MediaWiki-CodeReview] [MediaWiki r91770]: New comment added, and revision status changed

2011-07-09 Thread MediaWiki Mail
User "SPQRobin" changed the status of MediaWiki.r91770. Old Status: fixme New Status: new User "SPQRobin" also posted a comment on MediaWiki.r91770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91770#c19387 Commit summary: Translate the block expiry date I wonder why this hasn

[MediaWiki-CodeReview] [MediaWiki r90206]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Jeroen De Dauw" posted a comment on MediaWiki.r90206. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90206#c19386 Commit summary: follow up to r90202 Comment: Ah, I guess I wasn't careful enough there :) The urlencoding should happen as late as po

[MediaWiki-CodeReview] [MediaWiki r90206]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Devayon" posted a comment on MediaWiki.r90206. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90206#c19385 Commit summary: follow up to r90202 Comment: This commit gives me an odd error. How to replicate: 1) Go to Special:Ask. set Query to [[Located at ::germany]] and lim

[MediaWiki-CodeReview] [pywikipedia r8940]: New comment added, and revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r8940. Old Status: fixme New Status: resolved User "Xqt" also posted a comment on pywikipedia.r8940. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/8940#c19384 Commit summary: remove checks for non-existent InvalidTitle exception C

[MediaWiki-CodeReview] [pywikipedia r8940]: New comment added, and revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r8940. Old Status: new New Status: fixme User "Xqt" also posted a comment on pywikipedia.r8940. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/8940#c19383 Commit summary: remove checks for non-existent InvalidTitle exception Commen

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread K. Peachey
On Sat, Jul 9, 2011 at 7:50 PM, K. Peachey wrote: > On Sat, Jul 9, 2011 at 7:30 PM, Ashar Voultoiz wrote: >> * Blackberry : emulator is Windows only :-/ >> >> Would be great to enhance our testswarm with more browsers. Maybe we >> could contact those mobiles developers to connect to our testswarm

[MediaWiki-CodeReview] [MediaWiki r88054]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Bryan" posted a comment on MediaWiki.r88054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88054#c19382 Commit summary: (bug 23002) Imagelinks table not updated after imagemove. The actual bug was inconsistent behaviour between imagelinks and pagelinks for redirects. * Par

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread Bryan Tong Minh
On Sat, Jul 9, 2011 at 11:30 AM, Ashar Voultoiz wrote: > Hello, > > Our javascript tests are being run under TestSwarm [1] and we currently > cover up most desktop browsers (thanks brion). > Firefox 5 is missing. Bryan ___ Wikitech-l mailing list Wiki

[MediaWiki-CodeReview] [pywikipedia r9336]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9336. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9336#c0 Commit summary: Two more German nowcommons templates. ___ MediaWiki-CodeReview mailing list med

[MediaWiki-CodeReview] [pywikipedia r9335]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9335. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9335#c0 Commit summary: Some more templates to skip and source garbage to remove. ___ MediaWiki-CodeRev

[MediaWiki-CodeReview] [pywikipedia r9334]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9334. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9334#c0 Commit summary: Add autonomous option. ___ MediaWiki-CodeReview mailing list mediawiki-coderev.

[MediaWiki-CodeReview] [pywikipedia r9333]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9333. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9333#c0 Commit summary: Implement 2 more information fields. ___ MediaWiki-CodeReview mailing list medi

Re: [Wikitech-l] testing mobile browsers?

2011-07-09 Thread K. Peachey
On Sat, Jul 9, 2011 at 7:30 PM, Ashar Voultoiz wrote: > * Blackberry : emulator is Windows only :-/ > > Would be great to enhance our testswarm with more browsers. Maybe we > could contact those mobiles developers to connect to our testswarm? > > :-) I'm grabbing the BB emulator (BlackBerry® Devic

[MediaWiki-CodeReview] [pywikipedia r9332]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9332. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9332#c0 Commit summary: Move Tkdialog down. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@

[MediaWiki-CodeReview] [pywikipedia r9331]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9331. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9331#c0 Commit summary: Change to dictionaries. ___ MediaWiki-CodeReview mailing list mediawiki-coderev

[MediaWiki-CodeReview] [pywikipedia r9330]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9330. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9330#c0 Commit summary: Put remarks after the description ___ MediaWiki-CodeReview mailing list mediawi

[MediaWiki-CodeReview] [pywikipedia r9290]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9290. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9290#c0 Commit summary: fix r9289 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wiki

[MediaWiki-CodeReview] [pywikipedia r9310]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9310. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9310#c0 Commit summary: disambiguation template for tr:, disambiguation category for nds-nl: ___ MediaW

[MediaWiki-CodeReview] [pywikipedia r9326]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9326. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9326#c0 Commit summary: Modified the bot to be able to work on other languages too. Currently the bot works on de, en & nds-nl. __

[MediaWiki-CodeReview] [pywikipedia r9327]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9327. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9327#c0 Commit summary: Forgot to delete imagecopy_enwp.py a while ago. Moved to imagecopy_self.py ___

[MediaWiki-CodeReview] [pywikipedia r9319]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9319. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9319#c0 Commit summary: add another null-edit step, to address false-positives in non-empty category listings

[MediaWiki-CodeReview] [pywikipedia r9315]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9315. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9315#c0 Commit summary: Regex fix so that the regex also works for Wiki's with non alfanumerical chars (like nds-nl).

[MediaWiki-CodeReview] [pywikipedia r9325]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Xqt" posted a comment on pywikipedia.r9325. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9325#c19381 Commit summary: Re-add fuzzified translations Comment: Follow-up for r9324 (hm, i guess Associate button follow-up revision doesn't works anymore) ___

[MediaWiki-CodeReview] [pywikipedia r9324]: Revision status changed

2011-07-09 Thread MediaWiki Mail
User "Xqt" changed the status of pywikipedia.r9324. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9324#c0 Commit summary: Localisation updates from http://translatewiki.net. ___ MediaWiki-CodeReview ma

[MediaWiki-CodeReview] [pywikipedia r9324]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Xqt" posted a comment on pywikipedia.r9324. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9324#c19380 Commit summary: Localisation updates from http://translatewiki.net. Comment: Fuzzy changes for 'category-adding' was lost. Re-added in r9325. _

[Wikitech-l] testing mobile browsers?

2011-07-09 Thread Ashar Voultoiz
Hello, Our javascript tests are being run under TestSwarm [1] and we currently cover up most desktop browsers (thanks brion). According to our squids stats [2], most of Wikimedia mobile traffic comes from the following browsers (sorted by popularity): - Safari - Android - Opera - Mo

[MediaWiki-CodeReview] [MediaWiki r90812]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r90812. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90812#c19379 Commit summary: Removing console.log and other ad-hoc debugging code Comment: mediawiki.action.history not merged in 1.18 :b _

[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19378 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as

Re: [Wikitech-l] all those zeros in tables in text brosers

2011-07-09 Thread Niklas Laxström
On 9 July 2011 06:58, Ilmari Karonen wrote: > On 07/09/2011 06:25 AM, Chad wrote: >> On Fri, Jul 8, 2011 at 11:23 PM,  wrote: >>> Sure you can say "not a MediaWiki problem, go contact the website", but >>> if MediaWiki gave them the proper tools to make their templates, they >>> wouldn't need to m

[MediaWiki-CodeReview] [MediaWiki r91776]: New comment added

2011-07-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r91776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91776#c19377 Commit summary: start special page for viewing archived content. Comment: Inclusion protector is not needed for files which only contain a class. +if (!defined('M

[MediaWiki-CodeReview] [MediaWiki r91770]: New comment added, and revision status changed

2011-07-09 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r91770. Old Status: new New Status: fixme User "Nikerabbit" also posted a comment on MediaWiki.r91770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91770#c19376 Commit summary: Translate the block expiry date I wonder why this

[MediaWiki-CodeReview] [MediaWiki r91677]: New comment added

2011-07-09 Thread MediaWiki Mail
User "IAlex" posted a comment on MediaWiki.r91677. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91677#c19375 Commit summary: * Fixed comment * Wrap arround RequestContext::msg() instead of doing that all that stuff once more Comment: This is done in R