[MediaWiki-CodeReview] [MediaWiki r95625]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Xqt" posted a comment on MediaWiki.r95625. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95625#c21575 Commit summary: Plural rules for pywikipedia based on r95194 of plural-gettext.txt Comment: I did it by hand. I don't believe there are many changes. I moved the code to

[MediaWiki-CodeReview] [MediaWiki r95646]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r95646. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95646#c21574 Commit summary: In Language::isValidBuiltInCode(), reject the empty string per Nikerabbit's request on CR r82927. I'm not sure what the reason for the request was,

[MediaWiki-CodeReview] [MediaWiki r95647]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r95647. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95647#c21573 Commit summary: * Fix for r90643: in the case where there is only one server, implying no replication, make LoadBalancer::getLagTimes(), LoadMonitor_MySQL::getLag

[MediaWiki-CodeReview] [MediaWiki r90643]: New comment added, and revision status changed

2011-08-28 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r90643. Old Status: fixme New Status: new User "Tim Starling" also posted a comment on MediaWiki.r90643. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90643#c21572 Commit summary: General database-related code cleanup: * Merge

Re: [Wikitech-l] Removing * {{msg}} support from MediaWiki:Sidebar

2011-08-28 Thread Daniel Friesen
- Horrible syntax becomes even more horrid - i18n nearly goes out the window - Accesskeys go out the window - External links don't work the same in the sidebar as they do in WikiText - Sidebar markup differs between skins... because rightfully that's the skin's decision to make on how it's laid ou

Re: [Wikitech-l] Removing * {{msg}} support from MediaWiki:Sidebar

2011-08-28 Thread jidanni
> "C" == Chad writes: C> Why on earth would we call it the snidebar? OK, spudbar. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r87482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c21571 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak.

[MediaWiki-CodeReview] [MediaWiki r85327]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r85327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c21570 Commit summary: The beginnings of HipHop compiled mode support. It works now for parser cache hits. * Work around HipHop issue 314 (volatile broken) and issue 30

[MediaWiki-CodeReview] [MediaWiki r82927]: New comment added, and revision status changed

2011-08-28 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r82927. Old Status: fixme New Status: new User "Tim Starling" also posted a comment on MediaWiki.r82927. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82927#c21569 Commit summary: Followup for r81340: * Allow any language code

[Wikitech-l] Bugzilla Weekly Report

2011-08-28 Thread reporter
MediaWiki Bugzilla Report for August 22, 2011 - August 29, 2011 Status changes this week Bugs NEW : 152 Bugs ASSIGNED : 17 Bugs REOPENED : 37 Bugs RESOLVED

[MediaWiki-CodeReview] [MediaWiki r94461]: New comment added

2011-08-28 Thread MediaWiki Mail
User "MZMcBride" posted a comment on MediaWiki.r94461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94461#c21568 Commit summary: Fix r94429 : Left and right side are still nearly the same color for 7% of the population. When I wrote to the list a while ago, no one argued for ke

[MediaWiki-CodeReview] [MediaWiki r94461]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Johnduhart" posted a comment on MediaWiki.r94461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94461#c21567 Commit summary: Fix r94429 : Left and right side are still nearly the same color for 7% of the population. When I wrote to the list a while ago, no one argued for k

[MediaWiki-CodeReview] [MediaWiki r94350]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Johnduhart" posted a comment on MediaWiki.r94350. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94350#c21566 Commit summary: Fix r91886 thanks to johnduhart: check if it is an IP *before* stripping subpages, otherwise IP range blocking does not work Comment: Can we remov

Re: [Wikitech-l] Removing * {{msg}} support from MediaWiki:Sidebar

2011-08-28 Thread Chad
Why on earth would we call it the snidebar? -Chad On Aug 28, 2011 9:45 PM, wrote: > Why don't you guys just make MediaWiki:Sidebar just be (interpreted as) > a standard wikitext file. OK, call it MediaWiki:SidebarII or > MediaWiki:Snidebar etc., which if exists will be used instead of > MediaWiki

Re: [Wikitech-l] Removing * {{msg}} support from MediaWiki:Sidebar

2011-08-28 Thread jidanni
Why don't you guys just make MediaWiki:Sidebar just be (interpreted as) a standard wikitext file. OK, call it MediaWiki:SidebarII or MediaWiki:Snidebar etc., which if exists will be used instead of MediaWiki:Sidebar. ___ Wikitech-l mailing list Wikitech-

Re: [Wikitech-l] please smoketest Kiwix on Ubuntu Linux

2011-08-28 Thread Mark A. Hershberger
Sumana Harihareswara writes: > Can someone on Ubuntu install Kiwix 0.9 beta2 via the Ubuntu PPA and > verify that it launches? http://www.kiwix.org/index.php/Ubuntu_PPA has > the directions -- ppa:kiwixteam/ppa is the repository, as you can see on > https://launchpad.net/~kiwixteam/+archive/ppa

Re: [Wikitech-l] 1.18 code review status

2011-08-28 Thread Platonides
On 28/08/11 17:49, Ashar Voultoiz wrote: > On 28/08/11 03:20, Brion Vibber wrote: >> What that really needs is test cases! >> >> Not sure how easy to wrangle though... > > OCaml has an implementation for unit testing. I have spend a bit of time > on it and eventually gave up since: >- I lack Oc

Re: [Wikitech-l] svn tip: how to undo changes using svn merge -c -revisionnumber --dry-run .

2011-08-28 Thread Platonides
Great gem, Hashar! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r95617]: Revision status changed

2011-08-28 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r95617. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95617 Commit summary: MFT r95616 to 1.18: autoloader fix ___ MediaWiki-CodeReview mailing list medi

[MediaWiki-CodeReview] [MediaWiki r95616]: Revision status changed

2011-08-28 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r95616. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95616 Commit summary: Fix autoloader entry from r90929 ___ MediaWiki-CodeReview mailing list mediaw

[MediaWiki-CodeReview] [MediaWiki r95615]: Revision status changed

2011-08-28 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r95615. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95615 Commit summary: Maintenance and FakeMaintenance were not registered in AutoLoader in 1.17, causing fatals per report on support desk ___

[MediaWiki-CodeReview] [MediaWiki r94325]: Revision status changed

2011-08-28 Thread MediaWiki Mail
User "Hashar" changed the status of MediaWiki.r94325. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94325 Commit summary: Apply lowerCamelCase to files for constructors as well. (Follows-up r94230) ___ M

[MediaWiki-CodeReview] [MediaWiki r95601]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r95601. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95601#c21565 Commit summary: replace WfDie() Comment: readding 1.18. I did not merge it since I lack the time to resolve the conflict.

[MediaWiki-CodeReview] [MediaWiki r47570]: New comment added, and revision status changed

2011-08-28 Thread MediaWiki Mail
User "Happy-melon" changed the status of MediaWiki.r47570. Old Status: resolved New Status: reverted User "Happy-melon" also posted a comment on MediaWiki.r47570. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/47570#c21564 Commit summary: Needs rights-reset-password msg. Commen

[MediaWiki-CodeReview] [MediaWiki r95597]: New comment added, and revision status changed

2011-08-28 Thread MediaWiki Mail
User "Happy-melon" changed the status of MediaWiki.r95597. Old Status: new New Status: ok User "Happy-melon" also posted a comment on MediaWiki.r95597. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95597#c21563 Commit summary: Remove a message for a feature introduced with r475

[MediaWiki-CodeReview] [MediaWiki r79941]: New comment added

2011-08-28 Thread MediaWiki Mail
User "TheDJ" posted a comment on MediaWiki.r79941. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79941#c21562 Commit summary: Follow up to r79905. Disabling resource inclusion of LQT api. Don't know how to fix this properly, seems undocumented for Resourceloader. Comment: I co

[MediaWiki-CodeReview] [MediaWiki r95014]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r95014. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95014#c21561 Commit summary: Use getInternalUrl() instead of getFullUrl() in purgeList.php . This was potentially a serious bug if $wgServer differed from $wgInternalServer in comm

[MediaWiki-CodeReview] [MediaWiki r95014]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r95014. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95014#c21560 Commit summary: Use getInternalUrl() instead of getFullUrl() in purgeList.php . This was potentially a serious bug if $wgServer differed from $wgInternalServer in comm

[MediaWiki-CodeReview] [MediaWiki r84258]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Happy-melon" posted a comment on MediaWiki.r84258. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84258#c21559 Commit summary: More cleanup in Block.php. Push Block::encodeExpiry() and Block::decodeExpiry() deeper into the callstack, to DatabaseBase for encode and Languag

[MediaWiki-CodeReview] [MediaWiki r95589]: New comment added

2011-08-28 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r95589. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95589#c21558 Commit summary: Add warning to class header. Comment: Oh well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@

Re: [Wikitech-l] 1.18 code review status

2011-08-28 Thread Ashar Voultoiz
On 28/08/11 03:20, Brion Vibber wrote: > What that really needs is test cases! > > Not sure how easy to wrangle though... OCaml has an implementation for unit testing. I have spend a bit of time on it and eventually gave up since: - I lack Ocaml skill. - our math code is not commented The te

Re: [Wikitech-l] svn tip: how to undo changes using svn merge -c -revisionnumber --dry-run .

2011-08-28 Thread Ashar Voultoiz
On 28/08/11 11:52, Thomas Gries wrote: > I added a section > > http://www.mediawiki.org/wiki/Subversion#Undoing_changes > > with some tips how to efficiently use "svn merge" to undo changes, > especially how to undo a specific changeset. It is a good tip. Another one, is to use 'colordiff' before

[MediaWiki-CodeReview] [MediaWiki r93384]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r93384. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93384#c21557 Commit summary: fu r92413 Comment: untagging 1.18, there is no such file in 1.18 :-) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95340]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r95340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95340#c21556 Commit summary: * (bug 30485) Fixed interference between wikihiero extension and 'wikitable' class style Border & padding settings from the .wikitable class were overr

[MediaWiki-CodeReview] [MediaWiki r95589]: New comment added

2011-08-28 Thread MediaWiki Mail
User "MZMcBride" posted a comment on MediaWiki.r95589. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95589#c21555 Commit summary: Add warning to class header. Comment: In addition to "Sugeon", "prologned". ___ MediaWiki-CodeReview ma

[MediaWiki-CodeReview] [MediaWiki r95625]: New comment added

2011-08-28 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r95625. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95625#c21554 Commit summary: Plural rules for pywikipedia based on r95194 of plural-gettext.txt Comment: Do you have a script or did you convert them by hand?

Re: [Wikitech-l] divergence in commit review backlog statistics for trunk

2011-08-28 Thread MZMcBride
Sumana Harihareswara wrote: > I'd like an accurate, visually pleasing way to count how many unreviewed > revisions there are in trunk, for when I'm encouraging volunteer code > review. TL;DR version: it would be great if someone fixed up RobLa's > chart, corrected its errors, and put a chart gener

[MediaWiki-CodeReview] [MediaWiki r95491]: Revision status changed

2011-08-28 Thread MediaWiki Mail
User "VasilievVV" changed the status of MediaWiki.r95491. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95491 Commit summary: Commiting the initial revision of the native WikiScripts parser. It is right now fully functional, but has no interf

Re: [Wikitech-l] divergence in commit review backlog statistics for trunk

2011-08-28 Thread Roan Kattouw
On Sun, Aug 28, 2011 at 2:55 AM, Sumana Harihareswara wrote: > I'd like an accurate, visually pleasing way to count how many unreviewed > revisions there are in trunk, for when I'm encouraging volunteer code > review.  TL;DR version: it would be great if someone fixed up RobLa's > chart, corrected

[Wikitech-l] svn tip: how to undo changes using svn merge -c -revisionnumber --dry-run .

2011-08-28 Thread Thomas Gries
I added a section http://www.mediawiki.org/wiki/Subversion#Undoing_changes with some tips how to efficiently use "svn merge" to undo changes, especially how to undo a specific changeset. In addition, a hint was added how the "svn merge ... --dry-run" option can avoid headaches before doin