Re: [Wikitech-l] Can we make the life of extension developers easier?

2011-09-07 Thread Rob Lanphier
On Tue, Sep 6, 2011 at 2:05 PM, Brion Vibber br...@pobox.com wrote: Generally speaking, we should only throw warnings or remove old interfaces that are actively broken (do not work correctly) or can no longer be sanely maintained -- removing a deprecated interface is a fairly extreme step and

[MediaWiki-CodeReview] [MediaWiki r96403]: New comment added

2011-09-07 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r96403. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96403#c22014 Commit summary: Move the vector styles for the user login form into commonContent.css The vector styles are very generic and fit well as the common style. With a minor

[MediaWiki-CodeReview] [MediaWiki r96403]: New comment added

2011-09-07 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r96403. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96403#c22015 Commit summary: Move the vector styles for the user login form into commonContent.css The vector styles are very generic and fit well as the common style. With a minor

Re: [Wikitech-l] UploadWizard Triage

2011-09-07 Thread Strainu
Hi Mark, If a bug was marked as Unprioritized, does that mean that it won't be discussed in the triage? Thanks, Strainu 2011/9/7 Mark A. Hershberger mhershber...@wikimedia.org:    What:  UploadWizard bug triage    When:  Wednesday, Sept 7, 19:00UTC           Time zone conversion:

[Wikitech-l] Welcoming our Internationalization/Localization Features Engineering team

2011-09-07 Thread Alolita Sharma
Hi Everyone, Please join me in welcoming our newly formed Internationalization/Localization (I18n/L10n) features engineering team. The I18n/L10n team will focus on design and development of open source tools to improve screen font rendering on web browsers using open web fonts, input method tools

[MediaWiki-CodeReview] [MediaWiki r89525]: New comment added

2011-09-07 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r89525. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89525#c22016 Commit summary: Replace the text directly instead of using the StripState object since it will be unstripped just after the call replaceTransparentTags(), but left the

[MediaWiki-CodeReview] [MediaWiki r96378]: New comment added

2011-09-07 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96378. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96378#c22017 Commit summary: Fix parse error in r96275 Comment: I had to scratch my head a while what error could be in that diff, before I looked the referenced revision.

[MediaWiki-CodeReview] [MediaWiki r96399]: New comment added

2011-09-07 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96399. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96399#c22021 Commit summary: restore proper operation of getArchive{Path|Url} Comment: Is it just me or is getArchivePath never used except in tests?

[MediaWiki-CodeReview] [MediaWiki r96408]: New comment added

2011-09-07 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96408#c22022 Commit summary: * Use static methods instead of an extension function to create an object and set the hooks * Always declare $wgHidensNamespaces to avoid

[MediaWiki-CodeReview] [MediaWiki r96405]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96405. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96405 Commit summary: Per r90858 CR, throw MW exception on missing title context ___

[MediaWiki-CodeReview] [MediaWiki r96407]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96407. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96407 Commit summary: r96267: add the IP address parameter to the message ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96186]: New comment added

2011-09-07 Thread MediaWiki Mail
User Junaidpv posted a comment on MediaWiki.r96186. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96186#c22023 Commit summary: Refactor the code for building the menu to buildMenu. Comment: Done: r96186. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96186]: New comment added

2011-09-07 Thread MediaWiki Mail
User Junaidpv posted a comment on MediaWiki.r96186. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96186#c22024 Commit summary: Refactor the code for building the menu to buildMenu. Comment: Sorry. it is r96412. ___

[MediaWiki-CodeReview] [MediaWiki r96400]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22025 Commit summary: Fix for total extension breakage due to protocol relative URLs Comment: What breaks, exactly? I looked over all uses of code$url/code (in trunk,

[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r91123. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c22026 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields are

[MediaWiki-CodeReview] [MediaWiki r96411]: New comment added, and revision status changed

2011-09-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96411. Old Status: new New Status: ok User Reedy also posted a comment on MediaWiki.r96411. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96411#c22027 Commit summary: Removed old constants: 1) not used 2) because of autoloader, they

Re: [Wikitech-l] Can we make the life of extension developers easier?

2011-09-07 Thread Russell N. Nelson - rnnelson
On the other hand, if you never clean up cruft, you advance the date at which a rewrite from scratch becomes necessary. Code which hasn't had the entropy removed becomes brittle and hard to understand. Sent from my Verizon Wireless Phone -Original message- From: Rob Lanphier

[MediaWiki-CodeReview] [MediaWiki r96400]: New comment added

2011-09-07 Thread MediaWiki Mail
User Peachey88 posted a comment on MediaWiki.r96400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22028 Commit summary: Fix for total extension breakage due to protocol relative URLs Comment: There was some discussion about it earlier today in -tech about the breakage

[MediaWiki-CodeReview] [MediaWiki r96397]: New comment added

2011-09-07 Thread MediaWiki Mail
User Svemir Brkic posted a comment on MediaWiki.r96397. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96397#c22029 Commit summary: Removing files and globals that will not be needed in version 0.8 SphinxMWSeach is now the default mode of operation Use 127.0.0.1 instead of

[MediaWiki-CodeReview] [MediaWiki r96398]: New comment added

2011-09-07 Thread MediaWiki Mail
User Svemir Brkic posted a comment on MediaWiki.r96398. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96398#c22030 Commit summary: Did you mean functionality now has three modes: enchant, soundex, aspell (command-line aspell support copied from old version of the extension, for

[MediaWiki-CodeReview] [MediaWiki r96415]: New comment added

2011-09-07 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96415. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96415#c22031 Commit summary: Applying workaround locally within the extension Narayam for webkit browsers as reported in bug 30130. Should be removed this fix when it is handled

[MediaWiki-CodeReview] [MediaWiki r94212]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r94212. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94212 Commit summary: (bug 30192) Old thumbnails not properly purged. Unlike the bug suggests, we don't need to also purge from

[MediaWiki-CodeReview] [MediaWiki r96399]: New comment added

2011-09-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r96399. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96399#c22032 Commit summary: restore proper operation of getArchive{Path|Url} Comment: Seems to be used in the WikiSync extension ___

[MediaWiki-CodeReview] [MediaWiki r87284]: New comment added

2011-09-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r87284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87284#c22033 Commit summary: This update fixes bug 27324 by loading the eurosym package to provide the euro symbol. This requires the eurosym package be available in the installed

[MediaWiki-CodeReview] [MediaWiki r87284]: New comment added

2011-09-07 Thread MediaWiki Mail
User Thelema314 posted a comment on MediaWiki.r87284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87284#c22034 Commit summary: This update fixes bug 27324 by loading the eurosym package to provide the euro symbol. This requires the eurosym package be available in the

[MediaWiki-CodeReview] [MediaWiki r87284]: New comment added

2011-09-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r87284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87284#c22035 Commit summary: This update fixes bug 27324 by loading the eurosym package to provide the euro symbol. This requires the eurosym package be available in the installed

[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added, and revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91123. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r91123. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c22036 Commit summary: * Split off WikiPage class from Article, WikiFilePage class

[MediaWiki-CodeReview] [MediaWiki r96420]: New comment added

2011-09-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r96420. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96420#c22037 Commit summary: Add constant Linker::TOOL_LINKS_EMAIL to allow adding a send e-mail link from Linker:: Add send e-mail link in user tools for developer details

[MediaWiki-CodeReview] [MediaWiki r96327]: New comment added

2011-09-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r96327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96327#c22038 Commit summary: * (bug 29292) Wall of shame per path Paths will probably want de-regexifying Comment: \o/ ___

[MediaWiki-CodeReview] [MediaWiki r91159]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r91159. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159#c22039 Commit summary: Expand on r91123 Article refactoring: * Added $user param to relevant WikiPage functions (with b/c) * Cleaned up editUpdates() signature and tweaked

[MediaWiki-CodeReview] [MediaWiki r96421]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r96421. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96421 Commit summary: Revert file removal from r96413 and add $wgExtensionAliasesFiles so SphinxSearch.alias.php is used. Revert r96419

[MediaWiki-CodeReview] [MediaWiki r96420]: New comment added

2011-09-07 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96420. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96420#c22040 Commit summary: Add constant Linker::TOOL_LINKS_EMAIL to allow adding a send e-mail link from Linker:: Add send e-mail link in user tools for developer details

[MediaWiki-CodeReview] [MediaWiki r91162]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91162. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91162 Commit summary: * Fixes for r91123: ** Avoid calling protected pageDataFromId() from Article class. ** Made

[MediaWiki-CodeReview] [MediaWiki r91159]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91159. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159 Commit summary: Expand on r91123 Article refactoring: * Added $user param to relevant WikiPage functions (with b/c) * Cleaned up

[MediaWiki-CodeReview] [MediaWiki r91327]: New comment added, and revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91327. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r91327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91327#c22041 Commit summary: * Fixed getLatest() check in Article * Added

[MediaWiki-CodeReview] [MediaWiki r95655]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r95655. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95655 Commit summary: * (bug 16428) Include permalink in printable version ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r95655]: New comment added

2011-09-07 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r95655. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95655#c22043 Commit summary: * (bug 16428) Include permalink in printable version Comment: Fixed with r96427 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r95043]: New comment added

2011-09-07 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r95043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c22044 Commit summary: line numbers and better style * new system to parse the diff, see parseLine() dispatcher. * show lines numbering for each chunk. * tweak style to

[MediaWiki-CodeReview] [MediaWiki r96424]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96424. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96424 Commit summary: Break some tests intentionally to see how Jenkins displays that ___

[MediaWiki-CodeReview] [MediaWiki r96418]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96418. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96418 Commit summary: work on survey admin ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r94951]: New comment added

2011-09-07 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r94951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#c22045 Commit summary: new method to parse chunk delimiters Their format is a one liner: @@ -l,s +l,s @@ See http://en.wikipedia.org/wiki/Diff#Unified_format Comment: br /

[MediaWiki-CodeReview] [MediaWiki r93093]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r93093. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93093 Commit summary: Follow-up r79518: added getCachedLastEditTime/getCachedLastEditTime methods to WikiPage and check them in

[MediaWiki-CodeReview] [MediaWiki r96427]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96427. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96427 Commit summary: Fix r95655 per Formfix's CR: * use getCanonicalURL() - this part should be deployed to 1.17wmf1 * Do not show oldid= in case

[MediaWiki-CodeReview] [MediaWiki r95458]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r95458. Old Status: ok New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95458 Commit summary: New maintenance script for refreshing image metadata (refreshImageMetadata.php) This is very similar to rebuildImages.php,

[MediaWiki-CodeReview] [MediaWiki r96426]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96426. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96426 Commit summary: Some comment and whitespace fixes ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96429]: New comment added, and revision status changed

2011-09-07 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r96429. Old Status: new New Status: fixme User Siebrand also posted a comment on MediaWiki.r96429. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96429#c22046 Commit summary: Add send e-mail link on Special:Userrights and replace

[MediaWiki-CodeReview] [MediaWiki r95458]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r95458. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95458 Commit summary: New maintenance script for refreshing image metadata (refreshImageMetadata.php) This is very similar to rebuildImages.php,

Re: [Wikitech-l] Can we make the life of extension developers easier?

2011-09-07 Thread Roan Kattouw
On Wed, Sep 7, 2011 at 3:39 PM, Sumana Harihareswara suma...@wikimedia.org wrote: On 9/7/11, Russell N. Nelson - rnnelson rnnel...@clarkson.edu wrote: Thank you for contributing emptiness? Roan Kattouw (Catrope) ___ Wikitech-l mailing list

[MediaWiki-CodeReview] [MediaWiki r96429]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r96429. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96429 Commit summary: Add send e-mail link on Special:Userrights and replace the manual tool links in the process.

[MediaWiki-CodeReview] [MediaWiki r96400]: New comment added

2011-09-07 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r96400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22047 Commit summary: Fix for total extension breakage due to protocol relative URLs Comment: URLs like //commons.wikimedia.org//upload.wikimedia.org/something were

[MediaWiki-CodeReview] [MediaWiki r96400]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22048 Commit summary: Fix for total extension breakage due to protocol relative URLs Comment: Hmm, right. Is PROTO_CURRENT safe to use in this case, from a cache pollution

[MediaWiki-CodeReview] [MediaWiki r96400]: New comment added

2011-09-07 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r96400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22049 Commit summary: Fix for total extension breakage due to protocol relative URLs Comment: The HTML will be saved into the parser cache, so I suppose it is not safe

[MediaWiki-CodeReview] [MediaWiki r96434]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r96434. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96434 Commit summary: Correct fallback from Malayalam (ml) to Malay (ms) for Dusun (dtp) spoken in Malaysia

[MediaWiki-CodeReview] [MediaWiki r96411]: New comment added

2011-09-07 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96411. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96411#c22050 Commit summary: Removed old constants: 1) not used 2) because of autoloader, they have not necessarily even been available for long time. Comment: Sweet sixteen...

[MediaWiki-CodeReview] [MediaWiki r96413]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96413. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96413 Commit summary: remove unused alias file always set the autoload array ___

[MediaWiki-CodeReview] [MediaWiki r96414]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96414. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96414 Commit summary: use $wgLanguageCode for aspell dictionary (user language option is about the interface, not content)

[MediaWiki-CodeReview] [MediaWiki r96416]: New comment added

2011-09-07 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96416. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96416#c22051 Commit summary: Documentation Add explicit member variables Trim trailing whitespace Comment: Is there IDE that takes advantages of these annotations?

[MediaWiki-CodeReview] [MediaWiki r96417]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96417. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96417 Commit summary: Some white space business and comment edits. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r96419]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96419. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96419 Commit summary: Remove alias file per r96413 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96416]: New comment added

2011-09-07 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r96416. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96416#c22052 Commit summary: Documentation Add explicit member variables Trim trailing whitespace Comment: NetBeans does, and I'm sure it's not alone. Plus, it makes the doxygen

[MediaWiki-CodeReview] [MediaWiki r96416]: New comment added

2011-09-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r96416. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96416#c22053 Commit summary: Documentation Add explicit member variables Trim trailing whitespace Comment: Yeah, part of the reason for adding them. Objects of known types then can

[MediaWiki-CodeReview] [MediaWiki r95043]: New comment added

2011-09-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r95043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c22054 Commit summary: line numbers and better style * new system to parse the diff, see parseLine() dispatcher. * show lines numbering for each chunk. * tweak style to replace

[MediaWiki-CodeReview] [MediaWiki r96420]: New comment added

2011-09-07 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96420. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96420#c22055 Commit summary: Add constant Linker::TOOL_LINKS_EMAIL to allow adding a send e-mail link from Linker:: Add send e-mail link in user tools for developer details

[MediaWiki-CodeReview] [MediaWiki r96422]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96422. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96422 Commit summary: Oops. Revert r96421 which reverted r96413 and r96419. SphinxSearch once was a special page, but apparently no longer. Was

[MediaWiki-CodeReview] [MediaWiki r96425]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96425. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96425 Commit summary: Fixed handling for MW 1.18+ - $wgOut-getBottomScripts() now called if it exists

[MediaWiki-CodeReview] [MediaWiki r96429]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96429. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96429 Commit summary: Add send e-mail link on Special:Userrights and replace the manual tool links in the process.

[MediaWiki-CodeReview] [MediaWiki r96400]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22057 Commit summary: Fix for total extension breakage due to protocol relative URLs Comment: Hmm. I'll hack up a quick patch that makes the URL saved in the parser cache

[MediaWiki-CodeReview] [MediaWiki r96400]: New comment added

2011-09-07 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r96400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22058 Commit summary: Fix for total extension breakage due to protocol relative URLs Comment: I'm not sure why you think Michael Dale is the relevant authority on the

[MediaWiki-CodeReview] [MediaWiki r96400]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22059 Commit summary: Fix for total extension breakage due to protocol relative URLs Comment: I stand corrected then :D ___

Re: [Wikitech-l] Sep11 Wiki

2011-09-07 Thread Brion Vibber
Woohoo! Thanks :) -- brion On Sep 6, 2011 10:51 PM, Ariel T. Glenn ar...@wikimedia.org wrote: Στις 06-09-2011, ημέρα Τρι, και ώρα 17:07 -0700, ο/η Brion Vibber έγραψε: snip Indeed -- as long as the data's accessible I'm content enough -

Re: [Wikitech-l] Welcoming our Internationalization/Localization Features Engineering team

2011-09-07 Thread Ashar Voultoiz
On 07/09/11 09:10, Alolita Sharma wrote: The members on this team are Siebrand Mazeland as product manager, Niklas Laxström and Santhosh Thottingal as software engineers, and Gerard Meijssen as technology outreach consultant. Welcome! :-] -- Ashar Voultoiz

[MediaWiki-CodeReview] [MediaWiki r87498]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r87498. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87498#c22060 Commit summary: Fixes ForeignDBRepo SQL server connection. Fixes bug #28836. Comment: ... but the rev was merged to 1.17 anyway. WHOOPS. Re-tagging 1.17

[MediaWiki-CodeReview] [MediaWiki r95043]: New comment added

2011-09-07 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r95043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c22061 Commit summary: line numbers and better style * new system to parse the diff, see parseLine() dispatcher. * show lines numbering for each chunk. * tweak style to

[MediaWiki-CodeReview] [MediaWiki r95043]: New comment added

2011-09-07 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r95043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c22062 Commit summary: line numbers and better style * new system to parse the diff, see parseLine() dispatcher. * show lines numbering for each chunk. * tweak style to

[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added

2011-09-07 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91123. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c22063 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields are

[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r91123. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c22064 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields are

Re: [Wikitech-l] Welcoming our Internationalization/Localization Features Engineering team

2011-09-07 Thread Danese Cooper
Glad to see this plan proceeding. Congrats, all. Danese On Wed, Sep 7, 2011 at 12:10 AM, Alolita Sharma asha...@wikimedia.orgwrote: Hi Everyone, Please join me in welcoming our newly formed Internationalization/Localization (I18n/L10n) features engineering team. The I18n/L10n team will

Re: [Wikitech-l] Welcoming our Internationalization/Localization Features Engineering team

2011-09-07 Thread Jeroen De Dauw
On 07/09/11 09:10, Alolita Sharma wrote: The members on this team are Siebrand Mazeland as product manager, Niklas Laxström and Santhosh Thottingal as software engineers, and Gerard Meijssen as technology outreach consultant. Awesome! Congrats to all :) -- Jeroen De Dauw http://www.bn2vs.com

[MediaWiki-CodeReview] [MediaWiki r94702]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r94702. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94702#c22065 Commit summary: Fix a regression in search highlighting from r90092 Followup on r94609, r94681 test cases. This fixes the test case with a period that was failing;

[MediaWiki-CodeReview] [MediaWiki r96460]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96460. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96460 Commit summary: For r91123: * Moved generateReason() to WikiPage. This fixes the PureWikiDeletion ext too. * Make Checkpoint ext call

[MediaWiki-CodeReview] [MediaWiki r91123]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91123. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. *

[MediaWiki-CodeReview] [MediaWiki r96462]: New comment added

2011-09-07 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96462. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96462#c22066 Commit summary: added cancel button to survey edit page and added default header and thanks messages Comment: Changes in

[MediaWiki-CodeReview] [MediaWiki r91159]: New comment added

2011-09-07 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91159. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159#c22067 Commit summary: Expand on r91123 Article refactoring: * Added $user param to relevant WikiPage functions (with b/c) * Cleaned up editUpdates() signature and tweaked

[MediaWiki-CodeReview] [MediaWiki r91159]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91159. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159 Commit summary: Expand on r91123 Article refactoring: * Added $user param to relevant WikiPage functions (with b/c) * Cleaned up

[MediaWiki-CodeReview] [MediaWiki r91159]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91159. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159 Commit summary: Expand on r91123 Article refactoring: * Added $user param to relevant WikiPage functions (with b/c) * Cleaned up

[MediaWiki-CodeReview] [MediaWiki r91327]: New comment added

2011-09-07 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91327#c22068 Commit summary: * Fixed getLatest() check in Article * Added Title::loadFromRow() function and made WikiPage::loadPageData() use it; avoids raw Title field

[MediaWiki-CodeReview] [MediaWiki r91327]: New comment added

2011-09-07 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91327#c22069 Commit summary: * Fixed getLatest() check in Article * Added Title::loadFromRow() function and made WikiPage::loadPageData() use it; avoids raw Title field

[MediaWiki-CodeReview] [MediaWiki r91327]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91327. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91327 Commit summary: * Fixed getLatest() check in Article * Added Title::loadFromRow() function and made WikiPage::loadPageData() use it;

[MediaWiki-CodeReview] [MediaWiki r95340]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r95340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95340#c22070 Commit summary: * (bug 30485) Fixed interference between wikihiero extension and 'wikitable' class style Border padding settings from the .wikitable class were

[MediaWiki-CodeReview] [MediaWiki r84591]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r84591. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84591 Commit summary: * Made BeforeParserMakeImageLinkObj/BeforeGalleryFindFile let hooks set sha1 parameter * Made FlaggedRevs specify

[MediaWiki-CodeReview] [MediaWiki r96470]: New comment added

2011-09-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96470. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96470#c22072 Commit summary: 1.17wmf1: MFT r92962, r93062, r93093, r93385, r93468, r93473, r94350, r94502, r94504, r94511, r94548 Comment: I meant 1.18 instead of 1.17wmf1 of

[MediaWiki-CodeReview] [MediaWiki r96472]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96472. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96472 Commit summary: $wgOverrideSiteFeed was double escaping urls (noticed in bug 30621). (aka it was giving things with amp;amp; in them :s )

[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added, and revision status changed

2011-09-07 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r87164. Old Status: new New Status: fixme User Aaron Schulz also posted a comment on MediaWiki.r87164. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87164#c22073 Commit summary: Recommit r87129 and follow-ups but with a fix for

[MediaWiki-CodeReview] [MediaWiki r96474]: New comment added

2011-09-07 Thread MediaWiki Mail
User MaxSem posted a comment on MediaWiki.r96474. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96474#c22074 Commit summary: Backport r95340, partial r94773 from trunk for bug 30485: set override styles for hieroglyphic layout tables to avoid interference from 'wikitable' class

[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added

2011-09-07 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r87164. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87164#c22075 Commit summary: Recommit r87129 and follow-ups but with a fix for the bug Brion found (sorry) Comment: You can pass partial rows to it as you can see in the

[MediaWiki-CodeReview] [MediaWiki r96474]: New comment added

2011-09-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r96474. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96474#c22076 Commit summary: Backport r95340, partial r94773 from trunk for bug 30485: set override styles for hieroglyphic layout tables to avoid interference from 'wikitable'

[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added, and revision status changed

2011-09-07 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r87164. Old Status: fixme New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r87164. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87164#c22077 Commit summary: Recommit r87129 and follow-ups but with a fix for

[MediaWiki-CodeReview] [MediaWiki r95340]: New comment added

2011-09-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r95340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95340#c22078 Commit summary: * (bug 30485) Fixed interference between wikihiero extension and 'wikitable' class style Border padding settings from the .wikitable class were

[MediaWiki-CodeReview] [MediaWiki r96449]: Revision status changed

2011-09-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96449. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96449 Commit summary: Mark userLink, userTalkLink, blockLink() and emailLink() as public static per CR comment on r96420 by Nikerabbit. He

[MediaWiki-CodeReview] [MediaWiki r96420]: New comment added

2011-09-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r96420. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96420#c22079 Commit summary: Add constant Linker::TOOL_LINKS_EMAIL to allow adding a send e-mail link from Linker:: Add send e-mail link in user tools for developer details

  1   2   >