[MediaWiki-CodeReview] [MediaWiki r97544]: New comment added

2011-09-20 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97544. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97544#c22837 Commit summary: * (bug 31007) Fix regression in rebuildrecentchanges maintenance script Was trying to save literal string 'NULL' into rc_old_len / rc_new_len fields

[MediaWiki-CodeReview] [Wikimedia r257]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r257. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/257 Commit summary: DataFilter classes that enable operations to be plugged into the existing data dictionaries. The base class expects a

[MediaWiki-CodeReview] [Wikimedia r257]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r257. Old Status: ok New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/257 Commit summary: DataFilter classes that enable operations to be plugged into the existing data dictionaries. The base class expects a

[MediaWiki-CodeReview] [Wikimedia r258]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r258. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/258 Commit summary: Added logging module for python logging ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97550]: New comment added

2011-09-20 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97550. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97550#c22838 Commit summary: TimedMediaHandler: change NS number from 700 to 710 Comment: But why? ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [Wikimedia r275]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r275. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/275 Commit summary: Adding custom form style to css Cleaning up the templates ___

[MediaWiki-CodeReview] [MediaWiki r97558]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97558. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97558 Commit summary: * (bug 30977) Remove directions cruft, undo random limitation of input format for Special:Filepath Reverts r43471 which

[MediaWiki-CodeReview] [MediaWiki r97564]: New comment added

2011-09-20 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97564. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97564#c22839 Commit summary: Removed duplication in insertArticleLink Comment: How about the space? ___ MediaWiki-CodeReview mailing

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Nikola Smolenski
On 19/09/11 20:11, Greg Sabino Mullane wrote: supported by many OSs, libraries, etc. As far as collisions, there are plenty of easy solutions, such as: * Check for a collision before allowing a new revision, and do something if so (to handle the pre-image attack) * When reverting, do a

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Domas Mituzas
* When reverting, do a select count(*) where md5=? and then do something more advanced when more than one match is found finally we don't need an index on it becomes we need an index on it, and storage efficiency becomes much more interesting (binary packing yay ;-) so, what are the use

[MediaWiki-CodeReview] [Wikimedia r293]: New comment added, and revision status changed

2011-09-20 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r293. Old Status: new New Status: fixme User Pgehres (WMF) also posted a comment on Wikimedia.r293. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/293#c22840 Commit summary: Added IPCoountryTableLoader class TableLoader

[MediaWiki-CodeReview] [MediaWiki r97576]: New comment added

2011-09-20 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97576. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97576#c22841 Commit summary: MFT r97573 - hook to help with bug 31012 on MobileFrontend similar Comment: With unrelated changes?

[MediaWiki-CodeReview] [Wikimedia r295]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r295. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/295 Commit summary: Class members now initialized in constructor Labels are stored in a dictionary keyed on the same values as the data

[MediaWiki-CodeReview] [Wikimedia r296]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r296. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/296 Commit summary: Removed methods that have been replicated to DataLoader::IPCountryTableLoader Eventually all of these class methods will be

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Daniel Friesen
On 11-09-19 11:43 PM, Domas Mituzas wrote: * When reverting, do a select count(*) where md5=? and then do something more advanced when more than one match is found finally we don't need an index on it becomes we need an index on it, and storage efficiency becomes much more interesting

[MediaWiki-CodeReview] [MediaWiki r97466]: New comment added

2011-09-20 Thread MediaWiki Mail
User Junaidpv posted a comment on MediaWiki.r97466. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97466#c22842 Commit summary: Remove webkit specific slow code with generic approach with the help of jquery.textselection encapsulateSelection method with optional selectionStart

[MediaWiki-CodeReview] [MediaWiki r97544]: New comment added

2011-09-20 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97544. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97544#c22843 Commit summary: * (bug 31007) Fix regression in rebuildrecentchanges maintenance script Was trying to save literal string 'NULL' into rc_old_len / rc_new_len fields

[MediaWiki-CodeReview] [MediaWiki r97495]: New comment added

2011-09-20 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97495. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97495#c22844 Commit summary: Converted patrol log to the new system Comment: Yes, I've misunderstood the documentation: *- 'valid' Valid for batch

[MediaWiki-CodeReview] [MediaWiki r77266]: New comment added

2011-09-20 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r77266. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77266#c22845 Commit summary: 1.16wmf4: Commit live hack for temporary thumbnail support in thumb.php . This should be reengineered properly before being put in trunk Comment:

[MediaWiki-CodeReview] [MediaWiki r97466]: New comment added

2011-09-20 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r97466. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97466#c22846 Commit summary: Remove webkit specific slow code with generic approach with the help of jquery.textselection encapsulateSelection method with optional selectionStart

[MediaWiki-CodeReview] [MediaWiki r96943]: New comment added

2011-09-20 Thread MediaWiki Mail
User Junaidpv posted a comment on MediaWiki.r96943. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96943#c22847 Commit summary: Update Nepali transliteration scheme and removing unused lines. Comment: Scheme update done: r97609 ___

[MediaWiki-CodeReview] [MediaWiki r97495]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97495. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97495 Commit summary: Converted patrol log to the new system ___ MediaWiki-CodeReview mailing

Re: [Wikitech-l] Puppet repository published in a public git repository

2011-09-20 Thread John Du Hart
Wooo, thanks Ryan On Sep 19, 2011 5:09 PM, Ryan Lane rlan...@gmail.com wrote: We've just released our puppet repository into a public git repository. For more information, see the blog post about this:

[MediaWiki-CodeReview] [MediaWiki r97105]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97105. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97105 Commit summary: Loosen MW dir restrictions a bit ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97110]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97110. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97110 Commit summary: Killed annoying chdir() in getMediaWikiCli ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97111]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97111. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97111 Commit summary: skip svn checkout if dir exist instead of exiting completely ___

[MediaWiki-CodeReview] [MediaWiki r97315]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97315. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97315 Commit summary: Handle the lib/ directory for things like geshi ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r97611]: New comment added

2011-09-20 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97611. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97611#c22848 Commit summary: Implemented optional propwidth attribute. layout, propwidth, textwidth attributes now can be specified for qpoll tag, applied to the questions which

[MediaWiki-CodeReview] [MediaWiki r97605]: New comment added, and revision status changed

2011-09-20 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r97605. Old Status: deferred New Status: new User MaxSem also posted a comment on MediaWiki.r97605. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97605#c22849 Commit summary: WikiHiero: got rid of modes other than HTML, the only

[MediaWiki-CodeReview] [MediaWiki r97605]: New comment added

2011-09-20 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r97605. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97605#c22850 Commit summary: WikiHiero: got rid of modes other than HTML, the only other implemented mode is unused and likely broken Comment: Rarrgh. That was unintentional

[MediaWiki-CodeReview] [MediaWiki r97588]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97588. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97588 Commit summary: PHP fatal error in /usr/local/apache/common-local/php-1.18/includes/OutputPage.php line 2961: Call to undefined method

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Anthony
On Mon, Sep 19, 2011 at 10:39 PM, Daniel Friesen li...@nadir-seen-fire.com wrote: On 11-09-19 06:39 PM, Anthony wrote: On Mon, Sep 19, 2011 at 3:57 PM, Brion Vibber br...@pobox.com wrote: That's probably the simplest solution; adding a new empty table will be very quick. It may make it slower

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Domas Mituzas
Ah, okay. I remember that's what happened in MyISAM but I figured they had that fixed in InnoDB. InnoDB has optimized path for index builds, not for schema changes. Domas ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r97328]: New comment added

2011-09-20 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r97328. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97328#c22851 Commit summary: Noticed in apache error logs (see below). If the length of the message is longer than the maximum length, only send what will fit Sep 16 20:07:28

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Anthony
On Tue, Sep 20, 2011 at 9:34 AM, Domas Mituzas midom.li...@gmail.com wrote: Ah, okay.  I remember that's what happened in MyISAM but I figured they had that fixed in InnoDB. InnoDB has optimized path for index builds, not for schema changes. No support for built-in function-based indexes,

[MediaWiki-CodeReview] [MediaWiki r97328]: New comment added

2011-09-20 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r97328. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97328#c22852 Commit summary: Noticed in apache error logs (see below). If the length of the message is longer than the maximum length, only send what will fit Sep 16 20:07:28

[MediaWiki-CodeReview] [MediaWiki r97611]: New comment added

2011-09-20 Thread MediaWiki Mail
User QuestPC posted a comment on MediaWiki.r97611. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97611#c22853 Commit summary: Implemented optional propwidth attribute. layout, propwidth, textwidth attributes now can be specified for qpoll tag, applied to the questions which do

[MediaWiki-CodeReview] [MediaWiki r97622]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97622. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97622 Commit summary: As reported in bug 31031, WebKit can mess up the TOC title (which is in user language) because it inherits the direction from

[MediaWiki-CodeReview] [MediaWiki r97632]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97632. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97632 Commit summary: Fixup call to deprecated wfGetIP() Add empty qqq message array ___

[MediaWiki-CodeReview] [MediaWiki r74966]: New comment added

2011-09-20 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r74966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74966#c22854 Commit summary: First shot at porting Monobook to Vector. The only non-straightforward part is moving from a separate rtl.css file to a main.css file we can safely

[MediaWiki-CodeReview] [MediaWiki r97623]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r97623. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97623 Commit summary: Reinstate IE*Fixes.css . This fixes most of the breakage from r74966, but there's one thing (icon placement) that's still

[MediaWiki-CodeReview] [MediaWiki r97634]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r97634. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97634 Commit summary: Followup r97623: some fixes for RTL in IE70Fixes.css: * Remove useless .rtl #bodyContent a.external rule, already handled by

[MediaWiki-CodeReview] [MediaWiki r97633]: New comment added, and revision status changed

2011-09-20 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97633. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r97633. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97633#c22855 Commit summary: Added LinkCache::addGoodLinkObjFromRow, since

[MediaWiki-CodeReview] [MediaWiki r52460]: New comment added

2011-09-20 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r52460. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/52460#c22856 Commit summary: Add in-process caching to User::idFromName Comment: Hmm, why didn't this block deployment? Long-running scripts do, in fact, exist and are used

[MediaWiki-CodeReview] [MediaWiki r97544]: New comment added

2011-09-20 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r97544. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97544#c22857 Commit summary: * (bug 31007) Fix regression in rebuildrecentchanges maintenance script Was trying to save literal string 'NULL' into rc_old_len / rc_new_len

[MediaWiki-CodeReview] [MediaWiki r97633]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97633. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97633 Commit summary: Added LinkCache::addGoodLinkObjFromRow, since addGoodLinkObj is not going to work much longer when new parameters are

[MediaWiki-CodeReview] [MediaWiki r97550]: New comment added

2011-09-20 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r97550. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97550#c22858 Commit summary: TimedMediaHandler: change NS number from 700 to 710 Comment: [[Talk:Extension namespace registration|So that people can be happy.]]

[MediaWiki-CodeReview] [MediaWiki r97554]: New comment added

2011-09-20 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r97554. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97554#c22859 Commit summary: Merged in change from Wikia which prevents an E_NOTICE on Special:FewestRevisions page. Comment: [[Manual:Coding conventions#Spaces|Needs moar

[MediaWiki-CodeReview] [MediaWiki r75585]: New comment added

2011-09-20 Thread MediaWiki Mail
User Firefishy posted a comment on MediaWiki.r75585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75585#c22860 Commit summary: Optional feature to login through HTTPS and come back to HTTP. Based on an idea by George Herbert george dot herbert at gmail dot com

Re: [Wikitech-l] New pattern for introducing wfDeprecated calls into core

2011-09-20 Thread Jeroen De Dauw
Hey, This is neat. What about adding another optional argument which allows passing a version variable that the provided version string needs to hold up against? This would allow extensions to also utilize wfDeprecated, which makes sense, since core is not the only place where interfaces are

[MediaWiki-CodeReview] [MediaWiki r97608]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r97608. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97608 Commit summary: For backwards compatibility with cached HTML generated by MediaWiki 1.17, re-introduce mw.loader.go() . This would have

[MediaWiki-CodeReview] [MediaWiki r97607]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r97607. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97607 Commit summary: Accept ResourceLoader URLs containing '!' in '.' for backwards compatibility with a hack that existed in MediaWiki at some

[MediaWiki-CodeReview] [MediaWiki r97401]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97401. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97401 Commit summary: Create l10n cache dir so LU works ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Puppet repository published in a public git repository

2011-09-20 Thread Ashar Voultoiz
On 19/09/11 23:08, Ryan Lane wrote: We've just released our puppet repository into a public git repository. For more information, see the blog post about this: http://blog.wikimedia.org/2011/09/19/ever-wondered-how-the-wikimedia-servers-are-configured/ Well done op team! :-D -- Ashar

[MediaWiki-CodeReview] [MediaWiki r74966]: New comment added

2011-09-20 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r74966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74966#c22861 Commit summary: First shot at porting Monobook to Vector. The only non-straightforward part is moving from a separate rtl.css file to a main.css file we can safely

[MediaWiki-CodeReview] [MediaWiki r74966]: New comment added

2011-09-20 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r74966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74966#c22862 Commit summary: First shot at porting Monobook to Vector. The only non-straightforward part is moving from a separate rtl.css file to a main.css file we can safely

[MediaWiki-CodeReview] [MediaWiki r97583]: New comment added

2011-09-20 Thread MediaWiki Mail
User G.Hagedorn posted a comment on MediaWiki.r97583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97583#c22863 Commit summary: preilly PHP fatal error in /usr/local/apache/common-local/php-1.18/extensions/TitleBlacklist/TitleBlacklist.list.php line 326: Fixed in 1.18wmf1

[MediaWiki-CodeReview] [MediaWiki r97583]: New comment added

2011-09-20 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r97583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97583#c22864 Commit summary: preilly PHP fatal error in /usr/local/apache/common-local/php-1.18/extensions/TitleBlacklist/TitleBlacklist.list.php line 326: Fixed in 1.18wmf1 and

[MediaWiki-CodeReview] [MediaWiki r97583]: New comment added

2011-09-20 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r97583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97583#c22865 Commit summary: preilly PHP fatal error in /usr/local/apache/common-local/php-1.18/extensions/TitleBlacklist/TitleBlacklist.list.php line 326: Fixed in 1.18wmf1 and

[MediaWiki-CodeReview] [MediaWiki r92246]: New comment added, and revision status changed

2011-09-20 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r92246. Old Status: ok New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r92246. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92246#c22866 Commit summary: Follow-up r79845: Fix rotation. Turns out that we

[MediaWiki-CodeReview] [MediaWiki r93686]: New comment added

2011-09-20 Thread MediaWiki Mail
User G.Hagedorn posted a comment on MediaWiki.r93686. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93686#c22867 Commit summary: Merge live hacks - Tim's fixes for canary mismatches from back around the 1.17 deploy. Don't want to push this to trunk, but don't want it lost

[MediaWiki-CodeReview] [MediaWiki r97583]: New comment added

2011-09-20 Thread MediaWiki Mail
User G.Hagedorn posted a comment on MediaWiki.r97583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97583#c22868 Commit summary: preilly PHP fatal error in /usr/local/apache/common-local/php-1.18/extensions/TitleBlacklist/TitleBlacklist.list.php line 326: Fixed in 1.18wmf1

[MediaWiki-CodeReview] [MediaWiki r93686]: New comment added

2011-09-20 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r93686. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93686#c22869 Commit summary: Merge live hacks - Tim's fixes for canary mismatches from back around the 1.17 deploy. Don't want to push this to trunk, but don't want it lost easier :)

[MediaWiki-CodeReview] [MediaWiki r79845]: New comment added, and revision status changed

2011-09-20 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r79845. Old Status: resolved New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r79845. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79845#c22870 Commit summary: $wgMaxUploadSize may now be set to an array

[MediaWiki-CodeReview] [MediaWiki r92246]: New comment added

2011-09-20 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r92246. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92246#c22871 Commit summary: Follow-up r79845: Fix rotation. Turns out that we need to pass the pre-rotation dimensions to convert.exe. Also added tests. Comment: Test

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Happy Melon
On Mon, Sep 19, 2011 at 12:53 PM, Asher Feldman afeldman [at] wikimediawrote: Since the primary use case here seems to be offline analysis and it may not be of much interest to mediawiki users outside of wmf, can we store the checksums in new tables (i.e. revision_sha1) instead of running

[MediaWiki-CodeReview] [MediaWiki r97374]: New comment added

2011-09-20 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r97374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97374#c22872 Commit summary: AdManager: version 0.2: *remove unused jquery-1.4.2.min.js file *define new globals $wgAdManagerService and $wgAdManagerCode in the setup file *some

[MediaWiki-CodeReview] [MediaWiki r97657]: New comment added

2011-09-20 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r97657. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97657#c22873 Commit summary: Fix support of legacy skins Standard CologneBlue for user language direction: the topbar and footer used a quickbar compensator which relied on the

[MediaWiki-CodeReview] [MediaWiki r97660]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r97660. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97660 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net ___

[MediaWiki-CodeReview] [MediaWiki r97342]: New comment added

2011-09-20 Thread MediaWiki Mail
User SColombo posted a comment on MediaWiki.r97342. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97342#c22874 Commit summary: Merged in changes from LogEventsList which prevent missing usernames in log-lines and adds hook LogEventsListShowLogExtract. Part of merge from here:

[MediaWiki-CodeReview] [MediaWiki r97651]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97651. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97651 Commit summary: Partial revert of broken test changes from r92246 -- for some reason it was trying to test some random handler parameter

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Happy Melon
On Mon, Sep 19, 2011 at 12:53 PM, Asher Feldman afeldman [at] wikimediawrote: Since the primary use case here seems to be offline analysis and it may not be of much interest to mediawiki users outside of wmf, can we store the checksums in new tables (i.e. revision_sha1) instead of running

[MediaWiki-CodeReview] [MediaWiki r97664]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r97664. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97664 Commit summary: Add Wlm to translatewiki.net (r97662) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97661]: New comment added

2011-09-20 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r97661. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97661#c22875 Commit summary: Fixed IE6 issues in RTL mode Comment: pre + /* the tabs */ + + /* the tabs */ /pre Whoops? ___

[MediaWiki-CodeReview] [MediaWiki r97665]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r97665. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97665 Commit summary: Add Toolserver Status to translatewiki.net (r94255) ___ MediaWiki-CodeReview

[Wikitech-l] Brighton Wikimedia Hackathon - 19-20 Nov.

2011-09-20 Thread Lewis Cawte
Greetings all, Been some things floating around about this already, but I'm proud to announce Brighton Wikimedia Hackathon. http://www.mediawiki.org/wiki/Brighton_Hackathon_2011 MediaWiki developers are going to meet in Brighton on the South East coast of the United Kingdom to hack anything

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Platonides
Domas Mituzas wrote: * When reverting, do a select count(*) where md5=? and then do something more advanced when more than one match is found finally we don't need an index on it becomes we need an index on it, and storage efficiency becomes much more interesting (binary packing yay ;-)

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Daniel Friesen
On 11-09-20 02:26 PM, Platonides wrote: Domas Mituzas wrote: * When reverting, do a select count(*) where md5=? and then do something more advanced when more than one match is found finally we don't need an index on it becomes we need an index on it, and storage efficiency becomes much more

Re: [Wikitech-l] Progress made on packaging hiphop for debian

2011-09-20 Thread Tim Starling
On 20/09/11 11:05, Mark A. Hershberger wrote: At that point, I contacted Mike and asked for his help. He suggested we attempt to get HipHop compiled *without* the patches since the upstream developers weren't too enthusiastic about them. I've been working on a replacement for the libcurl

[MediaWiki-CodeReview] [MediaWiki r97666]: New comment added

2011-09-20 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r97666. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97666#c22876 Commit summary: * Add /secure skins symlink * Refactored out code duplication with createSymlink() Comment: Shouldn't createSymlink() do something if symlink()

[MediaWiki-CodeReview] [MediaWiki r97661]: New comment added

2011-09-20 Thread MediaWiki Mail
User Trevor Parscal posted a comment on MediaWiki.r97661. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97661#c22877 Commit summary: Fixed IE6 issues in RTL mode Comment: Good catch - sorted in r97668 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r97668]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97668. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97668 Commit summary: Cleaned up leftovers from applying a patch ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97667]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97667. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97667 Commit summary: Haz moar spaces :) ... follow-up to r97554 as per Jack Phoenix. ___

[MediaWiki-CodeReview] [MediaWiki r97668]: New comment added

2011-09-20 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r97668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97668#c22878 Commit summary: Cleaned up leftovers from applying a patch Comment: smallwhich was in r97661/small ___

[MediaWiki-CodeReview] [MediaWiki r74966]: New comment added

2011-09-20 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r74966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74966#c22879 Commit summary: First shot at porting Monobook to Vector. The only non-straightforward part is moving from a separate rtl.css file to a main.css file we can safely

[MediaWiki-CodeReview] [MediaWiki r97033]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r97033. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97033 Commit summary: Merged wgWhatlinkshereLimit from Wikia. It defaults to the same value it was hardcoded to before.

[MediaWiki-CodeReview] [MediaWiki r74966]: New comment added, and revision status changed

2011-09-20 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r74966. Old Status: fixme New Status: resolved User Trevor Parscal also posted a comment on MediaWiki.r74966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74966#c22880 Commit summary: First shot at porting Monobook to

[MediaWiki-CodeReview] [MediaWiki r92246]: New comment added, and revision status changed

2011-09-20 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r92246. Old Status: fixme New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r92246. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92246#c22881 Commit summary: Follow-up r79845: Fix rotation. Turns out

[MediaWiki-CodeReview] [MediaWiki r79845]: New comment added, and revision status changed

2011-09-20 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r79845. Old Status: fixme New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r79845. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79845#c22882 Commit summary: $wgMaxUploadSize may now be set to an array

[Wikitech-l] Updates for EXIF rotated photos in trunk 1.18

2011-09-20 Thread Brion Vibber
One of the long-awaited minor features that has finally come in during the 1.18 development cycle is resolving old bug 6672, natively supporting photos where EXIF metadata specifies a non-default orientation. This is very common in photos taken with digital cameras; a portrait-mode image may be

[MediaWiki-CodeReview] [MediaWiki r97682]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97682. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97682 Commit summary: fix for bug 31049 - Disable mobile site link ___ MediaWiki-CodeReview mailing list

[Wikitech-l] Please merge deployment changes into 1.17wmf1 and 1.18wmf1 now

2011-09-20 Thread Rob Lanphier
Hi all, If you are someone who currently merges code into the 1.17wmf1 branch, this mail is for you: We need you to make sure that you merge your code into the 1.18wmf1 branch as well. That also means if you're deploying code and using syncfile to push individual files, you need to push from

Re: [Wikitech-l] Updates for EXIF rotated photos in trunk 1.18

2011-09-20 Thread Rob Lanphier
Fantastic...thanks for jumping on this Brion! And Reedy, thanks for pushing this out! So, this code should be live on http://test2.wikipedia.org plstestkthxbai :) Rob On Tue, Sep 20, 2011 at 3:54 PM, Brion Vibber br...@pobox.com wrote: One of the long-awaited minor features that has

[MediaWiki-CodeReview] [MediaWiki r97685]: New comment added

2011-09-20 Thread MediaWiki Mail
User Jorm (WMF) posted a comment on MediaWiki.r97685. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97685#c22883 Commit summary: Added initial html and css that UI will be built from. Comment: Krinkle left a comment on the mw.org page about the inclusion of the cut assets on

[MediaWiki-CodeReview] [MediaWiki r97685]: New comment added

2011-09-20 Thread MediaWiki Mail
User Trevor Parscal posted a comment on MediaWiki.r97685. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97685#c22884 Commit summary: Added initial html and css that UI will be built from. Comment: 1. Since the assets will end up in the SVN eventually anyways, it produces

[MediaWiki-CodeReview] [MediaWiki r97652]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r97652. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97652 Commit summary: Break line in r97634 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97653]: Revision status changed

2011-09-20 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r97653. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97653 Commit summary: Followup r97652, *actually* break the line ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97634]: New comment added

2011-09-20 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r97634. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97634#c22885 Commit summary: Followup r97623: some fixes for RTL in IE70Fixes.css: * Remove useless .rtl #bodyContent a.external rule, already handled by CSSJanus * Flip the

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-20 Thread Anthony
On Tue, Sep 20, 2011 at 3:37 PM, Happy Melon happy-me...@live.com wrote: It may or may not be an architecturally-better design to have it as a separate table, although considering how rapidly MW's 'architecture' changes I'd say keeping things as simple as possible is probably a virtue.  But

[MediaWiki-CodeReview] [MediaWiki r97658]: New comment added, and revision status changed

2011-09-20 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r97658. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r97658. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97658#c22886 Commit summary: * Made IndexPager extend ContextSource * Updated special

  1   2   >