Re: [Wikitech-l] Making developer access easier to get

2011-10-04 Thread Daniel Friesen
On 11-10-03 07:08 PM, Olivier Beaton wrote: It seems pretty straight forward to me, #1 Core access? Keep existing review process in place, could take 6 months, sorry. Patches that will never get committed for you! #2 Extension access? Has a working extension attached to submission (has some

[MediaWiki-CodeReview] [MediaWiki r98773]: New comment added

2011-10-04 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r98773. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98773#c23712 Commit summary: fix Bug #31317 - LiquidThreads arrow icon disappears upon collapsing a thread Thanks to p858snake for the hint. Comment: So tagged.

[MediaWiki-CodeReview] [MediaWiki r98789]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98789. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98789 Commit summary: [RL2] Fix pleonastic comparison per r97104 CR ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r97354]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97354. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97354 Commit summary: [RL2] More renaming from 'name' to 'id' (Follows-up r96761) ___

[MediaWiki-CodeReview] [MediaWiki r97363]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97363. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97363 Commit summary: [RL2] More renaming from 'name' to 'id' (Follows-up r96761, r97354) ___

[MediaWiki-CodeReview] [MediaWiki r97408]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97408. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97408 Commit summary: [RL2] Update version requirement to 1.19alpha since we're relying on very recent stuff like ResourceLoader sources and what

[MediaWiki-CodeReview] [MediaWiki r97567]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97567. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97567 Commit summary: [RL2] Gonna merge the other way around to preserve longer history ___

[MediaWiki-CodeReview] [MediaWiki r97570]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97570. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97570 Commit summary: [RL2] Commit old SpecialGadgets.php - Orignally removed in r97513 - Removed the new one in r97566

[MediaWiki-CodeReview] [MediaWiki r98102]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98102. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98102 Commit summary: [RL2] ext.gadgets.gadgetmanager: Fix self closing html:key / + i18n message *The self-closing slash was missing in some cases,

[MediaWiki-CodeReview] [MediaWiki r97513]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97513. Old Status: new New Status: resolved User Catrope also posted a comment on MediaWiki.r97513. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97513#c23713 Commit summary: [ResourceLoader2] Merge SpecialGadgets w/

[MediaWiki-CodeReview] [MediaWiki r98729]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98729. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r98729. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98729#c23714 Commit summary: [RL2] Merge gadget manager into SpecialGadgets * Rewrite

[MediaWiki-CodeReview] [MediaWiki r98733]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98733. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98733 Commit summary: [RL2] GadgetHooks - Gadgets.hooks.php ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98734]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98734. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98734 Commit summary: [RL2] Make export form nicer and list the actual page titles as an unordered list with anchor tags

[MediaWiki-CodeReview] [MediaWiki r98735]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98735. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98735 Commit summary: [RL2] Entire gadget row is now clickable ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98736]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98736. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98736 Commit summary: [RL2] Also load the module on [[Special:Gadgets/foo]] ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r98737]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98737. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98737 Commit summary: [RL2] Fix special page detection. * r98235 broke equals() for subpages (like Special:Gadgets/foo, which no longer matches and

[MediaWiki-CodeReview] [MediaWiki r98780]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98780. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98780 Commit summary: [RL2] Break long lines ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98837]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98837. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r98837. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98837#c23715 Commit summary: [RL2] Implement create mode * New option 'extraquery' in

Re: [Wikitech-l] Making developer access easier to get

2011-10-04 Thread Olivier Beaton
I'm going to nip this one in the bud right away, and given that core and extension SVN access is already separate already, I already know we're making use of it. In your SVN auth file on the server: [/mediawiki/trunk/extensions/SomeExtension] username = rw

Re: [Wikitech-l] Announcing Phil Chang as our Product Manager Mobile

2011-10-04 Thread Sumana Harihareswara
On 10/03/2011 01:21 PM, Erik Moeller wrote: Hello all, It’s with great pleasure that I’m announcing Phil Chang as our new Product Manager for Mobile. Phil will be working closely with Tomasz’ engineering team and will report to me. As product manager, it’s Phil’s job to define the scope and

Re: [Wikitech-l] Native HTTPS support live on all projects

2011-10-04 Thread Sumana Harihareswara
On 10/03/2011 12:26 PM, Ryan Lane wrote: I'm happy to announce we've added native HTTPS support to all of the projects. See the blog post for more information: http://blog.wikimedia.org/2011/10/03/native-https-support-enabled-for-all-wikimedia-foundation-wikis/ If you find any bugs,

[Wikitech-l] Mystery of most-viewed pages on En.Wikipedia

2011-10-04 Thread Gregory Kohs
Does the Wikimedia Foundation's technology team have any insight or comment on the finding that (other than the Wikipedia Main Page and the 404 error page), in September the most popular page on the English Wikipedia was Mathematical descriptions of opacity, with over 5.1 million views? There was

Re: [Wikitech-l] Mystery of most-viewed pages on En.Wikipedia

2011-10-04 Thread Thomas Morton
If I remember correctly; stats collection is imperfect, and that results in some odd numbers. That is just my memory of why it looks like that. Tom On 4 October 2011 14:10, Gregory Kohs thekoh...@gmail.com wrote: Does the Wikimedia Foundation's technology team have any insight or comment on

Re: [Wikitech-l] Mystery of most-viewed pages on En.Wikipedia

2011-10-04 Thread Chad
On Tue, Oct 4, 2011 at 9:10 AM, Gregory Kohs thekoh...@gmail.com wrote: Do you think this is some sort of malicious probing activity by a hacker, or is it perhaps the deliberate testing of a developer employed by the WMF? There's no specific testing that I know of. Other than skewing

Re: [Wikitech-l] Mystery of most-viewed pages on En.Wikipedia

2011-10-04 Thread Roan Kattouw
On Tue, Oct 4, 2011 at 3:10 PM, Gregory Kohs thekoh...@gmail.com wrote: Does the Wikimedia Foundation's technology team have any insight or comment on the finding that (other than the Wikipedia Main Page and the 404 error page), in September the most popular page on the English Wikipedia was

Re: [Wikitech-l] Mystery of most-viewed pages on En.Wikipedia

2011-10-04 Thread Roan Kattouw
On Tue, Oct 4, 2011 at 3:48 PM, Roan Kattouw roan.katt...@gmail.com wrote: There seem to have been a lot of page views concentrated around September 22-26. Missing link here: http://stats.grok.se/en/201109/Mathematical%20descriptions%20of%20opacity Roan

Re: [Wikitech-l] Making developer access easier to get

2011-10-04 Thread Daniel Friesen
On 11-10-04 04:29 AM, Olivier Beaton wrote: I'm going to nip this one in the bud right away, and given that core and extension SVN access is already separate already, I already know we're making use of it. In your SVN auth file on the server: [/mediawiki/trunk/extensions/SomeExtension]

Re: [Wikitech-l] Making developer access easier to get

2011-10-04 Thread Chad
On Tue, Oct 4, 2011 at 7:29 AM, Olivier Beaton olivier.bea...@gmail.com wrote: I'm going to nip this one in the bud right away, and given that core and extension SVN access is already separate already, I already know we're making use of it. In your SVN auth file on the server:

Re: [Wikitech-l] Mystery of most-viewed pages on En.Wikipedia

2011-10-04 Thread Roan Kattouw
On Tue, Oct 4, 2011 at 3:48 PM, Roan Kattouw roan.katt...@gmail.com wrote: There seem to have been a lot of page views concentrated around September 22-26. This could be something as innocent as someone running a broken bot that's supposed to fetch lots of different articles but instead

[MediaWiki-CodeReview] [MediaWiki r98856]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r98856. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98856 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Making developer access easier to get

2011-10-04 Thread Olivier Beaton
Oh boy. That was a bit uncalled for there, I'll try to reply to the parts that were civil. On Tue, Oct 4, 2011 at 9:51 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: Ok. Let's see. Firstly most extensions don't use tags so we can omit that, Why not? Extensions have versions, why shouldn't

Re: [Wikitech-l] Mystery of most-viewed pages on En.Wikipedia

2011-10-04 Thread Nikola Smolenski
On 04/10/11 15:48, Roan Kattouw wrote: On Tue, Oct 4, 2011 at 3:10 PM, Gregory Kohsthekoh...@gmail.com wrote: Does the Wikimedia Foundation's technology team have any insight or comment on the finding that (other than the Wikipedia Main Page and the 404 error page), in September the most

Re: [Wikitech-l] Making developer access easier to get

2011-10-04 Thread Olivier Beaton
Is that a reply to Dan's branches/REL_*/extensions madness or a legitimate having 1-3 lines in the config per extension author we are trying out until they get full extension access is not a scalable process? Depending on how many people are requesting access, I can see how that could still be

[MediaWiki-CodeReview] [MediaWiki r95787]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r95787. Old Status: fixme New Status: new User Catrope also posted a comment on MediaWiki.r95787. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95787#c23716 Commit summary: RL2: Add hooks that ensure the database is updated when

[MediaWiki-CodeReview] [MediaWiki r96837]: New comment added

2011-10-04 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96837. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96837#c23717 Commit summary: RL2: Reorganize caching in LocalGadgetRepo so we no longer load the entire gadgets table from the DB on every page view. There is now one memcached

[MediaWiki-CodeReview] [MediaWiki r94255]: New comment added

2011-10-04 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r94255. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94255#c23718 Commit summary: Bad filename in r94251 Comment: Fixed with r98860, r98861 and r98862. And it works now at translatewiki.net:

[Wikitech-l] Skin rewrite future plans

2011-10-04 Thread Daniel Friesen
I finally got around to organizing my Skinning system page and cleaning out the ideas sitting there that I actually dropped or replaced. https://www.mediawiki.org/wiki/User:Dantman/Skinning_system Some notable things: - A template system is planned. The idea is slowly stabilizing. - I plan to

[Wikitech-l] Page Output branch: PageView, Special Page based actions, Functional logic separation from skin, ...

2011-10-04 Thread Daniel Friesen
I've been working on a pageoutput branch. Centred around an earlier RFC. https://www.mediawiki.org/wiki/User:Dantman/Page_output_branch https://www.mediawiki.org/wiki/Requests_for_comment/Drop_actions_in_favour_of_page_views_and_special_pages The general goals of the project are: - Actions die

[MediaWiki-CodeReview] [MediaWiki r98854]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r98854. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98854 Commit summary: Fix various typos in r97513 and r98729 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98735]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98735. Old Status: ok New Status: fixme User Catrope also posted a comment on MediaWiki.r98735. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98735#c23719 Commit summary: [RL2] Entire gadget row is now clickable Comment: This

[MediaWiki-CodeReview] [MediaWiki r98735]: New comment added

2011-10-04 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r98735. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98735#c23720 Commit summary: [RL2] Entire gadget row is now clickable Comment: Is that literal -1 supposed to indicate 'special namespace'? If so, it really should be using a

[MediaWiki-CodeReview] [MediaWiki r98735]: New comment added

2011-10-04 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r98735. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98735#c23721 Commit summary: [RL2] Entire gadget row is now clickable Comment: I'm aware of the on-click issue. Discovered it shortly after committing but already had everything

[MediaWiki-CodeReview] [MediaWiki r98865]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98865. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98865 Commit summary: Fix for r98756: $wgDefaultExternalStore can also be a string ___

[MediaWiki-CodeReview] [MediaWiki r98866]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98866. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98866 Commit summary: Fix spelling errors: challange-challenge oppertunity-opportunity oppertunities-opportunities This requires re-importing

[MediaWiki-CodeReview] [MediaWiki r98857]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98857. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98857 Commit summary: Simplify a bit by adding the result inside the wfRunHooks() check ___

[MediaWiki-CodeReview] [MediaWiki r98847]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98847. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98847 Commit summary: Followup to r98839. Removed 'escape' from wfMsgExt (suggested by Nikerabbit); wrote full class names (suggested by

[MediaWiki-CodeReview] [MediaWiki r98851]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98851. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98851 Commit summary: Followup to r98847. Replacing .= with = ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98839]: New comment added

2011-10-04 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r98839. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98839#c23723 Commit summary: The general fix is setting the directionality of added or removed bytes in recent changes. It is always supposed to be LTR. Details: * Spelling of

[MediaWiki-CodeReview] [MediaWiki r98839]: New comment added

2011-10-04 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r98839. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98839#c23724 Commit summary: The general fix is setting the directionality of added or removed bytes in recent changes. It is always supposed to be LTR. Details: * Spelling of

[MediaWiki-CodeReview] [MediaWiki r98881]: New comment added

2011-10-04 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r98881. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98881#c23725 Commit summary: * (bug 31351) fix Quiz extension strict warning patch by Rusty Burchfield, https://bugzilla.wikimedia.org/attachment.cgi?id=9155action=diff Comment:

[MediaWiki-CodeReview] [MediaWiki r98840]: New comment added

2011-10-04 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r98840. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98840#c23726 Commit summary: added support for multi-file selection fixed a bug in FormData transport's progress bar method Comment: This is bug 26502.

[MediaWiki-CodeReview] [MediaWiki r98866]: New comment added

2011-10-04 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r98866. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98866#c23727 Commit summary: Fix spelling errors: challange-challenge oppertunity-opportunity oppertunities-opportunities This requires re-importing the SQL as table

[MediaWiki-CodeReview] [MediaWiki r98860]: New comment added

2011-10-04 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r98860. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98860#c23728 Commit summary: Rename file tp make it consistent and make translatewiki.net happy Comment: Why lower case? ___

[MediaWiki-CodeReview] [MediaWiki r98861]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98861. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98861 Commit summary: followup for r98860 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98860]: New comment added

2011-10-04 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r98860. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98860#c23729 Commit summary: Rename file tp make it consistent and make translatewiki.net happy Comment: Ah I see. ___

[MediaWiki-CodeReview] [MediaWiki r98860]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98860. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98860 Commit summary: Rename file tp make it consistent and make translatewiki.net happy ___

[MediaWiki-CodeReview] [MediaWiki r98862]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98862. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98862 Commit summary: followup for r98860 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98879]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98879. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98879 Commit summary: [RL2] Comment edit (Follows-up r98878). Using string instead of blob, like loadDataFor says to avoid confusion

[MediaWiki-CodeReview] [MediaWiki r98848]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Santhosh.thottingal changed the status of MediaWiki.r98848. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98848 Commit summary: Narayam: Removing escapings for English letters from Sinhala Singlish as it is conflicting with other rules in

[MediaWiki-CodeReview] [MediaWiki r98665]: New comment added

2011-10-04 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r98665. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98665#c23730 Commit summary: Add the class jquery-tablesorter to all tables that are made sortable. Use this classname to raise the specificity of the sortHeader, so that it is more

[MediaWiki-CodeReview] [MediaWiki r98669]: New comment added

2011-10-04 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r98669. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98669#c23731 Commit summary: Add tfoot emulation to tablesorter. Fixes part of the complaints in bug 31060 Comment: I think this should be merged into 1.18 and 1.18wmf 1. It will

[MediaWiki-CodeReview] [MediaWiki r98855]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Santhosh.thottingal changed the status of MediaWiki.r98855. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98855 Commit summary: Narayam: Sinhala Singlish update. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r98881]: New comment added

2011-10-04 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r98881. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98881#c23732 Commit summary: * (bug 31351) fix Quiz extension strict warning patch by Rusty Burchfield, https://bugzilla.wikimedia.org/attachment.cgi?id=9155action=diff

[MediaWiki-CodeReview] [MediaWiki r94627]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Raindrift changed the status of MediaWiki.r94627. Old Status: deferred New Status: fixme User Raindrift also posted a comment on MediaWiki.r94627. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94627#c23733 Commit summary: Add FormData upload transport. If enabled this is

[MediaWiki-CodeReview] [MediaWiki r98578]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98578. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r98578. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98578#c23734 Commit summary: * (bug 12130) Initial newlines are now preserved

[MediaWiki-CodeReview] [MediaWiki r98774]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98774. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r98774. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98774#c23735 Commit summary: Fix embarrassing mistake in r98718 Comment: Nobody

[Wikitech-l] Some post-1.18 issues found on Meta

2011-10-04 Thread Arthur Richards
Just wanted to raise two separate incidents that have been reported to me by two separate users on meta.wikimedia.org after the 1.18 upgrade: 1) A user was attempting to look at all of the translations for a particular banner in CentralNotice (a common task carried out with no issue prior to the

[MediaWiki-CodeReview] [MediaWiki r98783]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r98783. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98783 Commit summary: Use local context instead of global variables ___ MediaWiki-CodeReview mailing

Re: [Wikitech-l] Some post-1.18 issues found on Meta

2011-10-04 Thread Roan Kattouw
On Tue, Oct 4, 2011 at 9:58 PM, Arthur Richards aricha...@wikimedia.org wrote: PHP fatal error in /usr/local/apache/common-local/php-1.18/extensions/CentralAuth/CentralAuth.i18n.php line 19586:  Allowed memory size of 125829120 bytes exhausted (tried to allocate 7864320 bytes) Those things

[MediaWiki-CodeReview] [MediaWiki r98296]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r98296. Old Status: new New Status: ok User Awjrichards also posted a comment on MediaWiki.r98296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98296#c23736 Commit summary: allow people to set expiration date for

[MediaWiki-CodeReview] [MediaWiki r96507]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96507. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96507 Commit summary: * Added moved scripts to $wikiless per r96489 * Added dump/rebuild interwiki scripts to $wikiless

[MediaWiki-CodeReview] [MediaWiki r97666]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97666. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97666 Commit summary: * Add /secure skins symlink * Refactored out code duplication with createSymlink()

[MediaWiki-CodeReview] [MediaWiki r97666]: New comment added

2011-10-04 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r97666. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97666#c23737 Commit summary: * Add /secure skins symlink * Refactored out code duplication with createSymlink() Comment: Yeah, it should print an error message. Tagging todo.

[MediaWiki-CodeReview] [MediaWiki r97666]: New comment added

2011-10-04 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r97666. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97666#c23738 Commit summary: * Add /secure skins symlink * Refactored out code duplication with createSymlink() Comment: Shouldn't the PHP warnings show up already?

[MediaWiki-CodeReview] [MediaWiki r97666]: New comment added

2011-10-04 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r97666. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97666#c23739 Commit summary: * Add /secure skins symlink * Refactored out code duplication with createSymlink() Comment: Fair enough.

[MediaWiki-CodeReview] [MediaWiki r97828]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97828. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97828 Commit summary: resources-* dir changed ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98204]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98204. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98204 Commit summary: Added success message ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98252]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98252. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98252 Commit summary: Removed scary 1.17 fallback code ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98254]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98254. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98254 Commit summary: * Added newFromDBName() function to allow non-singleton use. * Minor doc tweaks and updates

[MediaWiki-CodeReview] [MediaWiki r98559]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r98559. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98559 Commit summary: (bug 31283) Made ChangeEmail check $wgAuth-allowPropChange( 'emailaddress' ). Fix for r92924. Mark beat me to

[MediaWiki-CodeReview] [MediaWiki r98891]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Meno25 changed the status of MediaWiki.r98891. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98891 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r98256]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98256. Old Status: new New Status: resolved User Catrope also posted a comment on MediaWiki.r98256. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98256#c23740 Commit summary: Added getMWVersion script to get the MW version

[MediaWiki-CodeReview] [MediaWiki r98258]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98258. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98258 Commit summary: Allow overriding the dbname for wikiless scripts. We may want a wiki of specific version, not just what aawiki is running.

[MediaWiki-CodeReview] [MediaWiki r98280]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98280. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98280 Commit summary: Fixed usage msg and added newine to output ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98284]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98284. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r98284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98284#c23741 Commit summary: Backup wikiversions.dat for easier rollback Comment: pre +

[MediaWiki-CodeReview] [MediaWiki r98904]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r98904. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98904 Commit summary: Use wfTimestampNow() for more readable timestamps in the backup file names

[MediaWiki-CodeReview] [MediaWiki r98342]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98342. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98342 Commit summary: * Added defines.php class to hold some directory constants * A few style cleanups

[MediaWiki-CodeReview] [MediaWiki r98877]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98877. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r98877. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98877#c23742 Commit summary: Simplified script a bit with preg_replace. Tested with local

[MediaWiki-CodeReview] [MediaWiki r98476]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r98476. Old Status: fixme New Status: new User Jpostlethwaite also posted a comment on MediaWiki.r98476. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98476#c23744 Commit summary: Added GatewayForm::validateForm() so certain

[MediaWiki-CodeReview] [MediaWiki r98919]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98919. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98919 Commit summary: Fix r98904: use a date function that actually exists in the context (formats as ISO 8601)

[MediaWiki-CodeReview] [MediaWiki r98904]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r98904. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98904 Commit summary: Use wfTimestampNow() for more readable timestamps in the backup file names

[MediaWiki-CodeReview] [MediaWiki r98147]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r98147. Old Status: ok New Status: resolved User Reedy also posted a comment on MediaWiki.r98147. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98147#c23745 Commit summary: FU r98058 * Updated permission checks in attemptAddUser() so

[MediaWiki-CodeReview] [MediaWiki r98147]: New comment added

2011-10-04 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r98147. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98147#c23746 Commit summary: FU r98058 * Updated permission checks in attemptAddUser() so this right actually works * Added i18n message for right Comment: Blah. I was going to leave

[MediaWiki-CodeReview] [MediaWiki r98922]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r98922. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98922 Commit summary: Follwoup r98147 Can't use $this in a static context, not that the method is there anyway...

[MediaWiki-CodeReview] [MediaWiki r98914]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User Meno25 changed the status of MediaWiki.r98914. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98914 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net ___

[MediaWiki-CodeReview] [MediaWiki r98926]: New comment added, and revision status changed

2011-10-04 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r98926. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r98926. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98926#c23747 Commit summary: MFT r96211 Comment: Just out of curiosity, was there a reason

[MediaWiki-CodeReview] [MediaWiki r98925]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r98925. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98925 Commit summary: Fixed usage message ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r75910]: Revision status changed

2011-10-04 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r75910. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75910 Commit summary: Removed NoticePage.php, unused since r73102. Has bugs in, they are annoying me.

[MediaWiki-CodeReview] [MediaWiki r98892]: New comment added

2011-10-04 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r98892. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98892#c23748 Commit summary: Followup r98578 - expect nulls Comment: Should probably do one of the following: # throw an exception if given bogus non-string input, so we don't

[MediaWiki-CodeReview] [MediaWiki r98578]: New comment added

2011-10-04 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r98578. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98578#c23749 Commit summary: * (bug 12130) Initial newlines are now preserved correctly during editing HTML browsers strip the first newline from the literal contents of a

  1   2   >