[MediaWiki-CodeReview] [MediaWiki r99842]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Raymond" posted a comment on MediaWiki.r99842. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99842#c24701 Commit summary: Adding Sternograph extension Comment: * Please prefix all message keys with the extension name "sternograph-". This avoids key conflicts with MediaWi

[MediaWiki-CodeReview] [MediaWiki r100227]: New comment added

2011-10-21 Thread MediaWiki Mail
User "IAlex" posted a comment on MediaWiki.r100227. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100227#c24700 Commit summary: * Changed ParserOptions to store a Language object instead of only a string, avoids object -> string -> object conversion * ParserOptions::getUserLang(

[MediaWiki-CodeReview] [MediaWiki r100497]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Liangent" posted a comment on MediaWiki.r100497. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100497#c24699 Commit summary: Move styles in gadgets to the top of pages to avoid flash of unstyled content. Those styles should be loaded after site and user styles to keep B/C.

[MediaWiki-CodeReview] [MediaWiki r98210]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r98210. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98210#c24698 Commit summary: Add getSidebar method to BaseTemplate to simplify the sidebar boilerplate. Comment: Why are we backporting it to 1.18 to begin with? And also, why not 1

[MediaWiki-CodeReview] [MediaWiki r100327]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r100327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100327#c24697 Commit summary: * (bug 31441) Allow sysops to add/remove user group "autoreview" (as they can with "editor" already) * Doc comment tweaks Comment: Can you merge this

[MediaWiki-CodeReview] [MediaWiki r100327]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100327. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100327 Commit summary: * (bug 31441) Allow sysops to add/remove user group "autoreview" (as they can with "editor" already) * Doc comment tweaks _

[MediaWiki-CodeReview] [MediaWiki r100347]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100347. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100347 Commit summary: (bug 31345) document API Revisions parameters as enum Patch by Brad Jorsch. ___

[MediaWiki-CodeReview] [MediaWiki r97291]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r97291. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97291 Commit summary: Don't attempt to get a request url from a FauxRequest ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r100486]: New comment added, and revision status changed

2011-10-21 Thread MediaWiki Mail
User "Kaldari" changed the status of MediaWiki.r100486. Old Status: new New Status: ok User "Kaldari" also posted a comment on MediaWiki.r100486. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100486#c24696 Commit summary: Reverting r100476, due to the part where MWInit doesn't

[MediaWiki-CodeReview] [MediaWiki r100476]: New comment added, and revision status changed

2011-10-21 Thread MediaWiki Mail
User "Khorn (WMF)" changed the status of MediaWiki.r100476. Old Status: new New Status: reverted User "Khorn (WMF)" also posted a comment on MediaWiki.r100476. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100476#c24695 Commit summary: follow-up to r98202 - some comments and fi

[MediaWiki-CodeReview] [MediaWiki r98560]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r98560. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98560 Commit summary: Added path to extension's credits show that it can show SVN revision on Special:Version _

[MediaWiki-CodeReview] [MediaWiki r98603]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r98603. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98603 Commit summary: Reverted stuff from r98602 committed by mistake ___ MediaWiki-CodeReview mailing l

[MediaWiki-CodeReview] [MediaWiki r97427]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r97427. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97427 Commit summary: Modify 'image links' message used for the heading on the File-page showing entries in the mw_imagelinks table which contains p

[MediaWiki-CodeReview] [MediaWiki r93929]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r93929. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93929 Commit summary: CodeEditor ext: Add an experimental demo (off by default) mode to edit SyntaxHighlight_GeSHi sections inline using Ace e

[MediaWiki-CodeReview] [MediaWiki r98438]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r98438. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98438 Commit summary: add 'since' to petrb ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@li

[MediaWiki-CodeReview] [MediaWiki r98946]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r98946. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98946 Commit summary: Bug 31356 - [MirrorTools] Some api functions are not public Patch by Samuel Lampa _

[MediaWiki-CodeReview] [MediaWiki r99084]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r99084. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99084 Commit summary: * Use local context instead of global variables * Call Linker methods statically _

[MediaWiki-CodeReview] [MediaWiki r99541]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r99541. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99541 Commit summary: Add GENDER for group member. ___ MediaWiki-CodeReview mailing list mediawiki-coder

[MediaWiki-CodeReview] [MediaWiki r96325]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r96325. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96325 Commit summary: Cleanup to r95402, r95474: "Not using CamelCase is so 2001." ___ MediaWiki-C

[MediaWiki-CodeReview] [MediaWiki r98089]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r98089. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98089 Commit summary: Remove trailing whitespace in 'article-comments-talk-page-starter'. ___ MediaWiki-

Re: [Wikitech-l] File::getPath() refactoring

2011-10-21 Thread Russell Nelson
On Thu, Oct 20, 2011 at 2:39 PM, Brion Vibber wrote: > As Tim noted, the particular case in Special:Undelete is probably an > example > of old code using a lazy interface due to old assumptions, and should > actually be changed to use a proper File reference, and have a method to > call from the

[MediaWiki-CodeReview] [MediaWiki r100220]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Kaldari" changed the status of MediaWiki.r100220. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100220 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev..

[MediaWiki-CodeReview] [MediaWiki r99568]: New comment added, and revision status changed

2011-10-21 Thread MediaWiki Mail
User "Kaldari" changed the status of MediaWiki.r99568. Old Status: new New Status: fixme User "Kaldari" also posted a comment on MediaWiki.r99568. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99568#c24694 Commit summary: This time /really/ made TwoStepTwoColumn3 form RL friend

[MediaWiki-CodeReview] [MediaWiki r99555]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Kaldari" changed the status of MediaWiki.r99555. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99555 Commit summary: Correcting JS scope to play nicely with RL ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100480]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r100480. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100480#c24693 Commit summary: importing SemanticDataTypes extension Comment: svn:eol-style native ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98202]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r98202. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202#c24692 Commit summary: More refactoring work for the gateway adapters, mostly surrounding the special page itself. Comment: + if ( !strlen( $wgDonationInterfa

[MediaWiki-CodeReview] [MediaWiki r98563]: New comment added, and revision status changed

2011-10-21 Thread MediaWiki Mail
User "OverlordQ" changed the status of MediaWiki.r98563. Old Status: fixme New Status: new User "OverlordQ" also posted a comment on MediaWiki.r98563. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98563#c24691 Commit summary: Followup r98500, conversion of the Javascript to use

[MediaWiki-CodeReview] [MediaWiki r98202]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r98202. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202#c24690 Commit summary: More refactoring work for the gateway adapters, mostly surrounding the special page itself. Comment: Arggh, munged again! All s have to be closed to

[MediaWiki-CodeReview] [MediaWiki r98202]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r98202. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202#c24689 Commit summary: More refactoring work for the gateway adapters, mostly surrounding the special page itself. Comment: All s have to be closed to be valid XHTML.

[MediaWiki-CodeReview] [MediaWiki r98202]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r98202. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202#c24688 Commit summary: More refactoring work for the gateway adapters, mostly surrounding the special page itself. Comment: I fixed this issue in r100476.

[MediaWiki-CodeReview] [MediaWiki r98202]: New comment added, and revision status changed

2011-10-21 Thread MediaWiki Mail
User "Kaldari" changed the status of MediaWiki.r98202. Old Status: new New Status: fixme User "Kaldari" also posted a comment on MediaWiki.r98202. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202#c24687 Commit summary: More refactoring work for the gateway adapters, mostly s

[MediaWiki-CodeReview] [MediaWiki r100439]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100439. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100439 Commit summary: only show mail stuff for admins ___ MediaWiki-CodeReview mailing list mediawiki-

[MediaWiki-CodeReview] [MediaWiki r100258]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100258. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100258 Commit summary: follow up to r100251 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@

[MediaWiki-CodeReview] [MediaWiki r100278]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100278. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100278 Commit summary: Follow up to r100245; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...

[MediaWiki-CodeReview] [MediaWiki r100274]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100274. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100274 Commit summary: created basic reminder email functionality ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100276]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100276. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100276 Commit summary: up readme and install ___ MediaWiki-CodeReview mailing list mediawiki-coderev...

[MediaWiki-CodeReview] [MediaWiki r100295]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100295. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100295 Commit summary: fix bug 31833 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.w

[MediaWiki-CodeReview] [MediaWiki r100320]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100320. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100320 Commit summary: override toString method since the base class one does not handle objects in the params field, so goes mad when jobs are run

[MediaWiki-CodeReview] [MediaWiki r100324]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100324. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100324 Commit summary: fix rounding issues with votes ___ MediaWiki-CodeReview mailing list mediawiki-c

[MediaWiki-CodeReview] [MediaWiki r100427]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100427. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100427 Commit summary: Follow up to r100402; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...

[MediaWiki-CodeReview] [MediaWiki r100399]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100399. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100399 Commit summary: diplay submission url and added it to contestant pager ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100307]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100307. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100307 Commit summary: added subject to reminder email preview ___ MediaWiki-CodeReview mailing list me

[MediaWiki-CodeReview] [MediaWiki r100251]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100251. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100251 Commit summary: added days left field and initial work on reminder email UI ___ MediaWiki-C

[MediaWiki-CodeReview] [MediaWiki r100259]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100259. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100259 Commit summary: follow up to r100251; added missing file ___ MediaWiki-CodeReview mailing list m

[MediaWiki-CodeReview] [MediaWiki r100255]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100255. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100255 Commit summary: Tweak messages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...

[MediaWiki-CodeReview] [MediaWiki r100251]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100251. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100251 Commit summary: added days left field and initial work on reminder email UI ___ MediaWiki-CodeRe

[MediaWiki-CodeReview] [MediaWiki r100419]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100419. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100419 Commit summary: Fix r100302, r100255: remove duplicate "have", sent -> send, email -> e-mail ___

[MediaWiki-CodeReview] [MediaWiki r100316]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100316. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100316 Commit summary: minor fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wik

[MediaWiki-CodeReview] [MediaWiki r100438]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100438. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100438 Commit summary: follow up r100437 r100436 ___ MediaWiki-CodeReview mailing list mediawiki-

[MediaWiki-CodeReview] [MediaWiki r100442]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100442. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100442 Commit summary: fix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.o

[MediaWiki-CodeReview] [MediaWiki r100448]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100448. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100448 Commit summary: Localisation updates for core and extension messages from translatewiki.net __

[MediaWiki-CodeReview] [MediaWiki r100364]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100364. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100364 Commit summary: Localisation updates for core and extension messages from translatewiki.net __

[MediaWiki-CodeReview] [MediaWiki r98202]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r98202. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202#c24686 Commit summary: More refactoring work for the gateway adapters, mostly surrounding the special page itself. Comment: Erg, that got munged: Don't you want... if ( !$

[MediaWiki-CodeReview] [MediaWiki r98202]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r98202. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202#c24685 Commit summary: More refactoring work for the gateway adapters, mostly surrounding the special page itself. Comment: + if ( empty( $val ) ) { Don't yo

Re: [Wikitech-l] Coding challenge about to land. :)

2011-10-21 Thread John Erling Blad
Here is another "new" one, long time since I've been active on this list. I've been thinking that this coding challenge is a good idea, and I should probably try to whip together something. If I have the time. I like the idea of giving the reader an experience of pages in continuous change, but it

Re: [Wikitech-l] Coding challenge about to land. :)

2011-10-21 Thread Tomasz Finc
here is a snippet from an email that Erik send three days ago explaining Gregs role. subject: Heads up: Online coding challenge The overall project is being coordinated by Greg DeKoenigsberg, formerly Senior Community Architect at Red Hat. If you'd like to be involved as a judge, please let him k

[MediaWiki-CodeReview] [MediaWiki r100426]: New comment added, and revision status changed

2011-10-21 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r100426. Old Status: deferred New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r100426. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100426#c24684 Commit summary: Add patch which fixes pdfinfo to respe

Re: [Wikitech-l] Coding challenge about to land. :)

2011-10-21 Thread Patrick Reilly
Well, for the record the overall coding challenge project is being coordinated by Greg DeKoenigsberg, formerly Senior Community Architect at Red Hat. ;) — Patrick On Fri, Oct 21, 2011 at 4:02 PM, Platonides wrote: > Greg DeKoenigsberg wrote: >> No. You'd sound like an ideal tester hitting a use

[MediaWiki-CodeReview] [MediaWiki r100472]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r100472. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100472 Commit summary: Even more fixes for all the custom filters extras. r100455, r100249, r100466 _

[MediaWiki-CodeReview] [MediaWiki r100466]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r100466. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100466 Commit summary: Fixes for all the custom filters extras. r100455, r100249 ___ MediaWiki-Co

Re: [Wikitech-l] Coding challenge about to land. :)

2011-10-21 Thread Platonides
Greg DeKoenigsberg wrote: > No. You'd sound like an ideal tester hitting a use case we didn't even > consider. Will look into it. > > --g I don't want to sound harsh, Greg but... who are you? It seems it's the first time you post here, yet your email is written as if you were in charge of this.

[MediaWiki-CodeReview] [MediaWiki r99264]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r99264. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99264 Commit summary: MFT r99231: upgrade jQuery to 1.6.4, should work around IE8 crashing bug ___ Media

[MediaWiki-CodeReview] [MediaWiki r99631]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r99631. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99631 Commit summary: Add basic contact info for Zack ___ MediaWiki-CodeReview mailing list mediawiki-co

[MediaWiki-CodeReview] [MediaWiki r99771]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r99771. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99771 Commit summary: Adding my USERINFO file cervidae ___ MediaWiki-CodeReview mailing list mediawiki-c

[MediaWiki-CodeReview] [MediaWiki r98519]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r98519. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98519 Commit summary: follow up to r98488; fixing compat of calendar format ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r95923]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Khorn (WMF)" posted a comment on MediaWiki.r95923. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95923#c24683 Commit summary: More refactoring. The new globalcollect gateway is now inheriting from the common gateway abstract class. (Also cleaned up the formatting more than

[MediaWiki-CodeReview] [MediaWiki r98008]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r98008. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98008 Commit summary: MFT r93896 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikime

[MediaWiki-CodeReview] [MediaWiki r76095]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r76095. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76095 Commit summary: wikimedia-task-appserver (1.46) hardy; urgency=low * Removed all configuration out of this package, into Puppet _

[MediaWiki-CodeReview] [MediaWiki r100450]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r100450. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100450 Commit summary: up install with new settings ___ MediaWiki-CodeReview mailing list mediawi

[MediaWiki-CodeReview] [MediaWiki r100074]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Khorn (WMF)" posted a comment on MediaWiki.r100074. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100074#c24682 Commit summary: Preventing notices from unset indices in arrays. Comment: In any case, instead of setting an arbitrary default value, it should throw an except

[MediaWiki-CodeReview] [MediaWiki r100074]: New comment added, and revision status changed

2011-10-21 Thread MediaWiki Mail
User "Khorn (WMF)" changed the status of MediaWiki.r100074. Old Status: new New Status: fixme User "Khorn (WMF)" also posted a comment on MediaWiki.r100074. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100074#c24681 Commit summary: Preventing notices from unset indices in arra

[MediaWiki-CodeReview] [MediaWiki r100456]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" posted a comment on MediaWiki.r100456. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100456#c24680 Commit summary: Reallocating fields in forms: payment_method. Adding fields: payment_submethod. Removing fields: process, transaction_type (transaction_type i

[MediaWiki-CodeReview] [MediaWiki r100095]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r100095. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100095 Commit summary: changing from double quotes to single quotes, leaving a note for myself __

[MediaWiki-CodeReview] [MediaWiki r100076]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r100076. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100076 Commit summary: Fixed the ACTION parameter for BANK_TRANSFER. Value is now set to INSERT_ORDERWITHPAYMENT. __

Re: [Wikitech-l] Welcome, Antoine Musso! (hashar)

2011-10-21 Thread Platonides
Rob Lanphier wrote: > He has been working in our community > for quite some time, going by the name "Ashar Voultoiz" on mailing > lists, and by "hashar" on IRC.Now that he's working as a > contractor for WMF, he's decided to let everyone know the Superman > behind the Clark Kent alter ego :)

[MediaWiki-CodeReview] [MediaWiki r99836]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r99836. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99836#c24679 Commit summary: Bug 31624 - DB error on addwiki command: Column 'si_title' cannot be part of FULLTEXT index Kill searchindex table in 1.18wmf1, we don't need/use it Co

[MediaWiki-CodeReview] [MediaWiki r100071]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r100071. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100071 Commit summary: Fixed validation to ignore zip code if a state is explicitly not selected (set to "Outside the United States") __

[MediaWiki-CodeReview] [MediaWiki r100047]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r100047. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100047 Commit summary: Changed hidden process element to be BANK_TRANSFER. ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r100046]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r100046. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100046 Commit summary: Changed hidden process element to accept custom values. ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r99836]: New comment added, and revision status changed

2011-10-21 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r99836. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r99836. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99836#c24678 Commit summary: Bug 31624 - DB error on addwiki command: Colum

[MediaWiki-CodeReview] [MediaWiki r100045]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r100045. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100045 Commit summary: Enabled PAYMENTPRODUCTID for BANK_TRANSFER ___ MediaWiki-CodeReview mailin

[MediaWiki-CodeReview] [MediaWiki r99804]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r99804. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99804 Commit summary: escaping input to prevent XSS ___ MediaWiki-CodeReview mailing list media

[MediaWiki-CodeReview] [MediaWiki r99806]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r99806. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99806 Commit summary: we should still be able to display the entered amountOther amount even if we dont ultimately use it

[MediaWiki-CodeReview] [MediaWiki r99715]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r99715. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99715 Commit summary: Documentation Swap a lot of "@returns" to "@return" ___ MediaWiki-CodeRevie

[MediaWiki-CodeReview] [MediaWiki r99825]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r99825. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99825 Commit summary: making api testable with bogus data ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99830]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r99830. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99830 Commit summary: follow-up to r99825, improving test functions ___ MediaWiki-CodeReview ma

[MediaWiki-CodeReview] [MediaWiki r99834]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r99834. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99834 Commit summary: fixing path for Form.css, adding lightbox1 form ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100068]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100068. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100068 Commit summary: Reverting my completely unnecessary r100054. ___ MediaWiki-CodeReview m

[MediaWiki-CodeReview] [MediaWiki r99589]: New comment added, and revision status changed

2011-10-21 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r99589. Old Status: new New Status: fixme User "Awjrichards" also posted a comment on MediaWiki.r99589. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99589#c24677 Commit summary: Prevents us from dying (no, really). Instead, th

[MediaWiki-CodeReview] [MediaWiki r100430]: New comment added

2011-10-21 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r100430. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100430#c24676 Commit summary: * Call Linker methods statically * Removed now-useless parameter RevisionDeleter::getLogLinks(), updated the only caller Comment: Fatal error: f

[MediaWiki-CodeReview] [MediaWiki r100119]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100119. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100119 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. Starting the process by moving base files to th

[MediaWiki-CodeReview] [MediaWiki r100120]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100120. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100120 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. Removing unused empty directories from the fund

[MediaWiki-CodeReview] [MediaWiki r100121]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100121. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100121 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. Removing now-redundant files. As this is a mid-

[MediaWiki-CodeReview] [MediaWiki r100123]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100123. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100123 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. Adding all the directories which are completely

[MediaWiki-CodeReview] [MediaWiki r100124]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100124. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100124 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. Adding all the directories which are completely

[MediaWiki-CodeReview] [MediaWiki r100132]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100132. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100132 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. Relatively straightforward merge changes, with

[MediaWiki-CodeReview] [MediaWiki r100133]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100133. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100133 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. Verified that payflowpro_gateway.body.php did i

[MediaWiki-CodeReview] [MediaWiki r100157]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100157. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100157 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. Removing a duplicate directory from the fundrai

[MediaWiki-CodeReview] [MediaWiki r100163]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100163. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100163 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. This round handles merging the content of all t

[MediaWiki-CodeReview] [MediaWiki r100168]: Revision status changed

2011-10-21 Thread MediaWiki Mail
User "Jpostlethwaite" changed the status of MediaWiki.r100168. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100168 Commit summary: Merging the fundraising branch of DonationInterface back into trunk. Copies the form-related includes directory to i

  1   2   >