[MediaWiki-CodeReview] [MediaWiki r102736]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Pgehres (WMF)" changed the status of MediaWiki.r102736. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102736 Commit summary: adding message for credit/debit card button ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r102752]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Pgehres (WMF)" changed the status of MediaWiki.r102752. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102752 Commit summary: switching city and postal code for sofo-GB form and enets form ___ Media

[Wikitech-l] en-CA in MediaWiki? Rethinking our method of handling translation bugs?

2011-11-10 Thread Daniel Friesen
A few months ago I opened a bug asking for en-CA support in MediaWiki: https://bugzilla.wikimedia.org/show_bug.cgi?id=31016 For reference en-CA is neither strictly en-US or en-GB. en-CA uses some spellings en-GB use and in other cases some spellings that en-US use, and there are a slight few e

Re: [Wikitech-l] 1.18 PHP version requirement

2011-11-10 Thread Petr Bena
I was assuming that warning wouldn't prevent user from being able to use mw on old php, as Chad explained, in case that it would be impossible to use it there, indeed it would be problem. I think that it should be possible to create some alternative way to install mediawiki for those users (since i

Re: [Wikitech-l] 1.18 PHP version requirement

2011-11-10 Thread MZMcBride
Petr Bena wrote: > php is freeware so upgrade shouldn't be problem for anyone Upgrading is a problem for a lot of people. Shared hosting is problematic in particular. If there are unavoidable issues (5.3.1), it's a different story, of course. MZMcBride

[MediaWiki-CodeReview] [MediaWiki r92279]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Bawolff" changed the status of MediaWiki.r92279. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92279 Commit summary: (bug 28762) Resizing to specified height broken for very thin images Restructure and comment of ImageHandler::normalis

[MediaWiki-CodeReview] [MediaWiki r97671]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Bawolff" changed the status of MediaWiki.r97671. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97671 Commit summary: * (bug 6672, 31024) Fixes for handling of images with an EXIF orientation - sets an image's reported width/height to t

[MediaWiki-CodeReview] [MediaWiki r102750]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r102750. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102750 Commit summary: Update xcache url since the old url redirects to the lighttpd redmine homepage instead of anything related to xcache.

[MediaWiki-CodeReview] [MediaWiki r102751]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Bawolff" posted a comment on MediaWiki.r102751. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102751#c25885 Commit summary: (follow-up r99910) Make $wgEnableAutoRotation work... Also unit-tests. There's a bit of duplication in the unit tests, and I wasn't sure if there wa

[Wikitech-l] Input requested: Delay 1.18?

2011-11-10 Thread Mark A. Hershberger
Yesterday a friend of mine discovered and filed a bug that highlights a backwards incompatibility introduced by 1.18. The bug is "Moved ArticleSave hook breaks backward compatibility" (https://bugzilla.wikimedia.org/32318). I found a number of public functions in the Article class that are not d

Re: [Wikitech-l] Medium-sized gadget project: Consolidated diffs

2011-11-10 Thread Jeremy Baron
On Thu, Nov 10, 2011 at 21:54, Erik Moeller wrote: > Yeah, I remember those. Animating page history is cool, but not quite > what the professors need for the review of students' contribs. I used > the word "sequence" ambiguously -- here's what I mean: > [...] I'm confused. What is the expected ap

Re: [Wikitech-l] Front-end devs needed to fix MediaWiki 1.18 release blockers

2011-11-10 Thread Mark A. Hershberger
Brion Vibber writes: > Looks like WikiEditor on 1.17 had about the same behavior (though > significantly worse, as the 'window tall enough' cases still didn't work > consistently). I've removed https://bugzilla.wikimedia.org/32241 from the "1.18.0 release" milestone as a result. Thanks for such

[MediaWiki-CodeReview] [MediaWiki r97404]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r97404. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97404 Commit summary: Move the mediawiki.test.bug30825.js helper script out of the /suites/ directory into /data/ and rename to be mor

Re: [Wikitech-l] Medium-sized gadget project: Consolidated diffs

2011-11-10 Thread Erik Moeller
On Thu, Nov 10, 2011 at 2:13 PM, Neil Kandalgaonkar wrote: > I was interested in this a while back too... turns out Andy Baio sponsored a > contest to do just this back in 2005. Yeah, I remember those. Animating page history is cool, but not quite what the professors need for the review of studen

[MediaWiki-CodeReview] [MediaWiki r102733]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102733. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102733 Commit summary: Adding B-US form for GC testing in the US vs PFP-B ___ MediaWiki-CodeRevie

Re: [Wikitech-l] Front-end devs needed to fix MediaWiki 1.18 release blockers

2011-11-10 Thread Brion Vibber
On Thu, Nov 10, 2011 at 5:07 PM, Brion Vibber wrote: > On Wed, Nov 9, 2011 at 12:05 PM, Rob Lanphier wrote: > >> WikiEditor scrolls the browser and does not insert on IE8 on Windows 7 >> https://bugzilla.wikimedia.org/32241 >> >> Reported November 7, but repro'd on three different machines. Thi

[MediaWiki-CodeReview] [MediaWiki r101601]: New comment added

2011-11-10 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r101601. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101601#c25884 Commit summary: add method to fetch categories of a title. remove some useless code making sure undefined stuff was undefined. Comment: done in r102730

[MediaWiki-CodeReview] [MediaWiki r101602]: New comment added

2011-11-10 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r101602. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101602#c25883 Commit summary: validation of custom license wikitext, including basic parsing, checking that templates exist, and that they are descendants of a particular category

Re: [Wikitech-l] Front-end devs needed to fix MediaWiki 1.18 release blockers

2011-11-10 Thread Brion Vibber
On Wed, Nov 9, 2011 at 12:05 PM, Rob Lanphier wrote: > WikiEditor scrolls the browser and does not insert on IE8 on Windows 7 > https://bugzilla.wikimedia.org/32241 > > Reported November 7, but repro'd on three different machines. This > seems like a problem we should also be fixing in deploymen

Re: [Wikitech-l] Front-end devs needed to fix MediaWiki 1.18 release blockers

2011-11-10 Thread Brion Vibber
On Wed, Nov 9, 2011 at 12:05 PM, Rob Lanphier wrote: > Unable to add/remove buttons from (classic) toolbar from a gadget > after MW update > https://bugzilla.wikimedia.org/31511 > > It's actually not clear to me that this should be a 1.18 release > blocker. It's a problem that seems to have occu

[MediaWiki-CodeReview] [MediaWiki r102729]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102729. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102729 Commit summary: Handling error as an array with implode ___ MediaWiki-CodeReview mailing l

[MediaWiki-CodeReview] [MediaWiki r97468]: New comment added, and revision status changed

2011-11-10 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97468. Old Status: ok New Status: fixme User "^demon" also posted a comment on MediaWiki.r97468. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97468#c25882 Commit summary: Committing another live hack for which I'm tired of getting

[MediaWiki-CodeReview] [MediaWiki r97468]: New comment added, and revision status changed

2011-11-10 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r97468. Old Status: new New Status: ok User "Aaron Schulz" also posted a comment on MediaWiki.r97468. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97468#c25881 Commit summary: Committing another live hack for which I'm tired

[MediaWiki-CodeReview] [MediaWiki r97564]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r97564. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97564#c25880 Commit summary: Removed duplication in insertArticleLink Comment: I don't think it's needed. ___ MediaWiki-CodeRevie

[MediaWiki-CodeReview] [MediaWiki r102714]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Khorn (WMF)" changed the status of MediaWiki.r102714. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102714 Commit summary: Fixing mime-types for BPAY images, followup r102550 ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r102698]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102698. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102698 Commit summary: Adding rtbt-ideal and adding js for rtbt that allows for amount selection on 2nd step ___

[MediaWiki-CodeReview] [MediaWiki r97628]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r97628. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97628#c25879 Commit summary: Use LinkBatch, instead of trying doing it manually and incompletely as it gets out of sync. Adds one or two queries, but that shouldn't be a probl

[MediaWiki-CodeReview] [MediaWiki r102707]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102707. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102707 Commit summary: Adding images to the other rtbt forms. Resizing eps-square ___ MediaWiki-C

[MediaWiki-CodeReview] [MediaWiki r102712]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102712. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102712 Commit summary: Adding amount switching to all rtbt forms. Added GB form since they just have to be different ___

[MediaWiki-CodeReview] [MediaWiki r102711]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102711. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102711 Commit summary: Adding webitects_2_2stepB for testing against old forms ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r102590]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102590. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102590 Commit summary: Adding B form for A/B testing in the US ___ MediaWiki-CodeReview mailing l

[MediaWiki-CodeReview] [MediaWiki r102723]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r102723. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102723 Commit summary: RELEASE-NOTES-1.19 for r102722 ___ MediaWiki-CodeReview mailing list mediawiki

[MediaWiki-CodeReview] [MediaWiki r101347]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r101347. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101347 Commit summary: [RL2] Fix bug where shared gadget preferences weren't saved because 'default' was set to an empty array. This raises the q

[MediaWiki-CodeReview] [MediaWiki r101347]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r101347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101347#c25878 Commit summary: [RL2] Fix bug where shared gadget preferences weren't saved because 'default' was set to an empty array. This raises the question of whether we shoul

[MediaWiki-CodeReview] [MediaWiki r101343]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r101343. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101343 Commit summary: [RL2] Make sure that getForeignGadgetsData() and getForeignGadgetCategories() only call their error callback once. __

[MediaWiki-CodeReview] [MediaWiki r101342]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r101342. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101342 Commit summary: [RL2] Also get the description in mw.gadgets.api ___ MediaWiki-CodeReview mail

[MediaWiki-CodeReview] [MediaWiki r101340]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r101340. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101340 Commit summary: [RL2] Remove TODO that was addressed in r100970 ___ MediaWiki-CodeReview maili

[MediaWiki-CodeReview] [MediaWiki r102498]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r102498. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102498 Commit summary: Comments out console.log calls Catched by Schnark on CR of r102303 ___

[MediaWiki-CodeReview] [MediaWiki r102703]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102703. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102703 Commit summary: Switching payflowpro forms to the proper appeal and header text locations

[MediaWiki-CodeReview] [MediaWiki r102702]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102702. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102702 Commit summary: add logos for sofort and eps ___ MediaWiki-CodeReview mailing list mediawi

[MediaWiki-CodeReview] [MediaWiki r102701]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102701. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102701 Commit summary: Fixing case sensitivity on iDEAL image ___ MediaWiki-CodeReview mailing li

[MediaWiki-CodeReview] [MediaWiki r102700]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102700. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102700 Commit summary: Switching rtbt forms to the proper appeal and header text locations ___ Me

[MediaWiki-CodeReview] [MediaWiki r102689]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102689. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102689 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r102682]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102682. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102682 Commit summary: Removed post process hooks to disable stomp messages for not credit card type payments. _

[MediaWiki-CodeReview] [MediaWiki r102664]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102664. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102664 Commit summary: Spaces to tabs. Changed donate_interface-rt-button per r102566 CR proposal. __

[MediaWiki-CodeReview] [MediaWiki r102611]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102611. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102611 Commit summary: add iDeal logo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@

[MediaWiki-CodeReview] [MediaWiki r102580]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102580. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102580 Commit summary: Added comment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@

[MediaWiki-CodeReview] [MediaWiki r102578]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102578. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102578 Commit summary: Fixed bad variable name in documentation. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r102566]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102566. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102566 Commit summary: Adding bt-button and rt-button to interface messages. ___ MediaWiki-CodeRe

[MediaWiki-CodeReview] [MediaWiki r102563]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102563. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102563 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r102550]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102550. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102550 Commit summary: Add BPAY logos ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@

[MediaWiki-CodeReview] [MediaWiki r102596]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102596. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102596 Commit summary: Renaming files to remove spaces. See r102550. ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r102594]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102594. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102594 Commit summary: Renaming files to remove spaces. See r102550. ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r102713]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102713. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102713 Commit summary: quick fix for object/array issue ___ MediaWiki-CodeReview mailing list med

[MediaWiki-CodeReview] [MediaWiki r102470]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102470. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102470 Commit summary: It is unnecessary to check if the variable exists. This is done a little earlier in the code. See r100074. __

[MediaWiki-CodeReview] [MediaWiki r102469]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102469. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102469 Commit summary: Simplfying method getTransactionDataLanguage(). See r101956. ___ MediaWiki

[MediaWiki-CodeReview] [MediaWiki r102468]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102468. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102468 Commit summary: Adding support for internal messages ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r102467]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102467. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102467 Commit summary: Enabling credit cards in TwoStepAmount form. ___ MediaWiki-CodeReview mail

[MediaWiki-CodeReview] [MediaWiki r102341]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102341. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102341 Commit summary: Added placeholder for Do bank validation error messages in $this->error_map. Added keys to payment_submethods. Updated

[MediaWiki-CodeReview] [MediaWiki r102342]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102342. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102342 Commit summary: Modified direct debit to properly check status. See r102341. ___ MediaWiki

[MediaWiki-CodeReview] [MediaWiki r102710]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r102710. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102710#c25877 Commit summary: on tablesort, verify is the first child in the table r102303 tried to compare the whole table when bug 32047 only require we have as a first child.

[MediaWiki-CodeReview] [MediaWiki r102445]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102445. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102445 Commit summary: Fixed spelling mistake. ___ MediaWiki-CodeReview mailing list mediawiki-co

[MediaWiki-CodeReview] [MediaWiki r102303]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Hashar" changed the status of MediaWiki.r102303. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102303 Commit summary: tests for bug 32047 / r102301 In table with class="sortable", thead is before caption _

[MediaWiki-CodeReview] [MediaWiki r102303]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r102303. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102303#c25876 Commit summary: tests for bug 32047 / r102301 In table with class="sortable", thead is before caption Comment: In Firefox, the attributes 'title' and 'class' comes

[MediaWiki-CodeReview] [MediaWiki r102338]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r102338. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102338 Commit summary: Updating required fields for direct debit. ___ MediaWiki-CodeReview mailin

[MediaWiki-CodeReview] [MediaWiki r102699]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Raindrift" changed the status of MediaWiki.r102699. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102699 Commit summary: log parsing errors, and ensure we can parse templates with names like "Cc-by-sa-3.0" __

[MediaWiki-CodeReview] [MediaWiki r102694]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Raindrift" changed the status of MediaWiki.r102694. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102694 Commit summary: give up on auto-centering, does not work for templates with width=100%. Look up template with exact case. Recognize self

[MediaWiki-CodeReview] [MediaWiki r101644]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r101644. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101644#c25875 Commit summary: (bug 31822) Error during upgrade due to output buffer reset in stdout. In various places in Maintenance, we're overwriting our output buffer rat

[MediaWiki-CodeReview] [MediaWiki r101644]: New comment added

2011-11-10 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r101644. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101644#c25874 Commit summary: (bug 31822) Error during upgrade due to output buffer reset in stdout. In various places in Maintenance, we're overwriting our output buffer rather t

[MediaWiki-CodeReview] [MediaWiki r102693]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Raindrift" changed the status of MediaWiki.r102693. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102693 Commit summary: preserve exact case of templates ___ MediaWiki-CodeReview mailing list media

[MediaWiki-CodeReview] [MediaWiki r101644]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r101644. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101644#c25873 Commit summary: (bug 31822) Error during upgrade due to output buffer reset in stdout. In various places in Maintenance, we're overwriting our output buffer rat

[MediaWiki-CodeReview] [MediaWiki r102697]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Bawolff" posted a comment on MediaWiki.r102697. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102697#c25872 Commit summary: MFT r45856, r71558, r71962, r73304, r73309, r75671, r75680, r75726, r76542, r76675, r77056, r77084, r77248, r77299, r77345, r77371, r77399, r77506, r

Re: [Wikitech-l] Medium-sized gadget project: Consolidated diffs

2011-11-10 Thread Neil Kandalgaonkar
I was interested in this a while back too... turns out Andy Baio sponsored a contest to do just this back in 2005. http://waxy.org/2005/06/wikipedia_histo/ John Resig (author of jQuery) submitted this: http://ejohn.org/projects/aniwiki/ Some months ago, I fiddled with AniWiki but didn'

Re: [Wikitech-l] Brighton & Mumbai meetups this month

2011-11-10 Thread Sumana Harihareswara
On 10/31/2011 04:05 PM, Sumana Harihareswara wrote: > Just to remind you: > > * India hackathon (18–20 November, Mumbai, India) — Alolita Sharma, > Siebrand Mazeland, Sumana Harihareswara and the local India team are > preparing for this event, which will focus on language, mobile and > offline su

[MediaWiki-CodeReview] [MediaWiki r102697]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Awjrichards" posted a comment on MediaWiki.r102697. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102697#c25871 Commit summary: MFT r45856, r71558, r71962, r73304, r73309, r75671, r75680, r75726, r76542, r76675, r77056, r77084, r77248, r77299, r77345, r77371, r77399, r7750

[MediaWiki-CodeReview] [MediaWiki r102697]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Bawolff" posted a comment on MediaWiki.r102697. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102697#c25870 Commit summary: MFT r45856, r71558, r71962, r73304, r73309, r75671, r75680, r75726, r76542, r76675, r77056, r77084, r77248, r77299, r77345, r77371, r77399, r77506, r

[MediaWiki-CodeReview] [MediaWiki r102624]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Olivier Beaton" posted a comment on MediaWiki.r102624. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102624#c25869 Commit summary: Add a new User::getDisplayName() to return the name that should be displayed in the interface. Add a UserDisplayName hook to allow extensions

Re: [Wikitech-l] 1.18 PHP version requirement

2011-11-10 Thread Platonides
Antoine Musso wrote: > Hello, > > PHP 5.2.6 and earlier have a bugs that prevents us from appending text > to php://stdout . See [PHP 45303]. > > We need to open php:// file descriptors in append mode (a) when running > the web installer or we have a nice error caused by the output buffer > be

[Wikitech-l] Medium-sized gadget project: Consolidated diffs

2011-11-10 Thread Erik Moeller
The WMF folks organizing education programs around the world (where students improve Wikipedia articles as an assignment) are looking for better tools for professors to review student contribs. One of the needs that's come up is a more user-friendly, consolidated view of all changes made by a user

[MediaWiki-CodeReview] [MediaWiki r102674]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Hashar" changed the status of MediaWiki.r102674. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102674 Commit summary: Revert r102650, r102640. Caused breakage on translatewiki.net: No localisation cache found for English. Please run mainten

[MediaWiki-CodeReview] [MediaWiki r102687]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Freakolowsky" posted a comment on MediaWiki.r102687. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102687#c25868 Commit summary: * sry about that :S ... 10x Aaron Comment: It's CODE review not comment review :D and if i had those 30 seconds i'd recheck the code and not m

[MediaWiki-CodeReview] [MediaWiki r101989]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r101989. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101989#c25867 Commit summary: eol w/s Comment: Co-incidence? Some sort of local conflict? ___ MediaWiki-CodeReview mailing list mediawi

[MediaWiki-CodeReview] [MediaWiki r101989]: New comment added, and revision status changed

2011-11-10 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r101989. Old Status: ok New Status: fixme User "Siebrand" also posted a comment on MediaWiki.r101989. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101989#c25866 Commit summary: eol w/s Comment: Why on earth would this break uni

[MediaWiki-CodeReview] [MediaWiki r102687]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Johnduhart" posted a comment on MediaWiki.r102687. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102687#c25865 Commit summary: * sry about that :S ... 10x Aaron Comment: Can we please take the addtional 30 seconds needed to type out words fully and not say things like 's

[MediaWiki-CodeReview] [MediaWiki r102303]: New comment added, and revision status changed

2011-11-10 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r102303. Old Status: new New Status: fixme User "Siebrand" also posted a comment on MediaWiki.r102303. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102303#c25864 Commit summary: tests for bug 32047 / r102301 In table with class=

[MediaWiki-CodeReview] [MediaWiki r102677]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Freakolowsky" changed the status of MediaWiki.r102677. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102677 Commit summary: * fix as per comment on CR r102625#c25856 ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r101644]: New comment added

2011-11-10 Thread MediaWiki Mail
User "G.Hagedorn" posted a comment on MediaWiki.r101644. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101644#c25863 Commit summary: (bug 31822) Error during upgrade due to output buffer reset in stdout. In various places in Maintenance, we're overwriting our output buffer rathe

[MediaWiki-CodeReview] [MediaWiki r102624]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r102624. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102624#c25862 Commit summary: Add a new User::getDisplayName() to return the name that should be displayed in the interface. Add a UserDisplayName hook to allow extensions to g

[MediaWiki-CodeReview] [MediaWiki r102673]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r102673. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102673 Commit summary: [WebFonts] minor whitespace and conventions - single quotes - spacing - sentence case comments (//foo => // Foo) - remov

[MediaWiki-CodeReview] [MediaWiki r102669]: New comment added, and revision status changed

2011-11-10 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r102669. Old Status: new New Status: fixme User "Nikerabbit" also posted a comment on MediaWiki.r102669. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102669#c25861 Commit summary: Adding Dutch messages and removing translations

[MediaWiki-CodeReview] [MediaWiki r102624]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Dantman" posted a comment on MediaWiki.r102624. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102624#c25860 Commit summary: Add a new User::getDisplayName() to return the name that should be displayed in the interface. Add a UserDisplayName hook to allow extensions to give

[MediaWiki-CodeReview] [MediaWiki r102658]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r102658. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102658#c25859 Commit summary: Whitespace changes, naming convention fixes. As per https://www.mediawiki.org/wiki/User:Krinkle/Extension_review/WebFonts#Code_conventions Commen

[MediaWiki-CodeReview] [MediaWiki r102624]: New comment added

2011-11-10 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r102624. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102624#c25858 Commit summary: Add a new User::getDisplayName() to return the name that should be displayed in the interface. Add a UserDisplayName hook to allow extensions to g

[MediaWiki-CodeReview] [MediaWiki r102677]: New comment added, and revision status changed

2011-11-10 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r102677. Old Status: new New Status: fixme User "Aaron Schulz" also posted a comment on MediaWiki.r102677. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102677#c25857 Commit summary: * fix as per comment on CR r102625#c25856

Re: [Wikitech-l] Etherpad(s)-lite on MediaWiki page(s) [ok]

2011-11-10 Thread Neil Kandalgaonkar
Cool! I had a hack that did something similar, and then worked on integrating it directly into WikiEditor, but got bogged down and have been on other projects. Our hack also "exports" your MediaWiki login identity directly into Etherpad (not lite, alas). I talked about it back in May at WMDE.

[Wikitech-l] Etherpad(s)-lite on MediaWiki page(s) [ok]

2011-11-10 Thread Thomas Gries
Today I /successfully /integrated Etherpad-lite - one or several "pads" - on MediaWiki pages. I plan to publish this as an MediaWiki:Extension soon. Tom ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/list

[MediaWiki-CodeReview] [MediaWiki r102625]: New comment added, and revision status changed

2011-11-10 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r102625. Old Status: new New Status: fixme User "Aaron Schulz" also posted a comment on MediaWiki.r102625. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102625#c25856 Commit summary: * Added getInfinity to DatabaseOracle * Blo

[MediaWiki-CodeReview] [MediaWiki r102555]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Raindrift" changed the status of MediaWiki.r102555. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102555 Commit summary: check for fileApi more thoroughly, to fix Safari isues ___ MediaWiki-CodeRev

[MediaWiki-CodeReview] [MediaWiki r102554]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Raindrift" changed the status of MediaWiki.r102554. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102554 Commit summary: missing variable error->err ___ MediaWiki-CodeReview mailing list mediawiki-

[MediaWiki-CodeReview] [MediaWiki r102473]: Revision status changed

2011-11-10 Thread MediaWiki Mail
User "Raindrift" changed the status of MediaWiki.r102473. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102473 Commit summary: typos in category methods -- error callbacks renamed ___ MediaWiki-CodeRevie

  1   2   3   >