[MediaWiki-CodeReview] [MediaWiki r101667]: New comment added

2011-12-22 Thread MediaWiki Mail
"Aaron Schulz" posted a comment on MediaWiki.r101667. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101667#c28400 Commit summary for MediaWiki.r101667: * Let HTMLFileCache constructor take in a Title *or* a the prefixed dbkey itself. * Tweaked filecache fallback in fileCachedPage() t

[MediaWiki-CodeReview] [MediaWiki r107135]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r107135 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107135 Old status: new > New status: ok Commit summary for MediaWiki.r107135: * Fix for bug 1, r67994: be much more aggressive in splitting punctuation into "words". Re-

[MediaWiki-CodeReview] [MediaWiki r102523]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"MaxSem" changed the status of MediaWiki.r102523 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102523 Old status: new > New status: ok Commit summary for MediaWiki.r102523: * phpunit fixes & optimizations for oracle backend ___ Me

[MediaWiki-CodeReview] [MediaWiki r101667]: New comment added

2011-12-22 Thread MediaWiki Mail
"MaxSem" posted a comment on MediaWiki.r101667. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101667#c28399 Commit summary for MediaWiki.r101667: * Let HTMLFileCache constructor take in a Title *or* a the prefixed dbkey itself. * Tweaked filecache fallback in fileCachedPage() to try

[MediaWiki-CodeReview] [MediaWiki r107119]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Santhosh.thottingal" changed the status of MediaWiki.r107119 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107119 Old status: new > New status: ok Commit summary for MediaWiki.r107119: rephrase r106992 release notes ___ MediaWiki

[MediaWiki-CodeReview] [MediaWiki r106992]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Santhosh.thottingal" changed the status of MediaWiki.r106992 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106992 Old status: new > New status: ok Commit summary for MediaWiki.r106992: [Core JS] mw.util.addCSS: Insert style tag into dom before setting cssText * Fixes bug 33

Re: [Wikitech-l] Making the Lua/Javascript decision (Re: Performance roadmap update)

2011-12-22 Thread Victor Vasiliev
On Fri, Dec 23, 2011 at 9:54 AM, Dmitriy Sintsov wrote: > Victor, what do you think about making WikiScripts syntax more similar > to the subset of Lua or JavaScript syntax? That probably should not be > too hard? It is already almost a JavaScript subset > What's about cross-translating to PHP th

[MediaWiki-CodeReview] [MediaWiki r98405]: New comment added

2011-12-22 Thread MediaWiki Mail
"Tim Starling" posted a comment on MediaWiki.r98405. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98405#c28398 Commit summary for MediaWiki.r98405: HTMLFileCache refactoring: * Rewrote class and split into three classes: a base class, and html cache and a more generic cache to be us

[MediaWiki-CodeReview] [MediaWiki r98698]: New comment added

2011-12-22 Thread MediaWiki Mail
"Tim Starling" posted a comment on MediaWiki.r98698. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98698#c28397 Commit summary for MediaWiki.r98698: FileCache: * Added FileCacheBase::*MissesRecent() functions for counting cache misses from different visitors. * Made ObjectFileCache m

[MediaWiki-CodeReview] [MediaWiki r98030]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Tim Starling" changed the status of MediaWiki.r98030 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98030 Old status: new > New status: ok Commit summary for MediaWiki.r98030: Article refactoring and changes for bug 31144. Dependency inject ParserOutput objects in some plac

Re: [Wikitech-l] Making the Lua/Javascript decision (Re: Performance roadmap update)

2011-12-22 Thread Dmitriy Sintsov
* Victor Vasiliev [Fri, 23 Dec 2011 09:46:46 +0400]: > On Fri, Dec 23, 2011 at 9:26 AM, Dmitriy Sintsov > wrote: > > Also it would be great if WikiScripts or Lua extension allowed to > easily > > bind functions / class wrappers for another MediaWiki extensions. The > > extension I develop uses P

Re: [Wikitech-l] Making the Lua/Javascript decision (Re: Performance roadmap update)

2011-12-22 Thread Victor Vasiliev
On Fri, Dec 23, 2011 at 9:26 AM, Dmitriy Sintsov wrote: > Also it would be great if WikiScripts or Lua extension allowed to easily > bind functions / class wrappers for another MediaWiki extensions. The > extension I develop uses PHP eval for interpretation of the scripts, I > am looking for adapt

Re: [Wikitech-l] Making the Lua/Javascript decision (Re: Performance roadmap update)

2011-12-22 Thread Dmitriy Sintsov
* Owen Davis [Thu, 22 Dec 2011 11:50:48 -0800]: > I think that would be a nice feature to have. Amazingly enough, > WikiScripts is not of the extensions that we have in our codebase at > wikia (I think we're over 800+), but I will take a look at the > implementation. The parser hook allows for

[MediaWiki-CodeReview] [MediaWiki r107119]: New comment added

2011-12-22 Thread MediaWiki Mail
"^demon" posted a comment on MediaWiki.r107119. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107119#c28396 Commit summary for MediaWiki.r107119: rephrase r106992 release notes ^demon's comment: Removing 1.18wmf1 tag, release notes don't need merging. __

[MediaWiki-CodeReview] [Wikimedia r1019]: New comment added

2011-12-22 Thread MediaWiki Mail
"Kaldari" posted a comment on Wikimedia.r1019. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1019#c28395 Commit summary for Wikimedia.r1019: Added resetSettings(). Added $this->settings. Added ability to dequeue from pending: fetchFromPendingAndDequeue(). Fixed spelling mistakes. Ka

[MediaWiki-CodeReview] [Wikimedia r1019]: New comment added

2011-12-22 Thread MediaWiki Mail
"Kaldari" posted a comment on Wikimedia.r1019. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1019#c28394 Commit summary for Wikimedia.r1019: Added resetSettings(). Added $this->settings. Added ability to dequeue from pending: fetchFromPendingAndDequeue(). Fixed spelling mistakes. Ka

[MediaWiki-CodeReview] [Wikimedia r1022]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1022 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1022 Old status: new > New status: deferred Commit summary for Wikimedia.r1022: Added more unit testing for Listener and Db. ___ M

[MediaWiki-CodeReview] [Wikimedia r1021]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1021 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1021 Old status: new > New status: deferred Commit summary for Wikimedia.r1021: Hiding everything from checkout in this directory. ___

[MediaWiki-CodeReview] [Wikimedia r1020]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1020 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1020 Old status: new > New status: deferred Commit summary for Wikimedia.r1020: Added helper methods: getLimboDataForGlobalCollect(), getRowDataForGlobalCollect(), removeFrom

[MediaWiki-CodeReview] [MediaWiki r100933]: New comment added

2011-12-22 Thread MediaWiki Mail
"Aaron Schulz" posted a comment on MediaWiki.r100933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933#c28393 Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of tem

[MediaWiki-CodeReview] [Wikimedia r1017]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1017 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1017 Old status: new > New status: ok Commit summary for Wikimedia.r1017: Adding return affected rows for delete. ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [Wikimedia r1016]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1016 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1016 Old status: new > New status: ok Commit summary for Wikimedia.r1016: Removed pushToQueue() from code. ___ MediaWiki-CodeReview mail

[MediaWiki-CodeReview] [Wikimedia r1013]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1013 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1013 Old status: new > New status: deferred Commit summary for Wikimedia.r1013: Added test for selecting invalid tables. ___ Media

[MediaWiki-CodeReview] [Wikimedia r1012]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1012 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1012 Old status: new > New status: deferred Commit summary for Wikimedia.r1012: Adding tests for exceptions. ___ MediaWiki-CodeRev

[MediaWiki-CodeReview] [Wikimedia r1011]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1011 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1011 Old status: new > New status: ok Commit summary for Wikimedia.r1011: Completing test case. ___ MediaWiki-CodeReview mailing list me

[MediaWiki-CodeReview] [Wikimedia r1010]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1010 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1010 Old status: new > New status: ok Commit summary for Wikimedia.r1010: Cleaning up test code. ___ MediaWiki-CodeReview mailing list m

[MediaWiki-CodeReview] [Wikimedia r1009]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1009 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1009 Old status: new > New status: ok Commit summary for Wikimedia.r1009: Added test case for update() in database adapter. ___ MediaWik

[MediaWiki-CodeReview] [Wikimedia r1008]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1008 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1008 Old status: new > New status: ok Commit summary for Wikimedia.r1008: Added test for table on insert. ___ MediaWiki-CodeReview maili

[MediaWiki-CodeReview] [Wikimedia r1007]: New comment added, and revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1007 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1007#c28392 Old Status: new > New Status: fixme Commit summary for Wikimedia.r1007: Updated delete(), update() and insert() with debugging and documenation. Kal

[MediaWiki-CodeReview] [Wikimedia r1007]: New comment added

2011-12-22 Thread MediaWiki Mail
"Kaldari" posted a comment on Wikimedia.r1007. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1007#c28391 Commit summary for Wikimedia.r1007: Updated delete(), update() and insert() with debugging and documenation. Kaldari's comment: +* @param string$table

[MediaWiki-CodeReview] [Wikimedia r1006]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1006 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1006 Old status: new > New status: ok Commit summary for Wikimedia.r1006: Set $storeResult default to true. ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [Wikimedia r1004]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1004 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1004 Old status: new > New status: ok Commit summary for Wikimedia.r1004: Added delete test case for Mysqli adapter. ___ MediaWiki-CodeR

[MediaWiki-CodeReview] [Wikimedia r1003]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1003 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1003 Old status: new > New status: ok Commit summary for Wikimedia.r1003: Updating error handling for database queries. ___ MediaWiki-Co

[MediaWiki-CodeReview] [Wikimedia r1003]: New comment added

2011-12-22 Thread MediaWiki Mail
"Kaldari" posted a comment on Wikimedia.r1003. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1003#c28390 Commit summary for Wikimedia.r1003: Updating error handling for database queries. Kaldari's comment: + $message = '$table cannot be empty.'; +

[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added

2011-12-22 Thread MediaWiki Mail
"Hashar" posted a comment on MediaWiki.r94881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28389 Commit summary for MediaWiki.r94881: Relative values of the "Location" header are incorrect as stated in RFC, however they do happen and modern browsers support them. This functi

[MediaWiki-CodeReview] [MediaWiki r106752]: New comment added

2011-12-22 Thread MediaWiki Mail
"Aaron Schulz" posted a comment on MediaWiki.r106752. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752#c28388 Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the chan

[MediaWiki-CodeReview] [Wikimedia r1003]: New comment added

2011-12-22 Thread MediaWiki Mail
"Kaldari" posted a comment on Wikimedia.r1003. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1003#c28387 Commit summary for Wikimedia.r1003: Updating error handling for database queries. Kaldari's comment: Judging by the next rev, it looks like this is to allow you to test the error

[MediaWiki-CodeReview] [MediaWiki r107127]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r107127 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107127 Old status: new > New status: ok Commit summary for MediaWiki.r107127: Applying patch from bug 5 (from Erwin Dokter). Followup to r105280 and r106884. * td.diff-d

[MediaWiki-CodeReview] [Wikimedia r1003]: New comment added

2011-12-22 Thread MediaWiki Mail
"Kaldari" posted a comment on Wikimedia.r1003. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1003#c28386 Commit summary for Wikimedia.r1003: Updating error handling for database queries. Kaldari's comment: If the parameters are required, why not just let it fail with a normal error?

[MediaWiki-CodeReview] [MediaWiki r106752]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"OverlordQ" changed the status of MediaWiki.r106752 to "fixme" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752 Old status: new > New status: fixme Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to

[MediaWiki-CodeReview] [MediaWiki r106981]: New comment added

2011-12-22 Thread MediaWiki Mail
"OverlordQ" posted a comment on MediaWiki.r106981. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106981#c28385 Commit summary for MediaWiki.r106981: Rename original file to make room for a tcp-based version, in the remote^Cventuality mediawiki uses tcp transmission. OverlordQ's comm

[MediaWiki-CodeReview] [Wikimedia r1064]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1064 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1064 Old status: new > New status: ok Commit summary for Wikimedia.r1064: Removed a tab from the file. See r1036. ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [Wikimedia r891]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r891 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/891 Old status: new > New status: resolved Commit summary for Wikimedia.r891: Added pushToQueueWithJmsCorrelationId(), fetchFromLimbo(), fetchFromLimboAndDequeue(), getQueueLi

[MediaWiki-CodeReview] [Wikimedia r1002]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1002 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1002 Old status: new > New status: ok Commit summary for Wikimedia.r1002: Added ack header with a value of client to enable transactions for receiving messages. Fixes r891. __

[MediaWiki-CodeReview] [Wikimedia r516]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r516 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/516 Old status: new > New status: resolved Commit summary for Wikimedia.r516: Listener is ready for testing with GlobalCollect. ___

[MediaWiki-CodeReview] [Wikimedia r1000]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1000 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1000 Old status: new > New status: ok Commit summary for Wikimedia.r1000: Fixing documentation on public function stompDequeueMessage( $msg ). Fixes r516. _

[MediaWiki-CodeReview] [Wikimedia r999]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r999 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/999 Old status: new > New status: ok Commit summary for Wikimedia.r999: Removing references to unit testing. See r467. ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r107125]: New comment added

2011-12-22 Thread MediaWiki Mail
"Hashar" posted a comment on MediaWiki.r107125. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107125#c28384 Commit summary for MediaWiki.r107125: MFT to 1.18wmf1 r107120 Fix bug 33772 : MoodBar & WikiLove not working on incubator Hashar's comment: Deployed live, although mergeinfo

[MediaWiki-CodeReview] [Wikimedia r987]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r987 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/987 Old status: new > New status: ok Commit summary for Wikimedia.r987: Updating unit tests. Ignoring debugging code from unit testing. _

[MediaWiki-CodeReview] [MediaWiki r107125]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"SPQRobin" changed the status of MediaWiki.r107125 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107125 Old status: new > New status: ok Commit summary for MediaWiki.r107125: MFT to 1.18wmf1 r107120 Fix bug 33772 : MoodBar & WikiLove not working on incubator __

Re: [Wikitech-l] Tag extension detecting its tag name?

2011-12-22 Thread Platonides
On 21/12/11 17:47, Daniel Barrett wrote: > Happy Melon suggests: >> foreach( array( 'foo', 'bar', 'baz', quok' ) as $var ){ >> $parser->setHook( $var, "WrapperClass::myCallback_$var" ); >> } >> ... > > Thanks for the suggestion. I am already doing something similar (see my > original note about

[MediaWiki-CodeReview] [MediaWiki r107120]: New comment added

2011-12-22 Thread MediaWiki Mail
"Hashar" posted a comment on MediaWiki.r107120. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107120#c28383 Commit summary for MediaWiki.r107120: A hook function shouldn't return false. This was causing MoodBar & WikiLove to not work on Incubator because they are called after Wikimed

[MediaWiki-CodeReview] [Wikimedia r985]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r985 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/985 Old status: new > New status: ok Commit summary for Wikimedia.r985: Added unit tests for character encoding database connection. ___

[MediaWiki-CodeReview] [Wikimedia r986]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r986 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/986 Old status: new > New status: ok Commit summary for Wikimedia.r986: Updated code coverage for unit tests. See r985. ___ MediaWiki-Cod

[MediaWiki-CodeReview] [MediaWiki r107120]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Hashar" changed the status of MediaWiki.r107120 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107120 Old status: new > New status: ok Commit summary for MediaWiki.r107120: A hook function shouldn't return false. This was causing MoodBar & WikiLove to not work on Incubator

[MediaWiki-CodeReview] [MediaWiki r103817]: New comment added

2011-12-22 Thread MediaWiki Mail
"Platonides" posted a comment on MediaWiki.r103817. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103817#c28382 Commit summary for MediaWiki.r103817: Bug 29524 - Rename RequestContext::getLang to getLanguage I'll be amazed if this doens't break any tests. Platonides's comment: We f

Re: [Wikitech-l] New committer

2011-12-22 Thread Platonides
Welcome, Oren. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added

2011-12-22 Thread MediaWiki Mail
"Hashar" posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28381 Commit summary for MediaWiki.r107054: do not evaluate 'cat file | php eval.php Today, I have spend too much time figuring out an issue that would have made been obvious if I

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Jay Ashworth
- Original Message - > From: "Steven Walling" > On Thu, Dec 22, 2011 at 1:58 PM, Brion Vibber wrote: > > * the only important thing about the colors is that the text is > > legible > > We could save this debate by just making them the same color. ;-) > > Oh; we're inaugurating Whacky

[MediaWiki-CodeReview] [MediaWiki r107006]: New comment added, and revision status changed

2011-12-22 Thread MediaWiki Mail
"Platonides" changed the status of MediaWiki.r107006 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107006#c28380 Old Status: new > New Status: fixme Commit summary for MediaWiki.r107006: * (bug 23427) Introduced {{PAGEID}} variable to expose page.page_id

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Jay Ashworth
- Original Message - > From: "Ryan Lane" > Green has a meaning of "Go" or of "this is ok" in many cultures. > Making either side green gives a bias to the diff. Similarly with red. > Red means "Stop" or "this is not ok". Many people associate red with > blood, and green with nature. And

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Platonides
On 22/12/11 23:59, Erwin Dokter wrote: >> Note: revisions are not definitives. We can always amend them later on. > > Until 1.19 is suddenly branched off... game over. Is there an expected > timeframe or announcement for when this might happen? Even then it could be backported. That "revisions a

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Platonides
On 22/12/11 22:37, Ryan Lane wrote: > Green has a meaning of "Go" or of "this is ok" in many cultures. > Making either side green gives a bias to the diff. Similarly with red. > Red means "Stop" or "this is not ok". Many people associate red with > blood, and green with nature. > > - Ryan I don't

[Wikitech-l] The role of designers in MediaWiki (Re: Diff colors - a disaster waiting to happen)

2011-12-22 Thread Rob Lanphier
On Thu, Dec 22, 2011 at 11:04 AM, Chad wrote: > I highly doubt we'll get guaranteed backlash over > such a minor shift in diff colors. Hehha ha ha ha(*uncontrollable laughter*) Sorry, we will, but not because we should. Pretty much any design change anyone makes runs a substantial risk

[MediaWiki-CodeReview] [MediaWiki r106782]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r106782 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106782 Old status: fixme > New status: new Commit summary for MediaWiki.r106782: Resourceloader-ify CSS/JS from CentralAuth Kill $wgCentralAuthStyleVersion as now un-needed _

[MediaWiki-CodeReview] [MediaWiki r107102]: New comment added

2011-12-22 Thread MediaWiki Mail
"Robmoen" posted a comment on MediaWiki.r107102. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107102#c28379 Commit summary for MediaWiki.r107102: reworked last commit to filter prior to load method, fix ie7 cache problem with loadItem, follow up r107093 Robmoen's comment: Awesome,

[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added

2011-12-22 Thread MediaWiki Mail
"Marooned" posted a comment on MediaWiki.r94881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28378 Commit summary for MediaWiki.r94881: Relative values of the "Location" header are incorrect as stated in RFC, however they do happen and modern browsers support them. This func

[MediaWiki-CodeReview] [MediaWiki r107121]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Hashar" changed the status of MediaWiki.r107121 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107121 Old status: new > New status: ok Commit summary for MediaWiki.r107121: Add comments explaining that the funky multiple Location headers stuff is a CURL artifact, and that t

[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added

2011-12-22 Thread MediaWiki Mail
"Hashar" posted a comment on MediaWiki.r94881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28377 Commit summary for MediaWiki.r94881: Relative values of the "Location" header are incorrect as stated in RFC, however they do happen and modern browsers support them. This functi

[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added, and revision status changed

2011-12-22 Thread MediaWiki Mail
"Brion VIBBER" changed the status of MediaWiki.r94881 to "resolved" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28376 Old Status: fixme > New Status: resolved Commit summary for MediaWiki.r94881: Relative values of the "Location" header are incorrect as st

[MediaWiki-CodeReview] [MediaWiki r106948]: New comment added, and revision status changed

2011-12-22 Thread MediaWiki Mail
"Brion VIBBER" changed the status of MediaWiki.r106948 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106948#c28375 Old Status: fixme > New Status: ok Commit summary for MediaWiki.r106948: tests for r94881 which interprets relative Location: headers Brion VI

[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added

2011-12-22 Thread MediaWiki Mail
"Brion VIBBER" posted a comment on MediaWiki.r94881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28374 Commit summary for MediaWiki.r94881: Relative values of the "Location" header are incorrect as stated in RFC, however they do happen and modern browsers support them. This

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Erwin Dokter
Thanks for your reply, Antoine. Antoine Musso wrote: > > I have looked at your patch this afternoon. Your colors are not that > much different from Brandon one. It is clearly not worth it to spend > hours and hours in discussion just to add 1% of red in a yellow color > or 0.5% of green in the blu

[MediaWiki-CodeReview] [Wikimedia r981]: New comment added

2011-12-22 Thread MediaWiki Mail
"Kaldari" posted a comment on Wikimedia.r981. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/981#c28373 Commit summary for Wikimedia.r981: Removing ablility to set log file as a parameter in Listener_Adapter_Abstract::openOutputHandle(). See r492. Kaldari's comment: +

[MediaWiki-CodeReview] [Wikimedia r978]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r978 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/978 Old status: new > New status: ok Commit summary for Wikimedia.r978: Removed queueMessageToPending() from test case. Using Listener_Adapter_Abstract::pushToQueueWithJmsCorrelatio

[MediaWiki-CodeReview] [Wikimedia r977]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r977 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/977 Old status: new > New status: ok Commit summary for Wikimedia.r977: Added two test cases: CheckRequiredFieldsTestCase and lobalCollectPaymentMethodsTestCase. __

[MediaWiki-CodeReview] [MediaWiki r100729]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r100729 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100729 Old status: new > New status: resolved Commit summary for MediaWiki.r100729: step 2 of i18n message migration, this will break lots of forms, which I need to fix

[MediaWiki-CodeReview] [MediaWiki r106706]: New comment added

2011-12-22 Thread MediaWiki Mail
"Krinkle" posted a comment on MediaWiki.r106706. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106706#c28372 Commit summary for MediaWiki.r106706: [WebFonts] Code quality & clean up * Various good practices, white space conventions (Thanks JSLint) * Such as: -- JavaScript does not hav

[MediaWiki-CodeReview] [MediaWiki r106954]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r106954 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106954 Old status: new > New status: ok Commit summary for MediaWiki.r106954: Remove "de-formal" translations. "de" translations are in formal language for adequately address

[MediaWiki-CodeReview] [MediaWiki r106836]: New comment added

2011-12-22 Thread MediaWiki Mail
"Awjrichards" posted a comment on MediaWiki.r106836. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106836#c28371 Commit summary for MediaWiki.r106836: More work on moving the input validation functions from GatewayForm to DonationData. Note: None of the new stuff is being invoked by

[MediaWiki-CodeReview] [MediaWiki r106495]: New comment added

2011-12-22 Thread MediaWiki Mail
"Awjrichards" posted a comment on MediaWiki.r106495. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106495#c28370 Commit summary for MediaWiki.r106495: The beginnings of input validation in DonationData. Stuff left to do: *) Move all the other input validation to DonationData (

[MediaWiki-CodeReview] [Wikimedia r1036]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Kaldari" changed the status of Wikimedia.r1036 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1036 Old status: new > New status: ok Commit summary for Wikimedia.r1036: Indented code. No actual changes were made. ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r107043]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Krinkle" changed the status of MediaWiki.r107043 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107043 Old status: new > New status: ok Commit summary for MediaWiki.r107043: Use mw.util.addCSS for adding css. Based on bug 33305, and fixed in r106992. __

[MediaWiki-CodeReview] [Wikimedia r1036]: Revision status changed

2011-12-22 Thread MediaWiki Mail
"Jpostlethwaite" changed the status of Wikimedia.r1036 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1036 Old status: fixme > New status: new Commit summary for Wikimedia.r1036: Indented code. No actual changes were made. ___ Med

[MediaWiki-CodeReview] [MediaWiki r106992]: New comment added

2011-12-22 Thread MediaWiki Mail
"Krinkle" posted a comment on MediaWiki.r106992. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106992#c28369 Commit summary for MediaWiki.r106992: [Core JS] mw.util.addCSS: Insert style tag into dom before setting cssText * Fixes bug 33305 Krinkle's comment: It's not as much wrong a

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Roan Kattouw
On Thu, Dec 22, 2011 at 10:56 PM, Russell Nelson wrote: > Speaking of usability, why is this mailing list called Wiki Tech List Lists > Wiki Media org? Surely there's some extra duplicate redundancy there there? > Do you mean the -l suffix is redundant with the list. prefix? Yes, that's known, but

[MediaWiki-CodeReview] [Wikimedia r1036]: New comment added

2011-12-22 Thread MediaWiki Mail
"Jpostlethwaite" posted a comment on Wikimedia.r1036. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1036#c28368 Commit summary for Wikimedia.r1036: Indented code. No actual changes were made. Jpostlethwaite's comment: Maybe I am mistaken, but I thought it was wrong before I fixed it

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Antoine Musso
Steven Walling wrote: > We could save this debate by just making them the same color. I purpose white for both sides since it hits all eye cone cells :-D -- Antoine "hashar" Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://l

[MediaWiki-CodeReview] [Wikimedia r1036]: New comment added

2011-12-22 Thread MediaWiki Mail
"Jpostlethwaite" posted a comment on Wikimedia.r1036. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1036#c28367 Commit summary for Wikimedia.r1036: Indented code. No actual changes were made. Jpostlethwaite's comment: That is odd. There was only one tab in my file. I fixed that in r

Re: [Wikitech-l] LiquidThreads status

2011-12-22 Thread Brion Vibber
On Thu, Dec 22, 2011 at 12:40 PM, MZMcBride wrote: > Someone asked me about LiquidThreads and I pointed them to > https://www.mediawiki.org/wiki/LiquidThreads_3.0 only to realize that the > current timeline on that page reads "August 2011". > > Is there an updated status for LiquidThreads? I vagu

[MediaWiki-CodeReview] [MediaWiki r103260]: New comment added

2011-12-22 Thread MediaWiki Mail
"Bawolff" posted a comment on MediaWiki.r103260. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103260#c28366 Commit summary for MediaWiki.r103260: (follow-up r100023; bug 32438) $pagesCount is total number of members a category has, not the number that are "normal" pages. Bawolff's

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Antoine Musso
Hello Erwin, Thanks for bringing this on the wikitech-l list! Erwin Dokter wrote: > It all started with revision 105280 > (https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280), where > Hashdar commited a new color scheme for diffs based on the French scheme. > When this generated some fl

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread OQ
On Thu, Dec 22, 2011 at 3:56 PM, Russell Nelson wrote: > Speaking of usability, why is this mailing list called Wiki Tech List Lists > Wiki Media org? Surely there's some extra duplicate redundancy there there? It isn't, that's just what your $mail_client decided to call it, for me it's listed as

[MediaWiki-CodeReview] [MediaWiki r106782]: New comment added

2011-12-22 Thread MediaWiki Mail
"Catrope" posted a comment on MediaWiki.r106782. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106782#c28365 Commit summary for MediaWiki.r106782: Resourceloader-ify CSS/JS from CentralAuth Kill $wgCentralAuthStyleVersion as now un-needed Catrope's comment: Yeah, I guess CR is prob

[MediaWiki-CodeReview] [MediaWiki r106782]: New comment added

2011-12-22 Thread MediaWiki Mail
"Reedy" posted a comment on MediaWiki.r106782. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106782#c28364 Commit summary for MediaWiki.r106782: Resourceloader-ify CSS/JS from CentralAuth Kill $wgCentralAuthStyleVersion as now un-needed Reedy's comment: "Catrope" posted a comment

[MediaWiki-CodeReview] [MediaWiki r106782]: New comment added

2011-12-22 Thread MediaWiki Mail
"Catrope" posted a comment on MediaWiki.r106782. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106782#c28363 Commit summary for MediaWiki.r106782: Resourceloader-ify CSS/JS from CentralAuth Kill $wgCentralAuthStyleVersion as now un-needed Catrope's comment: Huh? What do you mean? P

[MediaWiki-CodeReview] [MediaWiki r106782]: New comment added

2011-12-22 Thread MediaWiki Mail
"Reedy" posted a comment on MediaWiki.r106782. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106782#c28362 Commit summary for MediaWiki.r106782: Resourceloader-ify CSS/JS from CentralAuth Kill $wgCentralAuthStyleVersion as now un-needed Reedy's comment: Cheers! Roan, do you realis

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Steven Walling
On Thu, Dec 22, 2011 at 1:58 PM, Brion Vibber wrote: > * the only important thing about the colors is that the text is legible We could save this debate by just making them the same color. ;-) Steven ___ Wikitech-l mailing list Wikitech-l@lists.wik

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Brion Vibber
So just a reminder to y'all: * the primary indicator is physical ordering (left = before; right = after) * the secondary indicator is "+" and "-" symbols indicating additional and removal * the colors are totally arbitrary to help set sections apart from each other visibly * the only important thi

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Aaron Schulz
I've stated in CR that I don't think light light green has any real cultural issue. It shouldn't be ruled out on those grounds. Red, on the other hand, has stronger connotations. Part of it comes from the fact that GUIs vry often have certain color standards, e.g.: Blue: "notice", "fyi", "pleas

  1   2   3   >