Re: [Wikitech-l] Git + Gerrit is a toughy

2012-02-25 Thread Roan Kattouw
On Sat, Feb 25, 2012 at 1:20 AM, Antoine Musso wrote: > Le 25/02/12 00:48, Platonides a écrit : > >> There's no way to treat a set of commits as a bundle? > > > Not really. Each commit is considered by Gerrit as a new change. If you have > a bundle of commits, you either: > >  1) squash them in a

[MediaWiki-CodeReview] [MediaWiki r111335]: New comment added

2012-02-25 Thread MediaWiki Mail
"^demon" posted a comment on MediaWiki.r111335. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111335#c31468 Commit summary for MediaWiki.r111335: follow up to r111017, move hook to isAlwatsKnown as per discussion on CR ^demon's comment: I might've gotten it mixed with the version in

[MediaWiki-CodeReview] [MediaWiki r111335]: New comment added, and revision status changed

2012-02-25 Thread MediaWiki Mail
"Platonides" changed the status of MediaWiki.r111335 to "new" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111335#c31467 Old Status: reverted New Status: new Commit summary for MediaWiki.r111335: follow up to r111017, move hook to isAlwatsKnown as per discussion on

[MediaWiki-CodeReview] [MediaWiki r111918]: New comment added

2012-02-25 Thread MediaWiki Mail
"Siebrand" posted a comment on MediaWiki.r111918. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111918#c31466 Commit summary for MediaWiki.r111918: Remove obsolete and broken lang2po.php. Siebrand's comment: If you insist, but I think this has been broken for years already, so I dou

[MediaWiki-CodeReview] [MediaWiki r112410]: New comment added

2012-02-25 Thread MediaWiki Mail
"Siebrand" posted a comment on MediaWiki.r112410. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112410#c31465 Commit summary for MediaWiki.r112410: (bug 34702) Use localised parentheses in Special:Contributions. Siebrand's comment: Argh. I made that mistake before, indeed. So instea

[MediaWiki-CodeReview] [MediaWiki r112387]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r112387 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112387 Old status: new New status: ok Commit summary for MediaWiki.r112387: Use local context to get messages ___ MediaWiki-CodeR

[MediaWiki-CodeReview] [MediaWiki r112388]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r112388 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112388 Old status: new New status: ok Commit summary for MediaWiki.r112388: Pass __METHOD__ to DatabaseBase::begin(), DatabaseBase::commit() and DatabaseBase::rollback() __

[MediaWiki-CodeReview] [MediaWiki r112408]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r112408 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112408 Old status: new New status: ok Commit summary for MediaWiki.r112408: Fixes bug 34715 Image redirects show the "redirected from" subtitle twice. ImagePage no longer ne

Re: [Wikitech-l] [ANN] MediaWiki Short URL Builder configuration tool

2012-02-25 Thread Chad
On Sat, Feb 25, 2012 at 4:16 PM, Daniel Friesen wrote: > So it will probably have to be some distance in the future before it's > robust enough for us to include into the installer. > That is probably natural anyways. Since when you think about it, at this > point we don't even have good manual pa

Re: [Wikitech-l] [ANN] MediaWiki Short URL Builder configuration tool

2012-02-25 Thread Daniel Friesen
You might be able to adapt the tests I use in the tool and the rules for generating the config later on. Though as-is the actual code won't be as much help. It's in Ruby rather than PHP. And the code has to be intermixed with the config output because of how variable short url config can be.

Re: [Wikitech-l] [ANN] MediaWiki Short URL Builder configuration tool

2012-02-25 Thread Gregory Varnum
I'm actually glad you brought that up - it's a general topic that's been bouncing around in my mind lately. I can appreciate the marketing concern. :) I think we'll need to be flexible in allowing the look and logo to remain intact. As I've been reviewing extension pages, I've noticed a heal

[MediaWiki-CodeReview] [MediaWiki r112410]: New comment added

2012-02-25 Thread MediaWiki Mail
"Nikerabbit" posted a comment on MediaWiki.r112410. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112410#c31464 Commit summary for MediaWiki.r112410: (bug 34702) Use localised parentheses in Special:Contributions. Nikerabbit's comment: If you are not calling ->escaped() or similar,

[Wikitech-l] Status of 1.19 bugs

2012-02-25 Thread Mark A. Hershberger
During the triage yesterday, we sorted out the bugs marked as 1.19 regressions and scheduled them to be fixed before the roll outs on Monday or Wednesday. Anyone who is interested in the results of the triage should check the etherpad: http://etherpad.wikimedia.org/119triage Today, a 1.19 regres

Re: [Wikitech-l] [ANN] MediaWiki Short URL Builder configuration tool

2012-02-25 Thread Daniel Friesen
I can forward that. Technically since I logged work hours to write that and the MW Skinning tutorial I don't own the copyright for them, so I have to get an ok for anything like that. Keep in mind that the premise under which I was allowed to write them under work hours was that putting thing

Re: [Wikitech-l] [ANN] MediaWiki Short URL Builder configuration tool

2012-02-25 Thread Chad
Integrating short url config to the installer has been on my todo list for a long time. Dan: would you be interested in putting this into the installer sometime in the future? -Chad On Feb 25, 2012 3:06 PM, "Mr. Gregory Varnum" wrote: > I think the tool is great! > > Would it be possible to hou

Re: [Wikitech-l] [ANN] MediaWiki Short URL Builder configuration tool

2012-02-25 Thread Mr. Gregory Varnum
I think the tool is great! Would it be possible to house on labs or toolserver? My only hesitation in linking to it is then we're dependent on Redwerks generosity in hosting. I think we should leave due credit to them and such in place. -Greg aka varnent Sent from my iPhone. Apo

Re: [Wikitech-l] [ANN] MediaWiki Short URL Builder configuration tool

2012-02-25 Thread Daniel Friesen
On Sat, 25 Feb 2012 01:25:32 -0800, Antoine Musso wrote: Daniel Friesen wrote: Balanced? That section lists a single bad example of an /advantage/ for long urls. Another advantage of long URLs, is for such corner case when the sysop team does not know about URL rewriting and has more imp

[MediaWiki-CodeReview] [MediaWiki r112403]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r112403 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112403 Old status: new New status: ok Commit summary for MediaWiki.r112403: Write some output to error log in case a message group has 0 messages. Makes mistakes like that fro

[MediaWiki-CodeReview] [MediaWiki r110711]: New comment added

2012-02-25 Thread MediaWiki Mail
"Siebrand" posted a comment on MediaWiki.r110711. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110711#c31463 Commit summary for MediaWiki.r110711: Localisation updates for ToolserverI18N from translatewiki.net Siebrand's comment: No, not if it's not exactly !!FUZZY!!. Yes. ___

[MediaWiki-CodeReview] [MediaWiki r112405]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Platonides" changed the status of MediaWiki.r112405 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112405 Old status: deferred New status: ok Commit summary for MediaWiki.r112405: [TsIntuition] Commit tsIntUpdate bash script - Not very pretty right now, but we've been using

[MediaWiki-CodeReview] [MediaWiki r112405]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Krinkle" changed the status of MediaWiki.r112405 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112405 Old status: new New status: deferred Commit summary for MediaWiki.r112405: [TsIntuition] Commit tsIntUpdate bash script - Not very pretty right now, but we've been us

[MediaWiki-CodeReview] [MediaWiki r112320]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r112320 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112320 Old status: new New status: ok Commit summary for MediaWiki.r112320: Fix help link html getting added twice (was not visible in the page)

[MediaWiki-CodeReview] [MediaWiki r110711]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Krinkle" changed the status of MediaWiki.r110711 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110711 Old status: fixme New status: resolved Commit summary for MediaWiki.r110711: Localisation updates for ToolserverI18N from translatewiki.net _

[MediaWiki-CodeReview] [MediaWiki r112404]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Krinkle" changed the status of MediaWiki.r112404 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112404 Old status: new New status: ok Commit summary for MediaWiki.r112404: Fix issue in r110711 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r110711]: New comment added, and revision status changed

2012-02-25 Thread MediaWiki Mail
"Krinkle" changed the status of MediaWiki.r110711 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110711#c31462 Old Status: resolved New Status: fixme Commit summary for MediaWiki.r110711: Localisation updates for ToolserverI18N from translatewiki.net Krin

[MediaWiki-CodeReview] [MediaWiki r111854]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r111854 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111854 Old status: new New status: ok Commit summary for MediaWiki.r111854: r111831: Register extension for translatewiki.net. ___ Me

[MediaWiki-CodeReview] [MediaWiki r110711]: New comment added

2012-02-25 Thread MediaWiki Mail
"Krinkle" posted a comment on MediaWiki.r110711. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110711#c31461 Commit summary for MediaWiki.r110711: Localisation updates for ToolserverI18N from translatewiki.net Krinkle's comment: Aren't these normally prevented to be exported though?

[MediaWiki-CodeReview] [MediaWiki r111495]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r111495 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111495 Old status: new New status: ok Commit summary for MediaWiki.r111495: r111471: Remove fake message documentation. Confuses our translators. ___

[MediaWiki-CodeReview] [MediaWiki r111749]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r111749 to "fixme" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111749 Old status: new New status: fixme Commit summary for MediaWiki.r111749: r110692: Register extension for translatewiki.net.

[MediaWiki-CodeReview] [MediaWiki r112040]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r112040 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112040 Old status: new New status: ok Commit summary for MediaWiki.r112040: r112038: Update ignore messages ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r110711]: New comment added, and revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r110711 to "resolved" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110711#c31460 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r110711: Localisation updates for ToolserverI18N from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r112401]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Raymond" changed the status of MediaWiki.r112401 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112401 Old status: new New status: ok Commit summary for MediaWiki.r112401: Follow-up r111791: Fix file name for messages. ___ MediaWi

[MediaWiki-CodeReview] [MediaWiki r111791]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r111791 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111791 Old status: fixme New status: resolved Commit summary for MediaWiki.r111791: r111786: extension moved ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r112231]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r112231 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112231 Old status: new New status: ok Commit summary for MediaWiki.r112231: Localisation updates for extension messages from translatewiki.net Core skipped today, conflicts with

[MediaWiki-CodeReview] [MediaWiki r112128]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r112128 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112128 Old status: fixme New status: resolved Commit summary for MediaWiki.r112128: r112045/bug 34508: Make upload/upload and overwrite match old IRC format __

[MediaWiki-CodeReview] [MediaWiki r112353]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r112353 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112353 Old status: new New status: ok Commit summary for MediaWiki.r112353: r112128: Comment out dupe message keys ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r112385]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Siebrand" changed the status of MediaWiki.r112385 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112385 Old status: new New status: ok Commit summary for MediaWiki.r112385: r112358: Message key to be ignored now for translatewiki.net because the message has no translatable

[MediaWiki-CodeReview] [MediaWiki r112357]: New comment added, and revision status changed

2012-02-25 Thread MediaWiki Mail
"Jeroen De Dauw" changed the status of MediaWiki.r112357 to "new" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112357#c31459 Old Status: fixme New Status: new Commit summary for MediaWiki.r112357: added parameters param to smwdoc Jeroen De Dauw's comment: > Plea

[MediaWiki-CodeReview] [MediaWiki r112395]: New comment added

2012-02-25 Thread MediaWiki Mail
"Platonides" posted a comment on MediaWiki.r112395. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112395#c31458 Commit summary for MediaWiki.r112395: * (bug 34528) Don't parse section name in edit section tooltips Platonides's comment: Apparently good, but needs parser tests. _

[MediaWiki-CodeReview] [MediaWiki r112344]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r112344 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112344 Old status: deferred New status: ok Commit summary for MediaWiki.r112344: Follow-up to r112224 - removed now-unnecessary helper function SFUtils::getSpecialPage(), repl

[MediaWiki-CodeReview] [MediaWiki r112333]: Revision status changed

2012-02-25 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r112333 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112333 Old status: new New status: ok Commit summary for MediaWiki.r112333: Made browser checking actually work. ___ MediaWiki-Code

Re: [Wikitech-l] [ANN] MediaWiki Short URL Builder configuration tool

2012-02-25 Thread Antoine Musso
Daniel Friesen wrote: Balanced? That section lists a single bad example of an /advantage/ for long urls. Another advantage of long URLs, is for such corner case when the sysop team does not know about URL rewriting and has more important things to do than figuring it out. I have seen such ca

Re: [Wikitech-l] Git + Gerrit is a toughy

2012-02-25 Thread Antoine Musso
Le 25/02/12 00:48, Platonides a écrit : There's no way to treat a set of commits as a bundle? Not really. Each commit is considered by Gerrit as a new change. If you have a bundle of commits, you either: 1) squash them in a single commit, losing all history but generating only one change.

[MediaWiki-CodeReview] [MediaWiki r112357]: New comment added, and revision status changed

2012-02-25 Thread MediaWiki Mail
"Raymond" changed the status of MediaWiki.r112357 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112357#c31457 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r112357: added parameters param to smwdoc Raymond's comment: {{messagedocum