Re: [Wikitech-l] diff colors

2012-03-02 Thread John Erling Blad
You can not design for one size fits all when it comes to accessibility, its simply not possible. John On Fri, Mar 2, 2012 at 4:03 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: Accessibility should not be a user preference. I also do not like the idea of site specific text size change

Re: [Wikitech-l] Who can make Gerrit/Labsconsole accounts?

2012-03-02 Thread Petr Bena
That policy doesn't make sense, especially given to number of services outages when it's not possible to op yourself, also it's quite annoying when you have to op / mode / deop yourself instead of just doing op work. However I don't see a reason to make people with root look different than others

[MediaWiki-CodeReview] [MediaWiki r112872]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112872 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112872 Old status: new New status: ok Commit summary for MediaWiki.r112872: Fix for r86304: if MessageCache::parse() is called twice, once with $interface=true and then with

[MediaWiki-CodeReview] [MediaWiki r112873]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112873 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112873 Old status: new New status: ok Commit summary for MediaWiki.r112873: (bug 34832) Parse recentchangestext with the interface option off, since it comes from

[MediaWiki-CodeReview] [MediaWiki r112836]: New comment added

2012-03-02 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r112836. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112836#c31731 Commit summary for MediaWiki.r112836: Resolves bug #11374 and improves on r94429, r94461, r101147, r105280, r106884, r107127, r108975 and r109932 which were reverted by

[MediaWiki-CodeReview] [MediaWiki r112836]: New comment added

2012-03-02 Thread MediaWiki Mail
MaxSem posted a comment on MediaWiki.r112836. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112836#c31732 Commit summary for MediaWiki.r112836: Resolves bug #11374 and improves on r94429, r94461, r101147, r105280, r106884, r107127, r108975 and r109932 which were reverted by r112750.

[MediaWiki-CodeReview] [pywikipedia r9839]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r9839 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9839 Old status: new New status: ok Commit summary for pywikipedia.r9839: Partial revert of r7043: remove incorrect ksh century categories

[MediaWiki-CodeReview] [MediaWiki r112439]: New comment added

2012-03-02 Thread MediaWiki Mail
Xqt posted a comment on MediaWiki.r112439. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112439#c31733 Commit summary for MediaWiki.r112439: Update codeMap. Xqt's comment: Shouldn't gsw map to als ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r112876]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r112876 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112876#c31734 Old Status: new New Status: fixme Commit summary for MediaWiki.r112876: Clear cache on writes Siebrand's comment: Throws bunches of the

[MediaWiki-CodeReview] [MediaWiki r111743]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r111743 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111743 Old status: new New status: ok Commit summary for MediaWiki.r111743: Made the new changes not break in older browser like Firefox 3.5.3 ;)

[MediaWiki-CodeReview] [MediaWiki r112848]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r112848 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112848 Old status: new New status: ok Commit summary for MediaWiki.r112848: MFT r112770, r112771, r112772, r112775 ___

Re: [Wikitech-l] Who can make Gerrit/Labsconsole accounts?

2012-03-02 Thread Jack Phoenix
On Thu, Mar 1, 2012 at 5:06 PM, Chad innocentkil...@gmail.com wrote: +v is fine. At the risk of sounding pedantic, I'll point out the freenode policy frowns on leaving people +o when it's not needed (although I find the policy kind of silly). Guideline, _not_ policy. See

[MediaWiki-CodeReview] [MediaWiki r112882]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r112882 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112882 Old status: new New status: resolved Commit summary for MediaWiki.r112882: * Follow-up r112878: Fix bad copy-paste. * Add todos for preventing duplicate log

[MediaWiki-CodeReview] [MediaWiki r112878]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r112878 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112878 Old status: new New status: ok Commit summary for MediaWiki.r112878: Logging for encouraged/discouraged marking to Special:Log/pagetranslation on

[MediaWiki-CodeReview] [MediaWiki r112886]: New comment added

2012-03-02 Thread MediaWiki Mail
Jdlrobson posted a comment on MediaWiki.r112886. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112886#c31735 Commit summary for MediaWiki.r112886: make sure toggling is enabled some older browsers e.g. nokia e63 do not support various operations for getting elements see

[MediaWiki-CodeReview] [MediaWiki r112887]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r112887 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112887 Old status: new New status: ok Commit summary for MediaWiki.r112887: Fix a copy-paste mistake in r112882 Remove a duplicate addModules call. It is already called in showPage

[MediaWiki-CodeReview] [MediaWiki r112893]: Revision status changed

2012-03-02 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r112893 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112893 Old status: new New status: ok Commit summary for MediaWiki.r112893: Typofix ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r112874]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r112874 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112874#c31736 Old Status: new New Status: ok Commit summary for MediaWiki.r112874: Adding my USERINFO file. MaxSem's comment: Welcome aboard!

[Wikitech-l] Minor git update

2012-03-02 Thread Chad
Hi folks, Just a quick update on git. All WMF-deployed extensions are currently mirroring SVN and are available for read-only operations (clone, pull, fetch). We won't be enabling pushing until the changeover date, but if you're interested in going ahead and cloning a particular extension (full

Re: [Wikitech-l] Minor git update

2012-03-02 Thread Chad
On Fri, Mar 2, 2012 at 9:07 AM, Chad innocentkil...@gmail.com wrote: Just a quick update on git. All WMF-deployed extensions are currently mirroring SVN and are available for read-only operations (clone, pull, fetch). We won't be enabling pushing until the changeover date, but if you're

Re: [Wikitech-l] Documentation for $wgExternalServers outdated?

2012-03-02 Thread Christian Aistleitner
Hi Tim, after figuring out how to set up simple clusters, I have been pointed to your email from January, where you asked for updates on $wgExternalServers documentation. On Thu, Jan 05, 2012 at 03:33:05AM +, Tim Landscheidt wrote: [ Documentation of $wgExternalServers ] Could someone

[MediaWiki-CodeReview] [MediaWiki r112876]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r112876 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112876#c31737 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r112876: Clear cache on writes Santhosh.thottingal's comment:

[MediaWiki-CodeReview] [MediaWiki r112815]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r112815 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112815 Old status: new New status: resolved Commit summary for MediaWiki.r112815: Cache metadata to avoid query flood

[Wikitech-l] install php-fss on php 5.3

2012-03-02 Thread Yury Katkov
Hi everyone! I want to install php module php-fss on php5.3 since I heard that it boosts MediaWiki performance a lot. Is it possible to do that? Is it installed on wikipedias? - Yury Katkov ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[Wikitech-l] Participating in medaiwiki gsoc 2012

2012-03-02 Thread Eranga Mapa
I'm interested in participating in MedaWiki gsoc 2012. Is this the correct thread to post regarding MedaiWiki gsoc 2012. Undergraduate Computer Science and Engineering University of Moratuwa Student Member IEEE ___ Wikitech-l mailing list

Re: [Wikitech-l] Participating in medaiwiki gsoc 2012

2012-03-02 Thread Sumana Harihareswara
On 03/02/2012 07:23 AM, Eranga Mapa wrote: I'm interested in participating in MedaWiki gsoc 2012. Is this the correct thread to post regarding MedaiWiki gsoc 2012. Undergraduate Computer Science and Engineering University of Moratuwa Student Member IEEE Hi, Eranga Mapa. This is the right

[MediaWiki-CodeReview] [MediaWiki r103941]: New comment added

2012-03-02 Thread MediaWiki Mail
Umherirrender posted a comment on MediaWiki.r103941. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103941#c31738 Commit summary for MediaWiki.r103941: (bug 32586) Allow styling of message 'revreview-hist-pending-difflink' Umherirrender's comment: This removed the small also from

[MediaWiki-CodeReview] [MediaWiki r107653]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
Happy-melon changed the status of MediaWiki.r107653 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107653#c31739 Old Status: resolved New Status: fixme Commit summary for MediaWiki.r107653: * Inverted the precedence between section edition and revision

[MediaWiki-CodeReview] [MediaWiki r112877]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r112877 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112877 Old status: new New status: ok Commit summary for MediaWiki.r112877: Add a few newlines. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r112878]: New comment added

2012-03-02 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r112878. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112878#c31740 Commit summary for MediaWiki.r112878: Logging for encouraged/discouraged marking to Special:Log/pagetranslation on Special:PageTranslation. Card i18n/#382 Nikerabbit's

[MediaWiki-CodeReview] [MediaWiki r112879]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r112879 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112879 Old status: new New status: ok Commit summary for MediaWiki.r112879: Remove trailing whitespace in translate-fs-userpage-help.

[MediaWiki-CodeReview] [MediaWiki r112887]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r112887 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112887#c31741 Old Status: ok New Status: new Commit summary for MediaWiki.r112887: Fix a copy-paste mistake in r112882 Remove a duplicate addModules call. It is

[MediaWiki-CodeReview] [MediaWiki r112892]: New comment added

2012-03-02 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r112892. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112892#c31742 Commit summary for MediaWiki.r112892: empty palm_pre stylesheet definitions are now redundant with recent styling changes Reedy's comment: Is there a reason not to svn delete

Re: [Wikitech-l] Minor git update

2012-03-02 Thread OQ
On Fri, Mar 2, 2012 at 8:07 AM, Chad innocentkil...@gmail.com wrote: Hi folks, Or over SSH if you've got a gerrit account via: `git clone ssh://user@gerrit.wikimedia.org:29418/example/repo/path.git` Since the other thread has been hijacked, how do we get a gerrit account? I thought I got one

[MediaWiki-CodeReview] [MediaWiki r112892]: New comment added

2012-03-02 Thread MediaWiki Mail
Jdlrobson posted a comment on MediaWiki.r112892. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112892#c31743 Commit summary for MediaWiki.r112892: empty palm_pre stylesheet definitions are now redundant with recent styling changes Jdlrobson's comment: Exactly. DeviceDetection.php

[Wikitech-l] Post-deploy Bug triage for 1.19

2012-03-02 Thread Mark A. Hershberger
What: 1.19 bug triage When: Friday, February, 21:00UTC Time zone conversion: http://hexm.de/g5 Where: #wikimedia-dev on freenode Use http://webchat.freenode.net/?channels=wikimedia-dev if you don't have an IRC client Etherpad:

Re: [Wikitech-l] Minor git update

2012-03-02 Thread Jeremy Postlethwaite
Thanks for getting this up! There is an extension missing: UnitTest https://www.mediawiki.org/wiki/Extension:UnitTest What do I need to do to get this mirrored as well? On Fri, Mar 2, 2012 at 8:20 AM, OQ overlo...@gmail.com wrote: On Fri, Mar 2, 2012 at 8:07 AM, Chad innocentkil...@gmail.com

[MediaWiki-CodeReview] [MediaWiki r112878]: New comment added

2012-03-02 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r112878. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112878#c31744 Commit summary for MediaWiki.r112878: Logging for encouraged/discouraged marking to Special:Log/pagetranslation on Special:PageTranslation. Card i18n/#382 Siebrand's

[MediaWiki-CodeReview] [MediaWiki r112887]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r112887 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112887 Old status: new New status: resolved Commit summary for MediaWiki.r112887: Fix a copy-paste mistake in r112882 Remove a duplicate addModules call. It is already called

[MediaWiki-CodeReview] [MediaWiki r112902]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Amire80 changed the status of MediaWiki.r112902 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112902 Old status: new New status: ok Commit summary for MediaWiki.r112902: Fix typo in comment updated in r112887. ___

Re: [Wikitech-l] Minor git update

2012-03-02 Thread Chad
On Fri, Mar 2, 2012 at 11:30 AM, Jeremy Postlethwaite jpostlethwa...@wikimedia.org wrote: Thanks for getting this up! There is an extension missing: UnitTest https://www.mediawiki.org/wiki/Extension:UnitTest What do I need to do to get this mirrored as well? The plan right now is to only

Re: [Wikitech-l] Minor git update

2012-03-02 Thread Chad
On Fri, Mar 2, 2012 at 11:20 AM, OQ overlo...@gmail.com wrote: On Fri, Mar 2, 2012 at 8:07 AM, Chad innocentkil...@gmail.com wrote: Hi folks, Or over SSH if you've got a gerrit account via: `git clone ssh://user@gerrit.wikimedia.org:29418/example/repo/path.git` Since the other thread has

Re: [Wikitech-l] Minor git update

2012-03-02 Thread Jeremy Postlethwaite
It is not fully deployed, but I did instruct OmniTI how to use it for the Article Feedback Tool. I do not see any reason why UnitTest needs to be put into Git this instant. I am pretty sure it can wait until a another batch of extensions is deployed. Thanks! On Fri, Mar 2, 2012 at 9:54 AM,

Re: [Wikitech-l] Post-deploy Bug triage for 1.19 *TODAY*

2012-03-02 Thread Mark A. Hershberger
What: 1.19 bug triage When: Friday, February, 21:00UTC Time zone conversion: http://hexm.de/g5 If you click on the timezone conversion link you wouls see that this is today, but since I didn't specify, let me be clear here: this is in about 3 hours. -- Mark A.

[MediaWiki-CodeReview] [MediaWiki r112906]: Revision status changed

2012-03-02 Thread MediaWiki Mail
F.trott changed the status of MediaWiki.r112906 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112906 Old status: deferred New status: ok Commit summary for MediaWiki.r112906: Fix for r112829 - re-added getDefaultPropTypes() declaration, so that 'textarea with autocomplete'

[MediaWiki-CodeReview] [MediaWiki r112439]: New comment added

2012-03-02 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r112439. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112439#c31745 Commit summary for MediaWiki.r112439: Update codeMap. Siebrand's comment: Yep. I may not have done all of them... Feel free to make additions.

Re: [Wikitech-l] install php-fss on php 5.3

2012-03-02 Thread John Du Hart
I've never heard of it and do not believe it's in use in production. On Mar 2, 2012 10:01 AM, Yury Katkov katkov.ju...@gmail.com wrote: Hi everyone! I want to install php module php-fss on php5.3 since I heard that it boosts MediaWiki performance a lot. Is it possible to do that? Is it

Re: [Wikitech-l] install php-fss on php 5.3

2012-03-02 Thread Yury Katkov
Which is strange since it semms that this is wikipedia product http://apt.wikimedia.org/wikimedia-old/pool/main/php5-fss/ - Yury Katkov On Fri, Mar 2, 2012 at 10:58 PM, John Du Hart compwhi...@gmail.com wrote: I've never heard of it and do not believe it's in use in production. On Mar

Re: [Wikitech-l] Post-deploy Bug triage for 1.19

2012-03-02 Thread Bergi
Mark A. Hershberger schrieb: When: Friday, February, 21:00UTC Time zone conversion: http://hexm.de/g5 JFYI: We've got March already :-) Bergi ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] diff colors

2012-03-02 Thread Daniel Friesen
That's what browser preferences are for. NOT website preferences. A lot of work has gone into technologies that allow browsers to display the same page in different ways to allow the people with different accessibility issues that conflict with each other to read the same content. The

[MediaWiki-CodeReview] [MediaWiki r112908]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r112908 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112908 Old status: new New status: ok Commit summary for MediaWiki.r112908: Bug 34896 - Update jQuery.json Has whitespace changes (bit of a null diff in many cases)

[MediaWiki-CodeReview] [MediaWiki r81648]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r81648 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81648 Old status: ok New status: resolved Commit summary for MediaWiki.r81648: Fix for renamed stuff that broke jquery.textSelection.js: $.os.name - $.client.platform

Re: [Wikitech-l] diff colors

2012-03-02 Thread John Erling Blad
Contact the organizations for visually impaired people, read W3 accessibility guidelines, and make sure the site works as far as possible. If anyone likes to nag on the browser folks for a better accessibility solution - fine - but fix the skins _now_ and don't wait for some future solution.

[MediaWiki-CodeReview] [MediaWiki r107653]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
IAlex changed the status of MediaWiki.r107653 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107653#c31746 Old Status: fixme New Status: new Commit summary for MediaWiki.r107653: * Inverted the precedence between section edition and revision undoing, now

Re: [Wikitech-l] 2012 Q1 Extension Page Review Drive

2012-03-02 Thread Sumana Harihareswara
On 01/20/2012 07:21 PM, Gregory Varnum wrote: WikiProject Extensions is presenting our first ever Extension Page Review Drive - http://www.mediawiki.org/wiki/Project:WikiProject_Extensions/Projects/Page_Drive Several extension pages are long overdue for review. Many are lacking the

Re: [Wikitech-l] install php-fss on php 5.3

2012-03-02 Thread Jeremy Baron
On Mar 2, 2012 10:01 AM, Yury Katkov katkov.ju...@gmail.com wrote: I want to install php module php-fss on php5.3 since I heard that it boosts MediaWiki performance a lot. Is it possible to do that? Is it installed on wikipedias? On Fri, Mar 2, 2012 at 13:58, John Du Hart compwhi...@gmail.com

[MediaWiki-CodeReview] [MediaWiki r112913]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r112913 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112913 Old status: new New status: ok Commit summary for MediaWiki.r112913: svn:eol-style native ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r112912]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112912 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112912 Old status: new New status: ok Commit summary for MediaWiki.r112912: Use local context to get messages ___

[MediaWiki-CodeReview] [MediaWiki r112641]: New comment added

2012-03-02 Thread MediaWiki Mail
IAlex posted a comment on MediaWiki.r112641. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112641#c31747 Commit summary for MediaWiki.r112641: * Don't execute the LinkBatch if there are now rows * Call methods directly on ResultWrapper instead of DatabaseBase IAlex's comment: That

[MediaWiki-CodeReview] [MediaWiki r112915]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112915 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112915 Old status: new New status: ok Commit summary for MediaWiki.r112915: * Don't execute the LinkBatch if there are now rows * Call methods directly on ResultWrapper instead

[MediaWiki-CodeReview] [MediaWiki r112911]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112911 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112911 Old status: new New status: ok Commit summary for MediaWiki.r112911: Per happy-melon, fix for r107653: don't add the error class on success message

[MediaWiki-CodeReview] [MediaWiki r112917]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r112917 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112917 Old status: new New status: ok Commit summary for MediaWiki.r112917: I break it I fix it ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r112910]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r112910 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112910 Old status: new New status: ok Commit summary for MediaWiki.r112910: release-notes ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r107653]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107653 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107653 Old status: new New status: resolved Commit summary for MediaWiki.r107653: * Inverted the precedence between section edition and revision undoing, now undo and

[MediaWiki-CodeReview] [MediaWiki r112835]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r112835 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112835 Old status: new New status: ok Commit summary for MediaWiki.r112835: fixes to mathjax loading that somehow didn't get committed yesterday?

[MediaWiki-CodeReview] [MediaWiki r112846]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112846 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112846 Old status: new New status: ok Commit summary for MediaWiki.r112846: Localisation update for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r112826]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r112826 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112826 Old status: new New status: ok Commit summary for MediaWiki.r112826: followup to -r112769 - change wgArticlePath back to wgPageName, it is causing a bug

[MediaWiki-CodeReview] [MediaWiki r112917]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r112917 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112917#c31748 Old Status: ok New Status: fixme Commit summary for MediaWiki.r112917: I break it I fix it Siebrand's comment: Doesn't have the intended effect.

[MediaWiki-CodeReview] [MediaWiki r112769]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r112769 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112769#c31749 Old Status: new New Status: resolved Commit summary for MediaWiki.r112769: mw.config use and simplying a function Kaldari's comment: I

[MediaWiki-CodeReview] [MediaWiki r111643]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r111643 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111643 Old status: new New status: resolved Commit summary for MediaWiki.r111643: (bug 34420) - Special:Version should use git You can test it using git init in our $IP

[MediaWiki-CodeReview] [MediaWiki r112705]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112705 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112705 Old status: new New status: ok Commit summary for MediaWiki.r112705: forgot that request has two subtitle strings. followup to r112704

[MediaWiki-CodeReview] [MediaWiki r112864]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112864 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112864 Old status: new New status: ok Commit summary for MediaWiki.r112864: (bug 34863) Make it so an image that was previously deleted and currently does not exist (locally or

[MediaWiki-CodeReview] [MediaWiki r112703]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112703 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112703 Old status: new New status: ok Commit summary for MediaWiki.r112703: more language updates ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r112760]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112760 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112760 Old status: new New status: ok Commit summary for MediaWiki.r112760: small text tweaks per Brandon, followup to r112757 ___

[MediaWiki-CodeReview] [MediaWiki r112920]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r112920 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112920 Old status: new New status: ok Commit summary for MediaWiki.r112920: Third time the bunny jumps, ping r112917, r112919 ___

[MediaWiki-CodeReview] [MediaWiki r112917]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r112917 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112917 Old status: fixme New status: resolved Commit summary for MediaWiki.r112917: I break it I fix it ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r112919]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r112919 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112919 Old status: new New status: resolved Commit summary for MediaWiki.r112919: Apparently someone thinks that explode( ',', '' ) returning array( 0 = '' ) is a good idea.

[MediaWiki-CodeReview] [MediaWiki r112704]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112704 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112704 Old status: new New status: ok Commit summary for MediaWiki.r112704: more language updates, followup to r112703 ___

[MediaWiki-CodeReview] [MediaWiki r112779]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112779 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112779 Old status: new New status: ok Commit summary for MediaWiki.r112779: making sure text is large enough to be readable ___

[MediaWiki-CodeReview] [MediaWiki r112780]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112780 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112780 Old status: new New status: ok Commit summary for MediaWiki.r112780: changing message to account for new go back button ___

Re: [Wikitech-l] 2012 Q1 Extension Page Review Drive

2012-03-02 Thread Mr. Gregory Varnum
I am likely going to reword so it's more pre-Wikimania. It takes about 2-5 minutes a page if you've got the right pages open for copying and paste, etc. Assuming its not a painfully flawed page. :) It helps to have a working knowledge of MW - but nothing too advanced. We need to review code

[MediaWiki-CodeReview] [MediaWiki r111884]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r111884 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111884#c31750 Old Status: new New Status: fixme Commit summary for MediaWiki.r111884: Add support for sorting fractions in jquery.tablesorter Fixes bug 15404

[MediaWiki-CodeReview] [MediaWiki r112767]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112767 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112767 Old status: new New status: ok Commit summary for MediaWiki.r112767: Removed unused parameters ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r112746]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112746 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112746 Old status: new New status: ok Commit summary for MediaWiki.r112746: language changes, followup to r112705 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r112766]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112766 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112766 Old status: new New status: ok Commit summary for MediaWiki.r112766: ContextSource in the Special page ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r110703]: New comment added

2012-03-02 Thread MediaWiki Mail
MarkAHershberger posted a comment on MediaWiki.r110703. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110703#c31751 Commit summary for MediaWiki.r110703: * (bug 33878) Updated file copying functions to account for FileBackend in some key places.* Create temp dir so script does not

[MediaWiki-CodeReview] [MediaWiki r112903]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112903 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112903 Old status: new New status: ok Commit summary for MediaWiki.r112903: Bug 34842 - Ignore spoofing checks displayed twice Unneeded hook is unneeded

[MediaWiki-CodeReview] [MediaWiki r111202]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r111202 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111202#c31752 Old Status: new New Status: fixme Commit summary for MediaWiki.r111202: Fix whitespace Kaldari's comment: Our coding conventions say to avoid

[MediaWiki-CodeReview] [MediaWiki r112664]: New comment added

2012-03-02 Thread MediaWiki Mail
Bsitu posted a comment on MediaWiki.r112664. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112664#c31753 Commit summary for MediaWiki.r112664: updating language to match Howie's google doc linking to actual pages instead of google note: the 'learn more' link target could be written

[MediaWiki-CodeReview] [MediaWiki r112664]: New comment added

2012-03-02 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r112664. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112664#c31754 Commit summary for MediaWiki.r112664: updating language to match Howie's google doc linking to actual pages instead of google note: the 'learn more' link target could be

[MediaWiki-CodeReview] [MediaWiki r112921]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r112921 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112921 Old status: new New status: ok Commit summary for MediaWiki.r112921: Actually fix whitespace from r111202, only 83 characters = no need for silly indentation

[MediaWiki-CodeReview] [MediaWiki r111202]: Revision status changed

2012-03-02 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r111202 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111202 Old status: fixme New status: resolved Commit summary for MediaWiki.r111202: Fix whitespace ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r98045]: New comment added

2012-03-02 Thread MediaWiki Mail
TheDJ posted a comment on MediaWiki.r98045. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98045#c31755 Commit summary for MediaWiki.r98045: Improve the accessibility of our jump-to functionality - Stop hiding with display: none;, this hides our jump links from modern screen readers

Re: [Wikitech-l] diff colors

2012-03-02 Thread Antoine Musso
Le 01/03/12 22:38, Trevor Parscal a écrit : I've gone ahead and resolved bug #11374 after committing r112836. Screenshot of new diff styles: https://bugzilla.wikimedia.org/attachment.cgi?id=10148 Brandon and I talked about the colors and the way color-blind people will perceive them - this

[MediaWiki-CodeReview] [MediaWiki r112901]: New comment added, and revision status changed

2012-03-02 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r112901 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112901#c31756 Old Status: new New Status: ok Commit summary for MediaWiki.r112901: Address Niklas' comment on r112878. s/for/of. Not adding translatable. IMO

[MediaWiki-CodeReview] [MediaWiki r112925]: New comment added

2012-03-02 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r112925. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112925#c31757 Commit summary for MediaWiki.r112925: [SpecialCentralAuth] Fix trailing comma in object literal. This is too much for IE7 too handle. * Fixes: -- (bug 34823) JavaScript error in

Re: [Wikitech-l] diff colors

2012-03-02 Thread Erwin Dokter
On 02-03-2012 23:31, Antoine Musso wrote: Le 01/03/12 22:38, Trevor Parscal a écrit : I've gone ahead and resolved bug #11374 after committing r112836. Screenshot of new diff styles: https://bugzilla.wikimedia.org/attachment.cgi?id=10148 Brandon and I talked about the colors and the way

[MediaWiki-CodeReview] [MediaWiki r112664]: New comment added

2012-03-02 Thread MediaWiki Mail
Raindrift posted a comment on MediaWiki.r112664. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112664#c31758 Commit summary for MediaWiki.r112664: updating language to match Howie's google doc linking to actual pages instead of google note: the 'learn more' link target could be

Re: [Wikitech-l] diff colors

2012-03-02 Thread Trevor Parscal
Erwin - what you are seeing is very strange. I tried to re-create it, but you have other styles conflicting and causing problems. For instance, the use of red text for the changed text is gone int he latest code. You may also have other strange styles which may be affecting layout. Attached is how

[MediaWiki-CodeReview] [Wikimedia r1400]: New comment added

2012-03-02 Thread MediaWiki Mail
Pgehres (WMF) posted a comment on Wikimedia.r1400. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1400#c31759 Commit summary for Wikimedia.r1400: Added _civicrm_recurring_globalcollect_update_record_success() to address issues with r1392. Pgehres (WMF)'s comment: I know I wasn't

  1   2   >